[AArch64, Docs, Patch] Add reference to ACLE in docs.

[AArch64, Docs, Patch] Add reference to ACLE in docs.

[Tejas Belagod]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi,

Here is patch that consolidates AArch64 and ARM Intrinsics sections in 
extend.texi into one ACLE section to avoid information repetition and 
adds reference to the ARM C Language Extension spec on infocenter.arm.com.

Built aarch64-none-elf and viewed gcc.info and associated HTML. OK for 
trunk?

Thanks,
Tejas.

2014-10-28  Tejas Belagod  <tejas.belagod@arm.com>

gcc/
     * Makefile.in (TEXI_GCC_FILES): Remove arm-acle-intrinsics.texi,
     arm-neon-intrinsics.texi, aarch64-acle-intrinsics.texi.
     * doc/aarch64-acle-intrinsics.texi: Remove.
     * doc/arm-acle-intrinsics.texi: Remove.
     * doc/arm-neon-intrinsics.texi: Remove.
     * doc/extend.texi: Consolidate sections AArch64 intrinsics,
     ARM NEON Intrinsics, ARM ACLE Intrinsics into one ARM C Language
     Extension section. Add references to public ACLE specification.

[-- Attachment #2: intrinsics-doc-2.txt.gz --]
[-- Type: application/gzip, Size: 19924 bytes --]

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Joseph S. Myers]

On Tue, 28 Oct 2014, Tejas Belagod wrote:

> Hi,
> 
> Here is patch that consolidates AArch64 and ARM Intrinsics sections in
> extend.texi into one ACLE section to avoid information repetition and adds
> reference to the ARM C Language Extension spec on infocenter.arm.com.

This seems to lose the information about which extensions are supported by 
GCC (given that not all of ACLE is supported; e.g. arm_acle.h has only the 
CRC intrinsics, while __fp16 isn't supported for AArch64 and the support 
for ARM corresponds to an older version of the specification).

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Tejas Belagod]

On 29/10/14 00:22, Joseph S. Myers wrote:
> On Tue, 28 Oct 2014, Tejas Belagod wrote:
>
>> Hi,
>>
>> Here is patch that consolidates AArch64 and ARM Intrinsics sections in
>> extend.texi into one ACLE section to avoid information repetition and adds
>> reference to the ARM C Language Extension spec on infocenter.arm.com.
>
> This seems to lose the information about which extensions are supported by
> GCC (given that not all of ACLE is supported; e.g. arm_acle.h has only the
> CRC intrinsics, while __fp16 isn't supported for AArch64 and the support
> for ARM corresponds to an older version of the specification).
>

If I mention in a couple of sentences the level of ACLE support there is 
in GCC currently, this section will need to be updated every time there 
is an improvement in ACLE support - I guess we'll just have to remember 
to remove parts of this section as we do that.

Thanks for the review, I'll respin the patch.

Thanks,
Tejas.

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Joseph Myers]

On Mon, 3 Nov 2014, Tejas Belagod wrote:

> If I mention in a couple of sentences the level of ACLE support there is in
> GCC currently, this section will need to be updated every time there is an
> improvement in ACLE support - I guess we'll just have to remember to remove
> parts of this section as we do that.

Yes, it's generally the case when adding new user-visible features that 
documentation needs updating.  The release notes (gcc-N/changes.html in 
htdocs) should be updated for any significant new features as well.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Tejas Belagod]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

On 03/11/14 17:58, Joseph Myers wrote:
> On Mon, 3 Nov 2014, Tejas Belagod wrote:
>
>> If I mention in a couple of sentences the level of ACLE support there is in
>> GCC currently, this section will need to be updated every time there is an
>> improvement in ACLE support - I guess we'll just have to remember to remove
>> parts of this section as we do that.
>
> Yes, it's generally the case when adding new user-visible features that
> documentation needs updating.  The release notes (gcc-N/changes.html in
> htdocs) should be updated for any significant new features as well.
>

Thanks. The AArch64 ACLE CRC32 intrinsics were introduced in 4.9, so its 
not new in 5.0 - https://gcc.gnu.org/gcc-4.9/changes.html. But we've 
improved AArch64 NEON Intrinsics in 5.0 significantly which deserves a 
mention. I'll do that in a separate patch.

Revised patch to fix extend.texi for ACLE attached. OK for trunk?

Thanks,
Tejas.

2014-11-04  Tejas Belagod  <tejas.belagod@arm.com>

gcc/
     * Makefile.in (TEXI_GCC_FILES): Remove arm-acle-intrinsics.texi,
     arm-neon-intrinsics.texi, aarch64-acle-intrinsics.texi.
     * doc/aarch64-acle-intrinsics.texi: Remove.
     * doc/arm-acle-intrinsics.texi: Remove.
     * doc/arm-neon-intrinsics.texi: Remove.
     * doc/extend.texi: Consolidate sections AArch64 intrinsics,
     ARM NEON Intrinsics, ARM ACLE Intrinsics into one ARM C Language
     Extension section. Add references to public ACLE specification.

[-- Attachment #2: intrinsics-doc-3.txt.gz --]
[-- Type: application/gzip, Size: 20096 bytes --]

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Richard Earnshaw]

On 04/11/14 13:17, Tejas Belagod wrote:
> On 03/11/14 17:58, Joseph Myers wrote:
>> On Mon, 3 Nov 2014, Tejas Belagod wrote:
>>
>>> If I mention in a couple of sentences the level of ACLE support there is in
>>> GCC currently, this section will need to be updated every time there is an
>>> improvement in ACLE support - I guess we'll just have to remember to remove
>>> parts of this section as we do that.
>>
>> Yes, it's generally the case when adding new user-visible features that
>> documentation needs updating.  The release notes (gcc-N/changes.html in
>> htdocs) should be updated for any significant new features as well.
>>
> 
> Thanks. The AArch64 ACLE CRC32 intrinsics were introduced in 4.9, so its 
> not new in 5.0 - https://gcc.gnu.org/gcc-4.9/changes.html. But we've 
> improved AArch64 NEON Intrinsics in 5.0 significantly which deserves a 
> mention. I'll do that in a separate patch.
> 
> Revised patch to fix extend.texi for ACLE attached. OK for trunk?
> 
> Thanks,
> Tejas.
> 
> 2014-11-04  Tejas Belagod  <tejas.belagod@arm.com>
> 
> gcc/
>      * Makefile.in (TEXI_GCC_FILES): Remove arm-acle-intrinsics.texi,
>      arm-neon-intrinsics.texi, aarch64-acle-intrinsics.texi.
>      * doc/aarch64-acle-intrinsics.texi: Remove.
>      * doc/arm-acle-intrinsics.texi: Remove.
>      * doc/arm-neon-intrinsics.texi: Remove.
>      * doc/extend.texi: Consolidate sections AArch64 intrinsics,
>      ARM NEON Intrinsics, ARM ACLE Intrinsics into one ARM C Language
>      Extension section. Add references to public ACLE specification.
> 

> +Extensions(ACLE) specification, which can be found at

Space before parenthesis.

> +@node ARM C Language Extensions

I think this should keep the ACLE in parenthesis, so

+@node ARM C Language Extensions (ACLE)

> +back-ends support CRC32 intrinsics from arm_acle.h. ARM backend's 16-bit

@file{} around arm_acle.h.  s/ARM/The ARM/

OK with those changes.

R.

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

[Tejas Belagod]

[-- Attachment #1: Type: text/plain, Size: 2121 bytes --]

On 07/11/14 13:09, Richard Earnshaw wrote:
> On 04/11/14 13:17, Tejas Belagod wrote:
>> On 03/11/14 17:58, Joseph Myers wrote:
>>> On Mon, 3 Nov 2014, Tejas Belagod wrote:
>>>
>>>> If I mention in a couple of sentences the level of ACLE support there is in
>>>> GCC currently, this section will need to be updated every time there is an
>>>> improvement in ACLE support - I guess we'll just have to remember to remove
>>>> parts of this section as we do that.
>>>
>>> Yes, it's generally the case when adding new user-visible features that
>>> documentation needs updating.  The release notes (gcc-N/changes.html in
>>> htdocs) should be updated for any significant new features as well.
>>>
>>
>> Thanks. The AArch64 ACLE CRC32 intrinsics were introduced in 4.9, so its
>> not new in 5.0 - https://gcc.gnu.org/gcc-4.9/changes.html. But we've
>> improved AArch64 NEON Intrinsics in 5.0 significantly which deserves a
>> mention. I'll do that in a separate patch.
>>
>> Revised patch to fix extend.texi for ACLE attached. OK for trunk?
>>
>> Thanks,
>> Tejas.
>>
>> 2014-11-04  Tejas Belagod  <tejas.belagod@arm.com>
>>
>> gcc/
>>       * Makefile.in (TEXI_GCC_FILES): Remove arm-acle-intrinsics.texi,
>>       arm-neon-intrinsics.texi, aarch64-acle-intrinsics.texi.
>>       * doc/aarch64-acle-intrinsics.texi: Remove.
>>       * doc/arm-acle-intrinsics.texi: Remove.
>>       * doc/arm-neon-intrinsics.texi: Remove.
>>       * doc/extend.texi: Consolidate sections AArch64 intrinsics,
>>       ARM NEON Intrinsics, ARM ACLE Intrinsics into one ARM C Language
>>       Extension section. Add references to public ACLE specification.
>>
>
>> +Extensions(ACLE) specification, which can be found at
>
> Space before parenthesis.
>
>> +@node ARM C Language Extensions
>
> I think this should keep the ACLE in parenthesis, so
>
> +@node ARM C Language Extensions (ACLE)
>
>> +back-ends support CRC32 intrinsics from arm_acle.h. ARM backend's 16-bit
>
> @file{} around arm_acle.h.  s/ARM/The ARM/
>
> OK with those changes.
>

Thanks. Attached patch committed.

Tejas.

[-- Attachment #2: intrinsics-doc-4.txt.gz --]
[-- Type: application/gzip, Size: 20103 bytes --]