From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7580 invoked by alias); 11 Nov 2014 16:26:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7571 invoked by uid 89); 11 Nov 2014 16:26:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 11 Nov 2014 16:26:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sABGQLL5030401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Nov 2014 11:26:22 -0500 Received: from [10.3.113.31] (ovpn-113-31.phx2.redhat.com [10.3.113.31]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sABGQLWG015534; Tue, 11 Nov 2014 11:26:21 -0500 Message-ID: <546238AA.1000506@redhat.com> Date: Tue, 11 Nov 2014 16:31:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: Remove for_each_rtx References: <87vbmlivy5.fsf@e105548-lin.cambridge.arm.com> In-Reply-To: <87vbmlivy5.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg01037.txt.bz2 On 11/11/14 08:44, Richard Sandiford wrote: > There are no more callers to for_each_rtx or for_each_rtx_in_insn, > so this patch removes the functions. > > Tested on x86_64-linux-gnu. OK to install? > > Thanks, > Richard > > > gcc/ > * rtl.h (rtx_function, for_each_rtx, for_each_rtx_in_insn): Delete. > * rtlanal.c (non_rtx_starting_operands, for_each_rtx_1, for_each_rtx): > (for_each_rtx_in_insn): Delete. > (init_rtlanal): Remove initialization of non_rtx_starting_operands. > * df-core.c: Remove reference to for_each_rtx in comment. Yes. And in general, I think removing an unused, non-debug function ought to be considered obvious to install w/o review. While there's some concern about breaking out-of-tree ports, I think getting the dead code out of GCC proper trumps that concern. There's a path forward for out-of-tree ports and it's the natural cost of keeping a port out-of-tree. jeff