From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13390 invoked by alias); 14 Nov 2014 04:59:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13381 invoked by uid 89); 14 Nov 2014 04:59:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Nov 2014 04:59:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAE4xTx7006678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Nov 2014 23:59:29 -0500 Received: from [10.3.113.31] (ovpn-113-31.phx2.redhat.com [10.3.113.31]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAE4xSj1005408; Thu, 13 Nov 2014 23:59:28 -0500 Message-ID: <54658C2D.4070506@redhat.com> Date: Fri, 14 Nov 2014 05:32:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "H.J. Lu" CC: Alexander Ivchenko , GCC Patches , enh , Andrew Hsieh Subject: Re: [Android] Enable ifuncs on Android References: <5464EC1A.6070709@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg01657.txt.bz2 On 11/13/14 21:46, H.J. Lu wrote: > > Hi Jeff, > > I believe the patch is correct. Not all glibcs support IFUNC. It doesn't mean > we should disable IFUNC for all glibcs. By default, we do a configure time > check for IFUNC. We DO want to use configure time check for IFUNC for > Android NDK. >I I'm sorry, I'm objecting to this patch. It is wrong for GCC to produce code that is incorrect solely for the benefit of optimizing for a new release of a library. The right way is to trigger the new code on some configure time option or a new configuration itself. Whether or not GCC is doing this right for glibc is irrelevant, the patch is _wrong_. jeff