From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23405 invoked by alias); 18 Nov 2014 02:46:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23371 invoked by uid 89); 18 Nov 2014 02:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD,UPPERCASE_50_75 autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 18 Nov 2014 02:46:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAI2kVkH024716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Nov 2014 21:46:31 -0500 Received: from [10.3.113.65] (ovpn-113-65.phx2.redhat.com [10.3.113.65]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAI2kUDw007787; Mon, 17 Nov 2014 21:46:30 -0500 Message-ID: <546AB305.5030501@redhat.com> Date: Tue, 18 Nov 2014 02:56:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: David Edelsohn , Ilya Enkovich CC: GCC Patches Subject: Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls References: <546A414E.6040905@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg02195.txt.bz2 On 11/17/14 19:06, David Edelsohn wrote: > The following patch seems to allow me to at least build stage1 GCC. > We'll see how far it get through bootstrap and testing. Hopefully it > is a work-around until we find a complete solution. > > Thanks, David > > Index: tree-core.h > =================================================================== > --- tree-core.h (revision 217658) > +++ tree-core.h (working copy) > @@ -170,10 +170,38 @@ > > BEGIN_CHKP_BUILTINS, > > -#undef DEF_BUILTIN > -#define DEF_BUILTIN(ENUM, N, C, T, LT, B, F, NA, AT, IM, COND) ENUM##_CHKP, > -#include "builtins.def" > + BUILT_IN_MEMCPY_CHKP, > + BUILT_IN_MEMPCPY_CHKP, > + BUILT_IN_MEMMOVE_CHKP, > + BUILT_IN_MEMSET_CHKP, > + BUILT_IN_CHKP_MEMCPY_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMPCPY_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMMOVE_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMSET_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMCPY_NOBND_CHKP, > + BUILT_IN_CHKP_MEMPCPY_NOBND_CHKP, > + BUILT_IN_CHKP_MEMMOVE_NOBND_CHKP, > + BUILT_IN_CHKP_MEMSET_NOBND_CHKP, > + BUILT_IN_CHKP_MEMCPY_NOBND_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMPCPY_NOBND_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMMOVE_NOBND_NOCHK_CHKP, > + BUILT_IN_CHKP_MEMSET_NOBND_NOCHK_CHKP, > + BUILT_IN_MEMCPY_CHK_CHKP, > + BUILT_IN_MEMPCPY_CHK_CHKP, > > + BUILT_IN_STPCPY_CHKP, > + BUILT_IN_STRCAT_CHKP, > + BUILT_IN_STRCHR_CHKP, > + BUILT_IN_STRCPY_CHKP, > + BUILT_IN_STRPCPY_CHKP, > + BUILT_IN_STRLEN_CHKP, > + BUILT_IN_STPCPY_CHK_CHKP, > + BUILT_IN_STRCAT_CHK_CHKP, > + BUILT_IN_STRCHR_CHK_CHKP, > + BUILT_IN_STRCPY_CHK_CHKP, > + BUILT_IN_STRPCPY_CHK_CHKP, > + BUILT_IN_STRLEN_CHK_CHKP, I think this will break all the code though since there's no mapping from the original enumeration value for the builtin to the new one for the checker. jeff