From: Renlin Li <renlin.li@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: marcus Shawcroft <Marcus.Shawcroft@arm.com>,
ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: Re: [PING][PATCH][AARCH64]Fix PR63424 by adding <su><maxmin>v2di3 pattern
Date: Wed, 19 Nov 2014 11:11:00 -0000 [thread overview]
Message-ID: <546C77D4.3020801@arm.com> (raw)
In-Reply-To: <5460EDF8.3010106@arm.com>
On 10/11/14 16:55, Renlin Li wrote:
> On 06/11/14 15:00, Renlin Li wrote:
>> Hi all,
>>
>> Dose anybody have time to review this?
>>
>> Kind regards,
>> Renlin Li
>>
>> On 31/10/14 14:51, Renlin Li wrote:
>>> Hi all,
>>>
>>> This is a patch which will fix PR63424.
>>>
>>> It implements signed/unsigned max/min pattern for V2DI mode in terms
>>> of vcondv2div2di pattern.
>>>
>>> In this particular case, VEC_COND_EXPR (V2DImode) is generated as
>>> aarch64 target supports it (vcond<mode><mode> for VALL). The
>>> VEC_COND_EXPR will further folded into MIN_EXPR/MAX_EXPR in dom pass
>>> unconditionally. Later in expand pass, the compiler tries to expand
>>> min_expr using standard RTL operation. It fails, because aarch64
>>> target don't have minv2di3 pattern implemented. It then tries to
>>> generate conditional move and compare&branch sequence, all fails. At
>>> last it falls into libfunc call, no luck either. An ICE to complain
>>> about this.
>>>
>>> aarch64-none-elf toolchain has been tested on the model, no
>>> regressions.
>>>
>>> Is it Okay for trunk?
>>>
>>> gcc/ChangeLog:
>>>
>>> 2014-10-31 Renlin Li <Renlin.Li@arm.com>
>>> PR target/63424
>>> * config/aarch64/aarch64-simd.md (<su><maxmin>v2di3): New.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2014-10-31 Renlin Li <Renlin.Li@arm.com>
>>> PR target/63424
>>> * gcc.target/aarch64/pr63424.c: New.
>>
> Hi,
>
> Dose anybody have time to review this?
>
> Thank you so much!
>
> Regards,
> Renlin Li
Ping again.
Regards,
Renlin Li
next prev parent reply other threads:[~2014-11-19 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 14:57 [PATCH][AARCH64]Fix " Renlin Li
2014-11-06 15:00 ` [PING][PATCH][AARCH64]Fix " Renlin Li
2014-11-10 16:59 ` Renlin Li
2014-11-19 11:11 ` Renlin Li [this message]
2014-11-19 11:44 ` [PATCH][AARCH64]Fix " Richard Henderson
2014-11-19 16:51 ` Renlin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546C77D4.3020801@arm.com \
--to=renlin.li@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).