From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10523 invoked by alias); 19 Nov 2014 10:58:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10505 invoked by uid 89); 19 Nov 2014 10:58:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Nov 2014 10:58:34 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 19 Nov 2014 10:58:31 +0000 Received: from [10.1.203.158] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 19 Nov 2014 10:58:29 +0000 Message-ID: <546C77D4.3020801@arm.com> Date: Wed, 19 Nov 2014 11:11:00 -0000 From: Renlin Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: marcus Shawcroft , ramana Radhakrishnan Subject: Re: [PING][PATCH][AARCH64]Fix PR63424 by adding v2di3 pattern References: <5453A1E8.1070003@arm.com> <545B8D0B.2080109@arm.com> <5460EDF8.3010106@arm.com> In-Reply-To: <5460EDF8.3010106@arm.com> X-MC-Unique: 114111910583112901 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg02433.txt.bz2 On 10/11/14 16:55, Renlin Li wrote: > On 06/11/14 15:00, Renlin Li wrote: >> Hi all, >> >> Dose anybody have time to review this? >> >> Kind regards, >> Renlin Li >> >> On 31/10/14 14:51, Renlin Li wrote: >>> Hi all, >>> >>> This is a patch which will fix PR63424. >>> >>> It implements signed/unsigned max/min pattern for V2DI mode in terms=20 >>> of vcondv2div2di pattern. >>> >>> In this particular case, VEC_COND_EXPR (V2DImode) is generated as=20 >>> aarch64 target supports it (vcond for VALL). The=20 >>> VEC_COND_EXPR will further folded into MIN_EXPR/MAX_EXPR in dom pass=20 >>> unconditionally. Later in expand pass, the compiler tries to expand=20 >>> min_expr using standard RTL operation. It fails, because aarch64=20 >>> target don't have minv2di3 pattern implemented. It then tries to=20 >>> generate conditional move and compare&branch sequence, all fails. At=20 >>> last it falls into libfunc call, no luck either. An ICE to complain=20 >>> about this. >>> >>> aarch64-none-elf toolchain has been tested on the model, no=20 >>> regressions. >>> >>> Is it Okay for trunk? >>> >>> gcc/ChangeLog: >>> >>> 2014-10-31 Renlin Li >>> PR target/63424 >>> * config/aarch64/aarch64-simd.md (v2di3): New. >>> >>> gcc/testsuite/ChangeLog: >>> >>> 2014-10-31 Renlin Li >>> PR target/63424 >>> * gcc.target/aarch64/pr63424.c: New. >> > Hi, > > Dose anybody have time to review this? > > Thank you so much! > > Regards, > Renlin Li Ping again. Regards, Renlin Li