From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18050 invoked by alias); 19 Nov 2014 14:54:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18041 invoked by uid 89); 19 Nov 2014 14:54:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mx08-00178001.pphosted.com Received: from mx08-00178001.pphosted.com (HELO mx08-00178001.pphosted.com) (91.207.212.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 19 Nov 2014 14:54:30 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.14.5/8.14.5) with SMTP id sAJErtvh023292; Wed, 19 Nov 2014 15:54:23 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 1qr7emdbkv-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 19 Nov 2014 15:54:23 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6FC7738; Wed, 19 Nov 2014 14:53:51 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 917F15A8F5; Wed, 19 Nov 2014 14:54:21 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.342.0; Wed, 19 Nov 2014 15:54:21 +0100 Message-ID: <546CAF1C.3070803@st.com> Date: Wed, 19 Nov 2014 14:59:00 -0000 From: Christian Bruel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "ramrad01@arm.com" Cc: Ramana Radhakrishnan , Richard Earnshaw , Terry Guo , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [0/6] References: <546C9A28.7050309@st.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.28,0.0.0000 definitions=2014-11-19_04:2014-11-19,2014-11-19,1970-01-01 signatures=0 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg02485.txt.bz2 On 11/19/2014 03:18 PM, Ramana Radhakrishnan wrote: > On Wed, Nov 19, 2014 at 1:24 PM, Christian Bruel wrote: > >> I think I missed the stage3, Anyway would it be OK for stage1 when it >> reopens ? > > Since you submitted this well during stage1 and given that these > patches address comments from earlier in the review process we should > aim to get these in for 5.0. If at some point during the review > process it looks risky and there needs to be significant rework we can > always stop. It's on the list of patches to be reviewed and I will > find some dedicated time later this week to set down and review / play > with the patches in an attempt to move this forward as it is a > reasonably large chunk of work. Thanks, also I forgot to mention that you need https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01231.html to play with the attribute. Will be part of the same shot. Christian > > Thanks for continuing to work on these patches and addressing the > earlier review comments. > > regards > Ramana > >> >> Christian >>