From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15091 invoked by alias); 24 Nov 2014 08:57:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15038 invoked by uid 89); 24 Nov 2014 08:57:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 24 Nov 2014 08:57:26 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAO8vJXH010261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Nov 2014 03:57:20 -0500 Received: from pike.twiddle.home (vpn1-5-11.ams2.redhat.com [10.36.5.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAO8vGXo000505; Mon, 24 Nov 2014 03:57:17 -0500 Message-ID: <5472F2EA.9000702@redhat.com> Date: Mon, 24 Nov 2014 09:49:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Zhenqiang Chen , gcc-patches@gcc.gnu.org CC: Marcus Shawcroft Subject: Re: [PATCH, AARCH64] Fix ICE in CCMP (PR64015) References: <000101d007a5$0d120f30$27362d90$@arm.com> In-Reply-To: <000101d007a5$0d120f30$27362d90$@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg02980.txt.bz2 On 11/24/2014 06:11 AM, Zhenqiang Chen wrote: > Expand pass always uses sign-extend to represent constant value. For the > case in the patch, a 8-bit unsigned value "252" is represented as "-4", > which pass the ccmn check. After mode conversion, "-4" becomes "252", which > leads to mismatch. This sort of thing is why I suggested from the beginning that expansion happen directly from trees instead of sort-of re-expanding from rtl. I think you're better off fixing this properly than hacking around it here. r~