From: Jason Merrill <jason@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch c++]: Fix PR/53904
Date: Tue, 25 Nov 2014 20:15:00 -0000 [thread overview]
Message-ID: <5474CB66.6030000@redhat.com> (raw)
In-Reply-To: <CAEwic4bN8mKygQk_30k8w-n3A-Q2181tQEzUFm3Y5W48ZWVHMg@mail.gmail.com>
On 11/20/2014 02:48 PM, Kai Tietz wrote:
> this issue fixes a type-overflow issue caused by trying to cast a UHWI
> via tree_to_shwi.
> As soon as value gets larger then SHWI_MAX, we get an error for it.
> So we need to cast it via tree_to_uhwi, and then casting it to the signed variant.
The problem seems to be with zero-length arrays getting -1 from
array_type_nelts. Let's use array_type_nelts_top instead so we don't
ever see negative values.
Jason
next prev parent reply other threads:[~2014-11-25 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 20:14 Kai Tietz
2014-11-21 11:42 ` Richard Biener
2014-11-25 20:15 ` Jason Merrill [this message]
2014-11-26 18:14 ` Kai Tietz
2014-11-26 18:51 ` Jason Merrill
2014-11-27 20:57 ` H.J. Lu
2014-11-27 21:44 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474CB66.6030000@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).