Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

[Andrew Stubbs <andrew_stubbs@mentor.com>]

On 02/12/14 21:45, Ramana Radhakrishnan wrote:
> I've spent some time this evening pondering over your patch. Firstly
> it appears that the current behaviour is going to cause more breakage
> than originally expected. If this is to go in we'd have a number of
> users having to add -mfloat-abi=soft to the command line option to
> ensure that -march=armv5te works just fine on the files where
> march=armv5te in the first places.

Agreed. I've just reverted the patch.

> I'm not sure that the original patch is enough.
>
> The tools have always allowed us to drop down the arch to
> march=armv5te along with using -mfpu=neon. We are now changing command
> line behaviour, so an inform in terms of diagnostics to the user would
> be useful as it states that we don't really have mfpu=neon generating
> neon code any more because of this particular case. If we are to do
> this then the original patch is probably not enough as it then doesn't
> handle the case of TARGET_VFP3 / TARGET_VFP5 / TARGET_NEON_FP16 /
> TARGET_FP16 / TARGET_FPU_ARMV8 etc. etc. etc.

I'll take a look at those shortly.

Andrew