From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 68951385743B for ; Mon, 2 Aug 2021 13:07:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68951385743B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42d.google.com with SMTP id m12so16630648wru.12 for ; Mon, 02 Aug 2021 06:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X8nsrERYGAh1863Fa6SNk3BnPmZLRBx202ZrwboL8hE=; b=tTCdzFVj+s5VkqEqXk4MQexOsGevik03ZRP0611ps8gbVtyc8srd2oNoVOLaGVCAk6 L0TMDWxXB/cMjjyQlj4vOMEaVSM0s4i7/pSW7bHetc1nbe1c9qZHOI+HUfPx/K8dHYCM pAqqd+ukdKQITWgs2ILsUVqTtr+KUuK02jbU9amVAaXjree2pjnuQEa4gDEN+1DijQRP gtjXFge5iJ4ErrHJ9Sc5BCJalq5UnU9rpifUwp3qbvcDCoa5IngQwL/bMLQECrV0oLD+ W/GbUDdWOIT9QdqJ4JGFFzrlX/8VRoM6lldJT+g41tvycS6rs4SCTo2ZdguwglUnpUko zwnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X8nsrERYGAh1863Fa6SNk3BnPmZLRBx202ZrwboL8hE=; b=WT8/BhWOzycUI1/VeQTXGUrMrSrjUBjRRJfVIYW537K7S9W1lp2GfymfJ9IeQ/XmXY kjqI1mIom+2a0JAOumISy57G0eZmLgUGBKslcDA8dg0RtFyPfZJpy2FjapF3pePgTpDT OF3fW3DJSa8AUebCeK1wZgxw4sslXceTu6FmOCd95djIOZlHQBBBT2Vsf0+ckU/AOp5S qKYnAKj7tRwilcqquKCmfvkkvd61jKL1TCMTtV6cHPM6BmtwAXxOXVsPE35JPG/RLbAx VOCvpre+DbRHmOIeRDYOQRDmUW3R24hOWrZAeSK2ustswXY1QkxOVnCU3Nk374FcnQL5 o7Qg== X-Gm-Message-State: AOAM530bIaIdqY+2nT3wgihM3uS5ep6DxiUtOs0aRv3ztSmeKnzFZ5RR SkM5W9ppjO/osisb+bbIwoB3gw== X-Google-Smtp-Source: ABdhPJy17X30WejFhn8CCGNmn2rCES20Pomb9bB112jZpAl4oAUTEW15H5JtK482QkgXYcqraIkLJQ== X-Received: by 2002:adf:fc12:: with SMTP id i18mr17177916wrr.138.1627909636650; Mon, 02 Aug 2021 06:07:16 -0700 (PDT) Received: from arcturus.localnet ([2a01:cb10:8647:7500:91f1:5b1d:74b:10d6]) by smtp.gmail.com with ESMTPSA id 18sm3819073wmo.2.2021.08.02.06.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 06:07:16 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Bernd Edlinger Cc: "gcc-patches@gcc.gnu.org" , Richard Biener , Arnaud Charlet Subject: Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions Date: Mon, 02 Aug 2021 15:07:47 +0200 Message-ID: <5484735.DvuYhMxLoT@arcturus> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 13:07:23 -0000 > It was pointed out in PR101598 to be inappropriate, that > ignored Ada decls receive the source line number which was > recorded in the function decl's DECL_SOURCE_LOCATION. > Therefore set all front-end-generated Ada decls with > DECL_IGNORED_P to UNKNOWN_LOCATION. > > 2021-07-24 Bernd Edlinger > > PR debug/101598 > * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the > DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to > UNKNOWN_LOCATION. Is that really needed in DWARF 5? If no, I'm not sure that we want it. -- Eric Botcazou