From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24676 invoked by alias); 9 Dec 2014 20:48:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24662 invoked by uid 89); 9 Dec 2014 20:48:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Dec 2014 20:48:14 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB9KleDU004789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 Dec 2014 15:47:56 -0500 Received: from [10.3.113.190] (ovpn-113-190.phx2.redhat.com [10.3.113.190]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB9Jv7mi017420; Tue, 9 Dec 2014 14:57:07 -0500 Message-ID: <54875413.40701@redhat.com> Date: Tue, 09 Dec 2014 20:48:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Ilya Enkovich , Joseph Myers CC: Andi Kleen , gcc-patches Subject: Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library References: <20141119141555.GD47331@msticlxl57.ims.intel.com> <546CD981.1040002@redhat.com> <20141121153405.GB30483@msticlxl57.ims.intel.com> <20141124140232.GA9490@msticlxl57.ims.intel.com> <20141209082439.GA16560@msticlxl57.ims.intel.com> In-Reply-To: <20141209082439.GA16560@msticlxl57.ims.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00839.txt.bz2 On 12/09/14 01:24, Ilya Enkovich wrote: > On 24 Nov 17:02, Ilya Enkovich wrote: >> >> Right. This works for both top level and multilib checks because failing test is used and CC is usually not set when it's called by the top level configure. If we configure with CC=... then it may go wrong. I left only target check in configure.tgt and inlined test for x32 into libmpx configure. >> >>> >>> -- >>> Joseph S. Myers >>> joseph@codesourcery.com >> >> Here is an updated version. >> >> Thanks, >> Ilya >> -- > > Here is an updated version. I moved linker specs to target. Currently mpx libraries are built for x86_64-*-linux* | i?86-*-linux*, so I think gcc/config/i386/linux-common.h is a proper place for LIBMPX delcarations. > > Thanks, > Ilya > -- > 2014-12-09 Ilya Enkovich > > * Makefile.def: Add libmpx. > * configure.ac: Add libmpx. > * Makefile.in: Regenerate. > * configure: Regenerate. > > gcc/ > > 2014-12-09 Ilya Enkovich > > * config/i386/linux-common.h (LIBMPX_LIBS): New. > (LIBMPX_SPEC): New. > (CHKP_SPEC): New. > * gcc.c (CHKP_SPEC): New. > (LINK_COMMAND_SPEC): Add CHKP_SPEC. > * c-family/c.opt (static-libmpx): New. > > libmpx/ > > diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt > index b9f7c65..65731cc 100644 > --- a/gcc/c-family/c.opt > +++ b/gcc/c-family/c.opt > @@ -1020,6 +1020,9 @@ fchkp-instrument-marked-only > C ObjC C++ ObjC++ LTO Report Var(flag_chkp_instrument_marked_only) Init(0) > Instrument only functions marked with bnd_instrument attribute. > > +static-libmpx > +Driver > + > fcilkplus > C ObjC C++ ObjC++ LTO Report Var(flag_cilkplus) Init(0) > Enable Cilk Plus Wasn't this duplicated in the mpx-wrapper patch? I think this is OK on the technical side. I need to do to some vote tallying on the steering committee side WRT licensing, ownership of the sources, canonical source location, etc, so please don't commit yet. jeff