From: Jeff Law <law@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/4] Add Visium support to gcc
Date: Tue, 23 Dec 2014 20:22:00 -0000 [thread overview]
Message-ID: <5499C725.70409@redhat.com> (raw)
In-Reply-To: <2262251.mrrELjuWpe@polaris>
On 12/22/14 04:14, Eric Botcazou wrote:
> Revised version after Joseph's comments and latest libgcc changes.
>
>
> gcc/ChangeLog
>
> 2014-12-22 Eric Botcazou <ebotcazou@adacore.com>
>
> * config.gcc: Add Visium support.
> * configure.ac: Likewise.
> * configure: Regenerate.
> * doc/extend.texi (interrupt attribute): Add Visium.
> * doc/invoke.texi: Document Visium options.
> * doc/install.texi: Document Visium target.
> * doc/md.texi: Document Visium constraints.
> * common/config/visium: New directory.
> * config/visium: Likewise.
I don't see anything particularly offensive. Actually it looks like a
reasonably clean RISC port.
I'm a little concerned about the MODES_TIEABLE_P definition, but if it's
working, I wouldn't mess with it.
Any thoughts on using LRA for this port? Ideally we want to be moving
away from reload as much as we can.
I didn't look closely, do you need blockage insns in your epilogue/prologue?
For the prologue, if you store callee saved registers using the frame
pointer, then you need a blockage to ensure those stores don't bubble up
before the local stack gets allocated. And you need something analogous
in the epilogue. I didn't check your port carefully for this, but I'd
advise doing so.
Presumably you're going to be the maintainer for this port? If not you,
then who will maintain the port (so i can get maintainership officially
blessed by the SC).
I think this is good to go into the trunk. The blockage issue (if it's
an issue) can be resolved as a follow-up.
Jeff
next prev parent reply other threads:[~2014-12-23 19:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 0:06 [PATCH 0/4] GCC port for the Visium Eric Botcazou
2014-12-12 0:10 ` [PATCH 1/4] Add Visium support to toplevel Eric Botcazou
2014-12-22 5:00 ` Jeff Law
2014-12-12 0:11 ` [PATCH 2/4] Add Visium support to libgcc Eric Botcazou
2014-12-12 0:17 ` Joseph Myers
2014-12-15 10:02 ` Eric Botcazou
2014-12-16 23:59 ` Joseph Myers
2014-12-17 16:40 ` Eric Botcazou
2014-12-19 22:43 ` Eric Botcazou
2014-12-22 6:34 ` Jeff Law
2014-12-12 0:12 ` [PATCH 3/4] Add Visium support to gcc Eric Botcazou
2014-12-12 0:26 ` Joseph Myers
2014-12-12 2:35 ` Hans-Peter Nilsson
2014-12-15 11:27 ` Eric Botcazou
2014-12-17 0:04 ` Joseph Myers
2014-12-20 22:51 ` Eric Botcazou
2014-12-22 11:21 ` Eric Botcazou
2014-12-23 20:22 ` Jeff Law [this message]
2015-01-03 15:19 ` Eric Botcazou
2015-01-05 19:38 ` Jeff Law
2015-01-05 21:02 ` Eric Botcazou
2014-12-12 0:14 ` [PATCH 4/4] Add Visium support to gcc/testsuite Eric Botcazou
2014-12-22 4:57 ` Jeff Law
2014-12-12 21:10 ` [PATCH 0/4] GCC port for the Visium Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5499C725.70409@redhat.com \
--to=law@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).