[PATCH] toplev.c: Process the failure when read fails for random_seed

[PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

When failure occurs, random_seed may not be 0, so need reset it to 0
manually, or will let the next call init_random_seed() incorrect.  The
related warning:

  g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
  ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
  ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]

It passes testsuite under x86_64-apple-darwin14.0.0

/gcc
2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>

	* toplev.c (init_local_tick): Process the failure when read
	fails for random_seed.
---
 gcc/toplev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/toplev.c b/gcc/toplev.c
index 7e06247..e5262be 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -273,7 +273,9 @@ init_local_tick (void)
       int fd = open ("/dev/urandom", O_RDONLY);
       if (fd >= 0)
         {
-          read (fd, &random_seed, sizeof (random_seed));
+          if (read (fd, &random_seed, sizeof (random_seed))
+              != sizeof (random_seed))
+            random_seed = 0;
           close (fd);
         }
 
-- 
1.9.3 (Apple Git-50)

[-- Attachment #2: 0001-toplev.c-Process-the-failure-when-read-fails-for-ran.patch --]
[-- Type: text/plain, Size: 2007 bytes --]

From 05faeede37f6e383f69a1398d355ea8ce3687583 Mon Sep 17 00:00:00 2001
From: Chen Gang <gang.chen@sunrus.com.cn>
Date: Sat, 27 Dec 2014 15:55:57 +0800
Subject: [PATCH] toplev.c: Process the failure when read fails for random_seed

When failure occurs, random_seed may not be 0, so need reset it to 0
manually, or will let the next call init_random_seed() incorrect.  The
related warning:

  g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
  ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
  ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]

It passes testsuite under x86_64-apple-darwin14.0.0

/gcc
2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>

	* toplev.c (init_local_tick): Process the failure when read
	fails for random_seed.
---
 gcc/toplev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/toplev.c b/gcc/toplev.c
index 7e06247..e5262be 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -273,7 +273,9 @@ init_local_tick (void)
       int fd = open ("/dev/urandom", O_RDONLY);
       if (fd >= 0)
         {
-          read (fd, &random_seed, sizeof (random_seed));
+          if (read (fd, &random_seed, sizeof (random_seed))
+              != sizeof (random_seed))
+            random_seed = 0;
           close (fd);
         }
 
-- 
1.9.3 (Apple Git-50)

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

Excuse me, I have to send mail use my other mail address.

During these days, gmail is broken in China, except Safari from Mac Book,
none of my email client can connect to gmail (even Safari from iPad, can
not connect gmail).

And in honest, this year what I have done is really not quite well, next
year I should be improved: should scanning Bugzilla and try to fix the
existing issues (just like another members' suggestions to me).


Thanks.

On 12/29/14 12:04, Chen Gang S wrote:
> When failure occurs, random_seed may not be 0, so need reset it to 0
> manually, or will let the next call init_random_seed() incorrect.  The
> related warning:
> 
>   g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
>   ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
>   ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
> 
> It passes testsuite under x86_64-apple-darwin14.0.0
> 
> /gcc
> 2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>
> 
> 	* toplev.c (init_local_tick): Process the failure when read
> 	fails for random_seed.
> ---
>  gcc/toplev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/toplev.c b/gcc/toplev.c
> index 7e06247..e5262be 100644
> --- a/gcc/toplev.c
> +++ b/gcc/toplev.c
> @@ -273,7 +273,9 @@ init_local_tick (void)
>        int fd = open ("/dev/urandom", O_RDONLY);
>        if (fd >= 0)
>          {
> -          read (fd, &random_seed, sizeof (random_seed));
> +          if (read (fd, &random_seed, sizeof (random_seed))
> +              != sizeof (random_seed))
> +            random_seed = 0;
>            close (fd);
>          }
>  
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Joseph Myers]

On Mon, 29 Dec 2014, Chen Gang S wrote:

> 2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>
> 
> 	* toplev.c (init_local_tick): Process the failure when read
> 	fails for random_seed.

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Joseph Myers]

On Mon, 29 Dec 2014, Chen Gang S wrote:

> And in honest, this year what I have done is really not quite well, next
> year I should be improved: should scanning Bugzilla and try to fix the
> existing issues (just like another members' suggestions to me).

Note that for any substantial patches you'll need to complete the 
copyright assignment paperwork (I don't see you listed in copyright.list 
at present).

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 12/31/14 06:26, Joseph Myers wrote:
> On Mon, 29 Dec 2014, Chen Gang S wrote:
> 
>> And in honest, this year what I have done is really not quite well, next
>> year I should be improved: should scanning Bugzilla and try to fix the
>> existing issues (just like another members' suggestions to me).
> 
> Note that for any substantial patches you'll need to complete the 
> copyright assignment paperwork (I don't see you listed in copyright.list 
> at present).
> 

OK, thanks. At present, I am just process about binutils and gdb for it.
I have printed the paper from FSF, sign my name and date, and posted it
to FSF in Dec-28-2014, (I guess, it may reach to FSF within 1 month).

After finish the working flow about binutils and gdb, I shall start the
related working flow for gcc.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Jeff Law]

On 12/28/14 21:04, Chen Gang S wrote:
> When failure occurs, random_seed may not be 0, so need reset it to 0
> manually, or will let the next call init_random_seed() incorrect.  The
> related warning:
>
>    g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
>    ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
>    ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
>
> It passes testsuite under x86_64-apple-darwin14.0.0
>
> /gcc
> 2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>
>
> 	* toplev.c (init_local_tick): Process the failure when read
> 	fails for random_seed.
This is fine for the trunk.  Please install.

jeff

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 1/6/15 04:07, Jeff Law wrote:
> On 12/28/14 21:04, Chen Gang S wrote:
>> When failure occurs, random_seed may not be 0, so need reset it to 0
>> manually, or will let the next call init_random_seed() incorrect.  The
>> related warning:
>>
>>    g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
>>    ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
>>    ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
>>
>> It passes testsuite under x86_64-apple-darwin14.0.0
>>
>> /gcc
>> 2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>
>>
>>     * toplev.c (init_local_tick): Process the failure when read
>>     fails for random_seed.
> This is fine for the trunk.  Please install.
> 

Thank you for your work.

This year, I shall try the Bugzilla for the existing issues, firstly, I
should try to continue to analyze the old issues for h8300 which I
reported in 2013 (1.5 years ago).

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 12/31/2014 06:26 AM, Joseph Myers wrote:
> On Mon, 29 Dec 2014, Chen Gang S wrote:
> 
>> And in honest, this year what I have done is really not quite well, next
>> year I should be improved: should scanning Bugzilla and try to fix the
>> existing issues (just like another members' suggestions to me).
> 
> Note that for any substantial patches you'll need to complete the 
> copyright assignment paperwork (I don't see you listed in copyright.list 
> at present).
> 

Excuse me, I am not quite familiar with the related working flow, at
present, I finished assignment paperwork for binutils and gdb, and I
am one of write after approval member for binutils and gdb.

Do you mean I need follow the same working flow for gcc, just as for the
binutils and gdb? (or only post my assignment is OK?).

If possible, please provide more related details for it. I shall follow.


Thanks.
-- 
Open, share, and attitude like air, water, and life which God blessed.

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Joseph Myers]

On Mon, 19 Jan 2015, Chen Gang S wrote:

> On 12/31/2014 06:26 AM, Joseph Myers wrote:
> > On Mon, 29 Dec 2014, Chen Gang S wrote:
> > 
> >> And in honest, this year what I have done is really not quite well, next
> >> year I should be improved: should scanning Bugzilla and try to fix the
> >> existing issues (just like another members' suggestions to me).
> > 
> > Note that for any substantial patches you'll need to complete the 
> > copyright assignment paperwork (I don't see you listed in copyright.list 
> > at present).
> > 
> 
> Excuse me, I am not quite familiar with the related working flow, at
> present, I finished assignment paperwork for binutils and gdb, and I
> am one of write after approval member for binutils and gdb.
> 
> Do you mean I need follow the same working flow for gcc, just as for the
> binutils and gdb? (or only post my assignment is OK?).

You need to complete the same assignment form.  Start with

http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

but this time name GCC as the package.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 1/20/15 10:11, Joseph Myers wrote:
> On Mon, 19 Jan 2015, Chen Gang S wrote:
> 
>> On 12/31/2014 06:26 AM, Joseph Myers wrote:
>>> On Mon, 29 Dec 2014, Chen Gang S wrote:
>>>
>>>> And in honest, this year what I have done is really not quite well, next
>>>> year I should be improved: should scanning Bugzilla and try to fix the
>>>> existing issues (just like another members' suggestions to me).
>>>
>>> Note that for any substantial patches you'll need to complete the 
>>> copyright assignment paperwork (I don't see you listed in copyright.list 
>>> at present).
>>>
>>
>> Excuse me, I am not quite familiar with the related working flow, at
>> present, I finished assignment paperwork for binutils and gdb, and I
>> am one of write after approval member for binutils and gdb.
>>
>> Do you mean I need follow the same working flow for gcc, just as for the
>> binutils and gdb? (or only post my assignment is OK?).
> 
> You need to complete the same assignment form.  Start with
> 
> http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future
> 
> but this time name GCC as the package.
> 

OK, thanks, I will follow the related working flow. And I shall try to
post my assignment paper within this month.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 1/6/15 04:07, Jeff Law wrote:
> On 12/28/14 21:04, Chen Gang S wrote:
>> When failure occurs, random_seed may not be 0, so need reset it to 0
>> manually, or will let the next call init_random_seed() incorrect.  The
>> related warning:
>>
>>    g++ -c  -DTARGET_NAME=\"parisc-gchen-linux\" -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o toplev.o -MT toplev.o -MMD -MP -MF ./.deps/toplev.TPo ../../gcc/gcc/toplev.c
>>    ../../gcc/gcc/toplev.c: In function 'void init_local_tick()':
>>    ../../gcc/gcc/toplev.c:276:56: warning: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
>>
>> It passes testsuite under x86_64-apple-darwin14.0.0
>>
>> /gcc
>> 2014-12-27  Chen Gang  <gang.chen.5i5j@gmail.com>
>>
>>     * toplev.c (init_local_tick): Process the failure when read
>>     fails for random_seed.
> This is fine for the trunk.  Please install.
> 

Excuse me, I am not familiar with the related working flow, who should
install this patch? At present, I can not find the related patch in gcc
master branch.

If I should install the patch by myself, sorry, at present, I have no
write priority. I am performing the assignment working flow for gcc, I
guess, after finish the working flow, I may have write priority.

If what I said above is incorrect, or the time is too long to bear (I
guess, may need 1 month to finish the assignment working flow), welcome
any members to help install the patch.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Mike Stump]

On Jan 21, 2015, at 1:54 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
> On 1/6/15 04:07, Jeff Law wrote:
>> 
>>>    * toplev.c (init_local_tick): Process the failure when read
>>>    fails for random_seed.
>> This is fine for the trunk.  Please install.

> I am not familiar with the related working flow, who should
> install this patch?

Anyone with write privileges can do this.  You can request installation of the patch with the magic phrase:

  I don’t have write access yet nor is my paperwork compete, can someone install this for me?

This will prompt a volunteer to step forward and help get it installed.  When they are done, they will say, installed, close any related bug report and if they are nice, tell you the commit number for the work.  You can then update your tree, build and test and ensure the work is as you wanted it.  Once it hits the trunk, you’re done.  If the patch is important enough for a back-port, you can ask people to consider a back port, once the work has been proven on the trunk for a week or two.

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 01/22/2015 02:46 AM, Mike Stump wrote:
> On Jan 21, 2015, at 1:54 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>> On 1/6/15 04:07, Jeff Law wrote:
>>>
>>>>    * toplev.c (init_local_tick): Process the failure when read
>>>>    fails for random_seed.
>>> This is fine for the trunk.  Please install.
> 
>> I am not familiar with the related working flow, who should
>> install this patch?
> 
> Anyone with write privileges can do this.  You can request installation of the patch with the magic phrase:
> 
>   I donÂ’t have write access yet nor is my paperwork compete, can someone install this for me?
> 
> This will prompt a volunteer to step forward and help get it installed.  When they are done, they will say, installed, close any related bug report and if they are nice, tell you the commit number for the work.  You can then update your tree, build and test and ensure the work is as you wanted it.  Once it hits the trunk, youÂ’re done.  If the patch is important enough for a back-port, you can ask people to consider a back port, once the work has been proven on the trunk for a week or two.
> 

OK, thanks, for me, this is only a trivial patch (not urgent). So I can
understand why it is still pending.

And if possible, could you help install this patch when you have time?
:-)


Thanks.
-- 
Open, share, and attitude like air, water, and life which God blessed.

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Jeff Law]

On 01/22/15 04:55, Chen Gang S wrote:
> On 01/22/2015 02:46 AM, Mike Stump wrote:
>> On Jan 21, 2015, at 1:54 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>> On 1/6/15 04:07, Jeff Law wrote:
>>>>
>>>>>     * toplev.c (init_local_tick): Process the failure when read
>>>>>     fails for random_seed.
>>>> This is fine for the trunk.  Please install.
>>
>>> I am not familiar with the related working flow, who should
>>> install this patch?
>>
>> Anyone with write privileges can do this.  You can request installation of the patch with the magic phrase:
>>
>>    I donÂ’t have write access yet nor is my paperwork compete, can someone install this for me?
>>
>> This will prompt a volunteer to step forward and help get it installed.  When they are done, they will say, installed, close any related bug report and if they are nice, tell you the commit number for the work.  You can then update your tree, build and test and ensure the work is as you wanted it.  Once it hits the trunk, youÂ’re done.  If the patch is important enough for a back-port, you can ask people to consider a back port, once the work has been proven on the trunk for a week or two.
>>
>
> OK, thanks, for me, this is only a trivial patch (not urgent). So I can
> understand why it is still pending.
>
> And if possible, could you help install this patch when you have time?
Installed on your behalf.

Jeff

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 01/23/2015 12:41 AM, Jeff Law wrote:
> On 01/22/15 04:55, Chen Gang S wrote:
>> On 01/22/2015 02:46 AM, Mike Stump wrote:
>>> On Jan 21, 2015, at 1:54 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>>> On 1/6/15 04:07, Jeff Law wrote:
>>>>>
>>>>>>     * toplev.c (init_local_tick): Process the failure when read
>>>>>>     fails for random_seed.
>>>>> This is fine for the trunk.  Please install.
>>>
>>>> I am not familiar with the related working flow, who should
>>>> install this patch?
>>>
>>> Anyone with write privileges can do this.  You can request installation of the patch with the magic phrase:
>>>
>>>    I donÂ’t have write access yet nor is my paperwork compete, can someone install this for me?
>>>
>>> This will prompt a volunteer to step forward and help get it installed.  When they are done, they will say, installed, close any related bug report and if they are nice, tell you the commit number for the work.  You can then update your tree, build and test and ensure the work is as you wanted it.  Once it hits the trunk, youÂ’re done.  If the patch is important enough for a back-port, you can ask people to consider a back port, once the work has been proven on the trunk for a week or two.
>>>
>>
>> OK, thanks, for me, this is only a trivial patch (not urgent). So I can
>> understand why it is still pending.
>>
>> And if possible, could you help install this patch when you have time?
> Installed on your behalf.
> 

Thank you very much for your help applying the 3 patches. :-)

After finish the assignment working flow, I guess, I may have the write
access, then can finish these kinds of trivial patches by myself (will
not always bother other members any more).


Thanks.
-- 
Open, share, and attitude like air, water, and life which God blessed.

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Jeff Law]

On 01/22/15 12:42, Chen Gang S wrote:
>
>
> Thank you very much for your help applying the 3 patches. :-)
No problem.

>
> After finish the assignment working flow, I guess, I may have the write
> access, then can finish these kinds of trivial patches by myself (will
> not always bother other members any more).
Exactly.  They'll still need review/approval, but once approved, you'll 
be able to commit them yourself.

jeff

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 01/23/2015 03:53 AM, Jeff Law wrote:
> On 01/22/15 12:42, Chen Gang S wrote:
>>
>>
>> Thank you very much for your help applying the 3 patches. :-)
> No problem.
> 
>>
>> After finish the assignment working flow, I guess, I may have the write
>> access, then can finish these kinds of trivial patches by myself (will
>> not always bother other members any more).
> Exactly.  They'll still need review/approval, but once approved, you'll be able to commit them yourself.
> 

OK, thanks. I guess that is "Write After Approval" maintainer role.

And I want to consult: for passing assignment working flow, must I make
a patch which contents much code lines? (At present, my patches are all
trivial patch).

If really need a patch which contents enough code lines, please let me
know, and I shall try.


Thanks.
-- 
Open, share, and attitude like air, water, and life which God blessed.

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Gerald Pfeifer]

On Friday 2015-01-23 04:50, Chen Gang S wrote:
> And I want to consult: for passing assignment working flow, must I 
> make a patch which contents much code lines? (At present, my patches 
> are all trivial patch).

No, the assignment process does not have any requirements on
past or current patches.  You even can complete the assignment
process without a single patch at that point.

So, do not worry.

And we are happy to see improvements and fixes of all kinds,
so please continue.

Gerald

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 1/26/15 03:50, Gerald Pfeifer wrote:
> On Friday 2015-01-23 04:50, Chen Gang S wrote:
>> And I want to consult: for passing assignment working flow, must I 
>> make a patch which contents much code lines? (At present, my patches 
>> are all trivial patch).
> 
> No, the assignment process does not have any requirements on
> past or current patches.  You even can complete the assignment
> process without a single patch at that point.
> 
> So, do not worry.
> 
> And we are happy to see improvements and fixes of all kinds,
> so please continue.
> 

Thank you very much for your encourage. :-)

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Jeff Law]

On 01/22/15 13:50, Chen Gang S wrote:
> On 01/23/2015 03:53 AM, Jeff Law wrote:
>> On 01/22/15 12:42, Chen Gang S wrote:
>>>
>>>
>>> Thank you very much for your help applying the 3 patches. :-)
>> No problem.
>>
>>>
>>> After finish the assignment working flow, I guess, I may have the write
>>> access, then can finish these kinds of trivial patches by myself (will
>>> not always bother other members any more).
>> Exactly.  They'll still need review/approval, but once approved, you'll be able to commit them yourself.
>>
>
> OK, thanks. I guess that is "Write After Approval" maintainer role.
>
> And I want to consult: for passing assignment working flow, must I make
> a patch which contents much code lines? (At present, my patches are all
> trivial patch).
>
> If really need a patch which contents enough code lines, please let me
> know, and I shall try.
You can get write-after-approval access regardless of the size and 
complexity of your patches.

Jeff

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

[Chen Gang S]

On 1/27/15 05:56, Jeff Law wrote:
> On 01/22/15 13:50, Chen Gang S wrote:
>> On 01/23/2015 03:53 AM, Jeff Law wrote:
>>> On 01/22/15 12:42, Chen Gang S wrote:
>>>>
>>>>
>>>> Thank you very much for your help applying the 3 patches. :-)
>>> No problem.
>>>
>>>>
>>>> After finish the assignment working flow, I guess, I may have the write
>>>> access, then can finish these kinds of trivial patches by myself (will
>>>> not always bother other members any more).
>>> Exactly.  They'll still need review/approval, but once approved, you'll be able to commit them yourself.
>>>
>>
>> OK, thanks. I guess that is "Write After Approval" maintainer role.
>>
>> And I want to consult: for passing assignment working flow, must I make
>> a patch which contents much code lines? (At present, my patches are all
>> trivial patch).
>>
>> If really need a patch which contents enough code lines, please let me
>> know, and I shall try.
> You can get write-after-approval access regardless of the size and complexity of your patches.
> 

OK, thanks. :-)

I sent the my related information email, and wait reply. After get reply
(get assignment pdf template), I shall post my assignment paper, it may
need almost a month  (post from China to USA may need 1 month).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed