From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24140 invoked by alias); 9 Jan 2015 16:10:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24125 invoked by uid 89); 9 Jan 2015 16:10:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Jan 2015 16:10:51 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Y9c97-0005eG-V5 from Sandra_Loosemore@mentor.com ; Fri, 09 Jan 2015 08:10:45 -0800 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Fri, 9 Jan 2015 08:10:46 -0800 Message-ID: <54AFFD7E.2070106@codesourcery.com> Date: Fri, 09 Jan 2015 16:11:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jeff Law CC: , GCC Patches Subject: Re: [doc] fix documentation of -fvtable-verify and related options References: <54AEFFEB.50503@codesourcery.com> <54AF62BE.5080701@redhat.com> In-Reply-To: <54AF62BE.5080701@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00534.txt.bz2 On 01/08/2015 10:10 PM, Jeff Law wrote: > On 01/08/15 15:08, Sandra Loosemore wrote: >> This patch cleans up the documentation of -fvtable-verify, -fvtv-debug, >> and -fvtv-counts. The substantive change is to correct the location of >> the debug log files per discussion here: >> >> https://gcc.gnu.org/ml/gcc/2015-01/msg00029.html >> >> but I ended up doing a pretty much total rewrite of the text to fix >> various markup problems, issues with agreement of verb tense and >> plurals, usage of terms like "runtime", etc. >> >> I think this particular patch goes a little beyond an obvious fix, so I >> have not committed it yet. But, I don't want it to get lost in the >> shuffle, so I propose to do so in a few days if I don't hear any >> objection or request for more time to review it meanwhile. >> >> -Sandra >> >> >> 2015-01-08 Sandra Loosemore >> >> gcc/ >> * doc/invoke.texi ([-fvtable-verify]): Copy-edit and fix markup. >> ([-fvtv-debug], [-fvtv-counts]): Likewise. Correct location >> of log files. > > This is fine. I did note that in some places you use "run time" and > others "run-time". Not sure if you want those to be consistent or not. > > Ok for the trunk. If you want to make "run time" vs "run-time" > consistent one way or the other consider it preapproved. As I noted, the "runtime" vs "run time" vs "run-time" changes are deliberate. See https://gcc.gnu.org/codingconventions.html#Spelling I did wonder, though, if "startup" should get the same treatment.... but currently "startup" is used consistently throughout the document as both noun and adjective, so any change to that ought to be handled separately. -Sandra