Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Daniel Micay]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

This branch works well for me. It doesn't automatically turn off the
linker flag when -fno-PIE or -fno-PIC are passed like most of the
wrapper scripts / downstream patches do, but that might not be a problem
in practice.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Daniel Micay]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

On 11/01/15 03:52 AM, Daniel Micay wrote:
> This branch works well for me. It doesn't automatically turn off the
> linker flag when -fno-PIE or -fno-PIC are passed like most of the
> wrapper scripts / downstream patches do, but that might not be a problem
> in practice.

Er, Thunderbird did a terrible job handling my manual reply (wasn't
subscribed to the list). Sorry about that.

For clarity, this is about H.J. Lu's branch at:

https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com> wrote:
> On 11/01/15 03:52 AM, Daniel Micay wrote:
>> This branch works well for me. It doesn't automatically turn off the
>> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>> wrapper scripts / downstream patches do, but that might not be a problem
>> in practice.

 -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with

# gcc -fPIE ....

You need to use

# gcc -pie -fPIE

To turn off PIE, you should use

# gcc -no-pie -fno-PIE

> Er, Thunderbird did a terrible job handling my manual reply (wasn't
> subscribed to the list). Sorry about that.
>
> For clarity, this is about H.J. Lu's branch at:
>
> https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
>



-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Magnus Granberg]

söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
> On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com> wrote:
> > On 11/01/15 03:52 AM, Daniel Micay wrote:
> >> This branch works well for me. It doesn't automatically turn off the
> >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
> >> wrapper scripts / downstream patches do, but that might not be a problem
> >> in practice.
> 
>  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
> 
> # gcc -fPIE ....
> 
> You need to use
> 
> # gcc -pie -fPIE
> 
> To turn off PIE, you should use
> 
> # gcc -no-pie -fno-PIE
> 
> > Er, Thunderbird did a terrible job handling my manual reply (wasn't
> > subscribed to the list). Sorry about that.
> > 
> > For clarity, this is about H.J. Lu's branch at:
> > 
> > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
It works fine for me but 6 test fails in the testsuite.
Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or -fno-pic?

FAIL: gcc.dg/tree-ssa/ssa-store-ccp-3.c scan-tree-dump-times optimized 
"conststaticvariable" 1
FAIL: gcc.target/i386/nop-mcount.c (test for excess errors)
FAIL: gcc.target/i386/pr54445-2.c scan-assembler mov(b|zbl)[ \t]
(%fs:)?tls_array@tpoff-1\\(%
FAIL: g++.dg/other/anon5.C  -std=gnu++98 (test for excess errors)
FAIL: g++.dg/other/anon5.C  -std=gnu++11 (test for excess errors)
FAIL: g++.dg/other/anon5.C  -std=gnu++14 (test for excess errors)

/Magnus

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Magnus Granberg]

söndag 11 januari 2015 14.29.56 skrev  Magnus Granberg:
> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com> 
wrote:
> > > On 11/01/15 03:52 AM, Daniel Micay wrote:
> > >> This branch works well for me. It doesn't automatically turn off the
> > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
> > >> wrapper scripts / downstream patches do, but that might not be a
> > >> problem
> > >> in practice.
> >  
> >  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
> > 
> > # gcc -fPIE ....
> > 
> > You need to use
> > 
> > # gcc -pie -fPIE
> > 
> > To turn off PIE, you should use
> > 
> > # gcc -no-pie -fno-PIE
> > 
> > > Er, Thunderbird did a terrible job handling my manual reply (wasn't
> > > subscribed to the list). Sorry about that.
> > > 
> > > For clarity, this is about H.J. Lu's branch at:
> > > 
> > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
> 
> It works fine for me but 6 test fails in the testsuite.
> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or -fno-pic?
On the crtstuff do we and --fPIE or should the Makefile handel it?
I did let the Makefile handel it.
> 
> FAIL: gcc.dg/tree-ssa/ssa-store-ccp-3.c scan-tree-dump-times optimized
> "conststaticvariable" 1
> FAIL: gcc.target/i386/nop-mcount.c (test for excess errors)
> FAIL: gcc.target/i386/pr54445-2.c scan-assembler mov(b|zbl)[ \t]
> (%fs:)?tls_array@tpoff-1\\(%
> FAIL: g++.dg/other/anon5.C  -std=gnu++98 (test for excess errors)
> FAIL: g++.dg/other/anon5.C  -std=gnu++11 (test for excess errors)
> FAIL: g++.dg/other/anon5.C  -std=gnu++14 (test for excess errors)
> 
> /Magnus

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Daniel Micay]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On 11/01/15 06:37 AM, H.J. Lu wrote:
> On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com> wrote:
>> On 11/01/15 03:52 AM, Daniel Micay wrote:
>>> This branch works well for me. It doesn't automatically turn off the
>>> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>>> wrapper scripts / downstream patches do, but that might not be a problem
>>> in practice.
> 
>  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
> 
> # gcc -fPIE ....
> 
> You need to use
> 
> # gcc -pie -fPIE
> 
> To turn off PIE, you should use
> 
> # gcc -no-pie -fno-PIE

Yeah, it's cleaner this way. Disabling the linker option when the reloc
model is known to be incompatible might be a bit too magical. I don't
expect that it avoids many compatibility issues anyway. As implemented
it's more than good enough to allow distributions to enable PIE across
the board which is all I care about :).


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Sun, Jan 11, 2015 at 5:29 AM, Magnus Granberg <zorry@gentoo.org> wrote:
> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
>> On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com> wrote:
>> > On 11/01/15 03:52 AM, Daniel Micay wrote:
>> >> This branch works well for me. It doesn't automatically turn off the
>> >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>> >> wrapper scripts / downstream patches do, but that might not be a problem
>> >> in practice.
>>
>>  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
>>
>> # gcc -fPIE ....
>>
>> You need to use
>>
>> # gcc -pie -fPIE
>>
>> To turn off PIE, you should use
>>
>> # gcc -no-pie -fno-PIE
>>
>> > Er, Thunderbird did a terrible job handling my manual reply (wasn't
>> > subscribed to the list). Sorry about that.
>> >
>> > For clarity, this is about H.J. Lu's branch at:
>> >
>> > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
> It works fine for me but 6 test fails in the testsuite.
> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or -fno-pic?
>
> FAIL: gcc.dg/tree-ssa/ssa-store-ccp-3.c scan-tree-dump-times optimized
> "conststaticvariable" 1
> FAIL: gcc.target/i386/nop-mcount.c (test for excess errors)
> FAIL: gcc.target/i386/pr54445-2.c scan-assembler mov(b|zbl)[ \t]
> (%fs:)?tls_array@tpoff-1\\(%
> FAIL: g++.dg/other/anon5.C  -std=gnu++98 (test for excess errors)
> FAIL: g++.dg/other/anon5.C  -std=gnu++11 (test for excess errors)
> FAIL: g++.dg/other/anon5.C  -std=gnu++14 (test for excess errors)

I fixed them on hjl/pie branch.  Please take a look.


-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg <zorry@gentoo.org> wrote:
> söndag 11 januari 2015 14.29.56 skrev  Magnus Granberg:
>> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
>> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com>
> wrote:
>> > > On 11/01/15 03:52 AM, Daniel Micay wrote:
>> > >> This branch works well for me. It doesn't automatically turn off the
>> > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>> > >> wrapper scripts / downstream patches do, but that might not be a
>> > >> problem
>> > >> in practice.
>> >
>> >  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
>> >
>> > # gcc -fPIE ....
>> >
>> > You need to use
>> >
>> > # gcc -pie -fPIE
>> >
>> > To turn off PIE, you should use
>> >
>> > # gcc -no-pie -fno-PIE
>> >
>> > > Er, Thunderbird did a terrible job handling my manual reply (wasn't
>> > > subscribed to the list). Sorry about that.
>> > >
>> > > For clarity, this is about H.J. Lu's branch at:
>> > >
>> > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
>>
>> It works fine for me but 6 test fails in the testsuite.
>> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or -fno-pic?
> On the crtstuff do we and --fPIE or should the Makefile handel it?
> I did let the Makefile handel it.

I will fix them shortly.


-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg <zorry@gentoo.org> wrote:
>> söndag 11 januari 2015 14.29.56 skrev  Magnus Granberg:
>>> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
>>> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com>
>> wrote:
>>> > > On 11/01/15 03:52 AM, Daniel Micay wrote:
>>> > >> This branch works well for me. It doesn't automatically turn off the
>>> > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>>> > >> wrapper scripts / downstream patches do, but that might not be a
>>> > >> problem
>>> > >> in practice.
>>> >
>>> >  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE with
>>> >
>>> > # gcc -fPIE ....
>>> >
>>> > You need to use
>>> >
>>> > # gcc -pie -fPIE
>>> >
>>> > To turn off PIE, you should use
>>> >
>>> > # gcc -no-pie -fno-PIE
>>> >
>>> > > Er, Thunderbird did a terrible job handling my manual reply (wasn't
>>> > > subscribed to the list). Sorry about that.
>>> > >
>>> > > For clarity, this is about H.J. Lu's branch at:
>>> > >
>>> > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
>>>
>>> It works fine for me but 6 test fails in the testsuite.
>>> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or -fno-pic?
>> On the crtstuff do we and --fPIE or should the Makefile handel it?
>> I did let the Makefile handel it.
>
> I will fix them shortly.
>

It is fixed now.

-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Magnus Granberg]

söndag 11 januari 2015 09.47.09 skrev  H.J. Lu:
> On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg <zorry@gentoo.org> wrote:
> >> söndag 11 januari 2015 14.29.56 skrev  Magnus Granberg:
> >>> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
> >>> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com>
> >> 
> >> wrote:
> >>> > > On 11/01/15 03:52 AM, Daniel Micay wrote:
> >>> > >> This branch works well for me. It doesn't automatically turn off
> >>> > >> the
> >>> > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
> >>> > >> wrapper scripts / downstream patches do, but that might not be a
> >>> > >> problem
> >>> > >> in practice.
> >>> >  
> >>> >  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE
> >>> >  with
> >>> > 
> >>> > # gcc -fPIE ....
> >>> > 
> >>> > You need to use
> >>> > 
> >>> > # gcc -pie -fPIE
> >>> > 
> >>> > To turn off PIE, you should use
> >>> > 
> >>> > # gcc -no-pie -fno-PIE
> >>> > 
> >>> > > Er, Thunderbird did a terrible job handling my manual reply (wasn't
> >>> > > subscribed to the list). Sorry about that.
> >>> > > 
> >>> > > For clarity, this is about H.J. Lu's branch at:
> >>> > > 
> >>> > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
> >>> 
> >>> It works fine for me but 6 test fails in the testsuite.
> >>> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or
> >>> -fno-pic?
> >> 
> >> On the crtstuff do we and --fPIE or should the Makefile handel it?
> >> I did let the Makefile handel it.
> > 
> > I will fix them shortly.
> 
> It is fixed now.

You are missing the fix in gcc/Makefile.in
echo enable_default_pie = '@enable_default_pie@' >> tmp-libgcc.mvars

/Magnus

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Sun, Jan 11, 2015 at 1:32 PM, Magnus Granberg <zorry@gentoo.org> wrote:
> söndag 11 januari 2015 09.47.09 skrev  H.J. Lu:
>> On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> > On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg <zorry@gentoo.org> wrote:
>> >> söndag 11 januari 2015 14.29.56 skrev  Magnus Granberg:
>> >>> söndag 11 januari 2015 03.37.14 skrev  H.J. Lu:
>> >>> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmicay@gmail.com>
>> >>
>> >> wrote:
>> >>> > > On 11/01/15 03:52 AM, Daniel Micay wrote:
>> >>> > >> This branch works well for me. It doesn't automatically turn off
>> >>> > >> the
>> >>> > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the
>> >>> > >> wrapper scripts / downstream patches do, but that might not be a
>> >>> > >> problem
>> >>> > >> in practice.
>> >>> >
>> >>> >  -fno-PIE and -fno-PIC aren't linking options.  We don't turn on PIE
>> >>> >  with
>> >>> >
>> >>> > # gcc -fPIE ....
>> >>> >
>> >>> > You need to use
>> >>> >
>> >>> > # gcc -pie -fPIE
>> >>> >
>> >>> > To turn off PIE, you should use
>> >>> >
>> >>> > # gcc -no-pie -fno-PIE
>> >>> >
>> >>> > > Er, Thunderbird did a terrible job handling my manual reply (wasn't
>> >>> > > subscribed to the list). Sorry about that.
>> >>> > >
>> >>> > > For clarity, this is about H.J. Lu's branch at:
>> >>> > >
>> >>> > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/pie
>> >>>
>> >>> It works fine for me but 6 test fails in the testsuite.
>> >>> Do we realy want to pass -fPIE -fPIC when someone do -fno-PIC or
>> >>> -fno-pic?
>> >>
>> >> On the crtstuff do we and --fPIE or should the Makefile handel it?
>> >> I did let the Makefile handel it.
>> >
>> > I will fix them shortly.
>>
>> It is fixed now.
>
> You are missing the fix in gcc/Makefile.in
> echo enable_default_pie = '@enable_default_pie@' >> tmp-libgcc.mvars
>

I checked in a different fix.

Thanks.

-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Fri, Jan 9, 2015 at 5:56 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jan 9, 2015 at 12:12 PM, Magnus Granberg <zorry@gentoo.org> wrote:
>> fredag 09 januari 2015 13.00.14 skrev  Daniel Micay:
>>> On 09/01/15 12:49 PM, Joseph Myers wrote:
>>> > On Fri, 9 Jan 2015, Daniel Micay wrote:
>>> >>> --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|
>>> >>> shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie}"
>>> >>>
>>> >>> at configure time (using CONFIGURE_SPECS).
>> DRIVER_SELF_SPECS is checkt before CONFIGURE_SPECS. On mips it will have added
>> -mno-shared before it check CONFIGURE_SPECS. I want to support more targets
>> later on. Can move the spec to elfos.h.
>>> >>>
>>> >>> I have no idea if the above is really the proper spec to use - why
>>> >>> do you include static, nostdlib, nodefaultlibs and nostartfiles
>>> >>> for example?  Similar, if I say
>>> >>
>>> >> PIE isn't supported for static executables by binutils, etc. so it
>>> >> does need to exclude that. The checks for nostdlib, nodefaultlibs
>>> >
>>> > Well - that would indicate excluding -pie if one of the link-time options
>>> > conflicting with it is used, -fPIE if one of the compile-time options
>>> > conflicting with it is used.  That way, "gcc -static file.c" would still
>>> > have the same effect as "gcc -c file.c; gcc -static file.o" (building a
>>> > PIE object, linking it into a non-PIE static executable), which makes
>>> > logical sense to me (although there may be no great benefit either way).
>>>
>>> Sure, I agree. It should have separate lists of exceptions for both of
>>> these.
>> I can separete it to compile and linke sections and remove the nostdlib,
>> nodefaultlibs and nostartfiles. But how do we not pass -pie to the linker when
>> we don't pass static or shared and don't link it with -pie? For only the gold
>> linker support -no-pie.
>>
>> /Magnus G.
>>
>>
>
> Please try hjl/pie branch:
>
> https://gcc.gnu.org/git/?p=gcc.git;a=summary
>
> and let know if it works for you.
>

I updated the branch with some fixes.

-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[H.J. Lu]

On Fri, Jan 9, 2015 at 12:12 PM, Magnus Granberg <zorry@gentoo.org> wrote:
> fredag 09 januari 2015 13.00.14 skrev  Daniel Micay:
>> On 09/01/15 12:49 PM, Joseph Myers wrote:
>> > On Fri, 9 Jan 2015, Daniel Micay wrote:
>> >>> --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|
>> >>> shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie}"
>> >>>
>> >>> at configure time (using CONFIGURE_SPECS).
> DRIVER_SELF_SPECS is checkt before CONFIGURE_SPECS. On mips it will have added
> -mno-shared before it check CONFIGURE_SPECS. I want to support more targets
> later on. Can move the spec to elfos.h.
>> >>>
>> >>> I have no idea if the above is really the proper spec to use - why
>> >>> do you include static, nostdlib, nodefaultlibs and nostartfiles
>> >>> for example?  Similar, if I say
>> >>
>> >> PIE isn't supported for static executables by binutils, etc. so it
>> >> does need to exclude that. The checks for nostdlib, nodefaultlibs
>> >
>> > Well - that would indicate excluding -pie if one of the link-time options
>> > conflicting with it is used, -fPIE if one of the compile-time options
>> > conflicting with it is used.  That way, "gcc -static file.c" would still
>> > have the same effect as "gcc -c file.c; gcc -static file.o" (building a
>> > PIE object, linking it into a non-PIE static executable), which makes
>> > logical sense to me (although there may be no great benefit either way).
>>
>> Sure, I agree. It should have separate lists of exceptions for both of
>> these.
> I can separete it to compile and linke sections and remove the nostdlib,
> nodefaultlibs and nostartfiles. But how do we not pass -pie to the linker when
> we don't pass static or shared and don't link it with -pie? For only the gold
> linker support -no-pie.
>
> /Magnus G.
>
>

Please try hjl/pie branch:

https://gcc.gnu.org/git/?p=gcc.git;a=summary

and let know if it works for you.


-- 
H.J.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Magnus Granberg]

fredag 09 januari 2015 13.00.14 skrev  Daniel Micay:
> On 09/01/15 12:49 PM, Joseph Myers wrote:
> > On Fri, 9 Jan 2015, Daniel Micay wrote:
> >>> --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|
> >>> shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie}"
> >>> 
> >>> at configure time (using CONFIGURE_SPECS).
DRIVER_SELF_SPECS is checkt before CONFIGURE_SPECS. On mips it will have added 
-mno-shared before it check CONFIGURE_SPECS. I want to support more targets 
later on. Can move the spec to elfos.h.
> >>> 
> >>> I have no idea if the above is really the proper spec to use - why
> >>> do you include static, nostdlib, nodefaultlibs and nostartfiles
> >>> for example?  Similar, if I say
> >> 
> >> PIE isn't supported for static executables by binutils, etc. so it
> >> does need to exclude that. The checks for nostdlib, nodefaultlibs
> > 
> > Well - that would indicate excluding -pie if one of the link-time options
> > conflicting with it is used, -fPIE if one of the compile-time options
> > conflicting with it is used.  That way, "gcc -static file.c" would still
> > have the same effect as "gcc -c file.c; gcc -static file.o" (building a
> > PIE object, linking it into a non-PIE static executable), which makes
> > logical sense to me (although there may be no great benefit either way).
> 
> Sure, I agree. It should have separate lists of exceptions for both of
> these.
I can separete it to compile and linke sections and remove the nostdlib, 
nodefaultlibs and nostartfiles. But how do we not pass -pie to the linker when
we don't pass static or shared and don't link it with -pie? For only the gold 
linker support -no-pie.

/Magnus G.

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Daniel Micay]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On 09/01/15 12:49 PM, Joseph Myers wrote:
> On Fri, 9 Jan 2015, Daniel Micay wrote:
> 
>>> --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE
>>> -pie}"
>>>
>>> at configure time (using CONFIGURE_SPECS).
>>>
>>> I have no idea if the above is really the proper spec to use - why
>>> do you include static, nostdlib, nodefaultlibs and nostartfiles
>>> for example?  Similar, if I say
>>
>> PIE isn't supported for static executables by binutils, etc. so it
>> does need to exclude that. The checks for nostdlib, nodefaultlibs
> 
> Well - that would indicate excluding -pie if one of the link-time options 
> conflicting with it is used, -fPIE if one of the compile-time options 
> conflicting with it is used.  That way, "gcc -static file.c" would still 
> have the same effect as "gcc -c file.c; gcc -static file.o" (building a 
> PIE object, linking it into a non-PIE static executable), which makes 
> logical sense to me (although there may be no great benefit either way).

Sure, I agree. It should have separate lists of exceptions for both of
these.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Joseph Myers]

On Fri, 9 Jan 2015, Daniel Micay wrote:

> > --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE
> > -pie}"
> > 
> > at configure time (using CONFIGURE_SPECS).
> > 
> > I have no idea if the above is really the proper spec to use - why
> > do you include static, nostdlib, nodefaultlibs and nostartfiles
> > for example?  Similar, if I say
> 
> PIE isn't supported for static executables by binutils, etc. so it
> does need to exclude that. The checks for nostdlib, nodefaultlibs

Well - that would indicate excluding -pie if one of the link-time options 
conflicting with it is used, -fPIE if one of the compile-time options 
conflicting with it is used.  That way, "gcc -static file.c" would still 
have the same effect as "gcc -c file.c; gcc -static file.o" (building a 
PIE object, linking it into a non-PIE static executable), which makes 
logical sense to me (although there may be no great benefit either way).

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Daniel Micay]

[-- Attachment #1: Type: text/plain, Size: 2401 bytes --]

On 09/01/15 07:58 AM, Richard Biener wrote:
> 
> Looking at the actual implementation I wonder why it's not similar
> to how darwin gets at it default (not sure how it does).  Also
> looking at how DRIVER_SELF_SPECS is used I wonder if the
> functionality can be enabled with a simple
> 
> --with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE
> -pie}"
> 
> at configure time (using CONFIGURE_SPECS).
> 
> I have no idea if the above is really the proper spec to use - why
> do you include static, nostdlib, nodefaultlibs and nostartfiles
> for example?  Similar, if I say

PIE isn't supported for static executables by binutils, etc. so it
does need to exclude that. The checks for nostdlib, nodefaultlibs
and nostartfiles do seem unnecessary. I think distributions include
those in the existing wrapper scripts and GCC patches because it
avoids the need for patching build systems for kernel / freestanding
code to include -fno-pie, but it's more correct to leave these out.
 
>  gcc -pie -c t.c
> 
> we will end up with a non-PIE object, and linking with -fPIE will
> end up with a DYN_EXEC object.
> 
> I believe you want to treat link and compile arguments separately
> (and adjust the link spec for linking).  I also would have said that
> elfos.h is more appropriate than gnu-user.h, but ...

Handling it separately is what the existing wrapper scripts for this do:

    -fno-PIC|-fno-pic|-fno-PIE|-fno-pie|-static|--static|-shared|--shared)
      force_fPIE=0
      force_pie=0
      ;;
    -fPIC|-fpic|-fPIE|-fpie)
      force_fPIE=0
      ;;
    -c|-E|-S)
      force_pie=0
      ;;

I think it's appropriate for it to 
 
> That said, the patch looks more like a hack (and see above how
> to achieve the same without a patch(?)), not like a proper implementation
> of a PIE default.

I don't think it can be considered a hack if it's handling all of the cases
correctly, so it might need some changes from the current implementation but
that doesn't make it a dead end. Is it actually done in a significantly
different way for OS X?

If it can be done by passing --with-specs to configure then that could be a
viable alternative for distributions that do not want to add GCC patches or
use wrapper scripts (Arch Linux) but I'm not sure that it will fly.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Richard Biener]

On Tue, Dec 30, 2014 at 10:23 PM, Magnus Granberg <zorry@gentoo.org> wrote:
> fredag 14 november 2014 23.31.48 skrev  Magnus Granberg:
>> måndag 10 november 2014 21.26.39 skrev  Magnus Granberg:
>> > >   Rainer
>> >
>> > Thanks Rainer for the nits and comments.
>> > Have updated the patches and Changelogs.
>> > But i still use PIE_DRIVER_SELF_SPECS, do you have a ide where move it so
>> > i don't need to duplicate that stuff or how to do it?
>> >
>> > Magnus G
>> >
>> > 2014-11-10  Magnus Granberg  <zorry@gentoo.org>
>> >
>> >     /gcc
>> >     * config/gnu-user.h (PIE_DRIVER_SELF_SPECS) and
>> >     (GNU_DRIVER_SELF_SPECS): Define.
>> >     * config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define
>> >     * configure.ac: Add new option.
>> >     * configure, config.in: Rebuild.
>> >     * Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
>> >     * doc/install.texi: New configure option.
>> >     * doc/invoke.texi: Add note to PIE.
>> >     * doc/sourcebuild.texi: New effective target.
>> >     gcc/testsuite
>> >     * gcc/default-pie.c: New test
>> >     * gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
>> >     * g++.dg/other/anon5.C: Skip if default_pie
>> >     * lib/target-supports.exp (check_effective_target_default_pie):
>> >     New proc.
>> >     /libgcc
>> >     * Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.
>>
>> Can this be included for GCC 5 ?
>>
>> /Magnus G.
> One more ping on this. The patches where sent before stage 1 closed but i
> did't get any feed back from it
> Have updete the patchses for gcc 5.0 20141228 snapshot.
> Bootstrapped and tested on x86_64-unknown-linux-gnu (Gentoo)
> /Magnus

Looking at the actual implementation I wonder why it's not similar
to how darwin gets at it default (not sure how it does).  Also
looking at how DRIVER_SELF_SPECS is used I wonder if the
functionality can be enabled with a simple

--with-specs="%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE|shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE
-pie}"

at configure time (using CONFIGURE_SPECS).

I have no idea if the above is really the proper spec to use - why
do you include static, nostdlib, nodefaultlibs and nostartfiles
for example?  Similar, if I say

 gcc -pie -c t.c

we will end up with a non-PIE object, and linking with -fPIE will
end up with a DYN_EXEC object.

I believe you want to treat link and compile arguments separately
(and adjust the link spec for linking).  I also would have said that
elfos.h is more appropriate than gnu-user.h, but ...

That said, the patch looks more like a hack (and see above how
to achieve the same without a patch(?)), not like a proper implementation
of a PIE default.

Joseph may have an idea where the proper place for a spec-wise
default PIE is.

Thanks,
Richard.

> 2014-12-30  Magnus Granberg  <zorry@gentoo.org>
>
> /gcc
>         * config/gnu-user.h (PIE_DRIVER_SELF_SPECS): Define.
>         * config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define and
>         add PIE_DRIVER_SELF_SPECS.
>         * configure.ac: Add new option.
>         * configure, config.in: Rebuild.
>         * Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
>         * doc/install.texi: New configure option.
>         * doc/invoke.texi: Add note to PIE.
>         * doc/sourcebuild.texi: New effective target.
> gcc/testsuite
>         * gcc/default-pie.c: New test
>         * gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
>         * g++.dg/other/anon5.C: Skip if default_pie
>         * lib/target-supports.exp (check_effective_target_default_pie):
>         New proc.
> /libgcc
>         * Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.
>

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Allan McRae]

On 31/12/14 07:23, Magnus Granberg wrote:
> fredag 14 november 2014 23.31.48 skrev  Magnus Granberg:
>> måndag 10 november 2014 21.26.39 skrev  Magnus Granberg:
>>>> 	Rainer
>>>
>>> Thanks Rainer for the nits and comments.
>>> Have updated the patches and Changelogs.
>>> But i still use PIE_DRIVER_SELF_SPECS, do you have a ide where move it so
>>> i don't need to duplicate that stuff or how to do it?
>>>
>>> Magnus G
>>>
>>> 2014-11-10  Magnus Granberg  <zorry@gentoo.org>
>>>
>>> 	/gcc
>>> 	* config/gnu-user.h (PIE_DRIVER_SELF_SPECS) and
>>> 	(GNU_DRIVER_SELF_SPECS): Define.
>>> 	* config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define
>>> 	* configure.ac: Add new option.
>>> 	* configure, config.in: Rebuild.
>>> 	* Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
>>> 	* doc/install.texi: New configure option.
>>> 	* doc/invoke.texi: Add note to PIE.
>>> 	* doc/sourcebuild.texi: New effective target.
>>> 	gcc/testsuite
>>> 	* gcc/default-pie.c: New test
>>> 	* gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
>>> 	* g++.dg/other/anon5.C: Skip if default_pie
>>> 	* lib/target-supports.exp (check_effective_target_default_pie):
>>> 	New proc.
>>> 	/libgcc
>>> 	* Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.
>>
>> Can this be included for GCC 5 ?
>>
>> /Magnus G.
> One more ping on this. The patches where sent before stage 1 closed but i 
> did't get any feed back from it
> Have updete the patchses for gcc 5.0 20141228 snapshot.
> Bootstrapped and tested on x86_64-unknown-linux-gnu (Gentoo)
> /Magnus
> 

I'm giving this a further ping as my distribution has interest in these
patches.

Thanks!


> 2014-12-30  Magnus Granberg  <zorry@gentoo.org>
> 
> /gcc
> 	* config/gnu-user.h (PIE_DRIVER_SELF_SPECS): Define.
> 	* config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define and
> 	add PIE_DRIVER_SELF_SPECS.
> 	* configure.ac: Add new option.
> 	* configure, config.in: Rebuild.
> 	* Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
> 	* doc/install.texi: New configure option.
> 	* doc/invoke.texi: Add note to PIE.
> 	* doc/sourcebuild.texi: New effective target.
> gcc/testsuite
> 	* gcc/default-pie.c: New test
> 	* gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
> 	* g++.dg/other/anon5.C: Skip if default_pie
> 	* lib/target-supports.exp (check_effective_target_default_pie):
> 	New proc.
> /libgcc
> 	* Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.
> 

[PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

[Magnus Granberg]

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

fredag 14 november 2014 23.31.48 skrev  Magnus Granberg:
> måndag 10 november 2014 21.26.39 skrev  Magnus Granberg:
> > > 	Rainer
> > 
> > Thanks Rainer for the nits and comments.
> > Have updated the patches and Changelogs.
> > But i still use PIE_DRIVER_SELF_SPECS, do you have a ide where move it so
> > i don't need to duplicate that stuff or how to do it?
> > 
> > Magnus G
> > 
> > 2014-11-10  Magnus Granberg  <zorry@gentoo.org>
> > 
> > 	/gcc
> > 	* config/gnu-user.h (PIE_DRIVER_SELF_SPECS) and
> > 	(GNU_DRIVER_SELF_SPECS): Define.
> > 	* config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define
> > 	* configure.ac: Add new option.
> > 	* configure, config.in: Rebuild.
> > 	* Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
> > 	* doc/install.texi: New configure option.
> > 	* doc/invoke.texi: Add note to PIE.
> > 	* doc/sourcebuild.texi: New effective target.
> > 	gcc/testsuite
> > 	* gcc/default-pie.c: New test
> > 	* gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
> > 	* g++.dg/other/anon5.C: Skip if default_pie
> > 	* lib/target-supports.exp (check_effective_target_default_pie):
> > 	New proc.
> > 	/libgcc
> > 	* Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.
> 
> Can this be included for GCC 5 ?
> 
> /Magnus G.
One more ping on this. The patches where sent before stage 1 closed but i 
did't get any feed back from it
Have updete the patchses for gcc 5.0 20141228 snapshot.
Bootstrapped and tested on x86_64-unknown-linux-gnu (Gentoo)
/Magnus

2014-12-30  Magnus Granberg  <zorry@gentoo.org>

/gcc
	* config/gnu-user.h (PIE_DRIVER_SELF_SPECS): Define.
	* config/i386/gnu-user-common.h (DRIVER_SELF_SPECS): Define and
	add PIE_DRIVER_SELF_SPECS.
	* configure.ac: Add new option.
	* configure, config.in: Rebuild.
	* Makefile.in (ALL_CFLAGS) and (ALL_CXXFLAGS): Disable PIE.
	* doc/install.texi: New configure option.
	* doc/invoke.texi: Add note to PIE.
	* doc/sourcebuild.texi: New effective target.
gcc/testsuite
	* gcc/default-pie.c: New test
	* gcc.dg/tree-ssa/ssa-store-ccp-3.c: Skip if default_pie
	* g++.dg/other/anon5.C: Skip if default_pie
	* lib/target-supports.exp (check_effective_target_default_pie):
	New proc.
/libgcc
	* Makefile.in (CRTSTUFF_CFLAGS): Disable PIE.


[-- Attachment #2: gcc50_default_pie_doc.patch --]
[-- Type: text/x-patch, Size: 2479 bytes --]

--- a/gcc/doc/install.texi	2013-10-01 19:29:40.000000000 +0200
+++ b/gcc/doc/install.texi	2013-11-17 16:13:20.474144921 +0100
@@ -1583,6 +1583,10 @@ do a @samp{make -C gcc gnatlib_and_tools
 Specify that the run-time libraries for stack smashing protection
 should not be built.
 
+@item --enable-default-pie
+Turn on @option{-fPIE} and @option{-pie} by default if supported.
+Currently supported targets are i?86-*-linux* and x86-64-*-linux*.
+
 @item --disable-libquadmath
 Specify that the GCC quad-precision math library should not be built.
 On some systems, the library is required to be linkable when building
--- a/gcc/doc/invoke.texi	2013-10-03 19:13:50.000000000 +0200
+++ b/gcc/doc/invoke.texi	2013-11-17 21:30:02.784220111 +0100
@@ -10898,6 +10898,13 @@ For predictable results, you must also s
 used for compilation (@option{-fpie}, @option{-fPIE},
 or model suboptions) when you specify this linker option.
 
+@emph{Note}: With the @option{--enable-default-pie} configure option, this
+options is enabled by default for C, C++, ObjC, ObjC++, if none of
+@option{-fno-PIE}, @option{-fno-pie}, @option{-fPIC}, @option{-fpic},
+@option{-fno-PIC}, @option{-fno-pic}, @option{-nostdlib},
+@option{-nostartfiles}, @option{-shared}, @option{-nodefaultlibs},
+nor @option{-static} are found.
+
 @item -rdynamic
 @opindex rdynamic
 Pass the flag @option{-export-dynamic} to the ELF linker, on targets
@@ -23071,6 +23071,13 @@ used during linking.
 @code{__pie__} and @code{__PIE__}.  The macros have the value 1
 for @option{-fpie} and 2 for @option{-fPIE}.
 
+@emph{Note}: With the @option{--enable-default-pie} configure option, this
+options is enabled by default for C, C++, ObjC, ObjC++, if none of
+@option{-fno-PIE}, @option{-fno-pie}, @option{-fPIC}, @option{-fpic},
+@option{-fno-PIC}, @option{-fno-pic}, @option{-nostdlib},
+@option{-nostartfiles}, @option{-shared}, @option{-nodefaultlibs},
+nor @option{-static} are found.
+
 @item -fno-jump-tables
 @opindex fno-jump-tables
 Do not use jump tables for switch statements even where it would be
--- a/gcc/doc/sourcebuild.texi	2014-08-20 17:56:45.000000000 +0200
+++ b/gcc/doc/sourcebuild.texi	2014-11-09 23:43:06.254817553 +0100
@@ -1890,6 +1890,9 @@ Target supports @option{-mpe-aligned-com
 @item pie
 Target supports @option{-pie}, @option{-fpie} and @option{-fPIE}.
 
+@item default_pie
+Target enable @option{-pie}, and @option{-fPIE} as default.
+
 @item section_anchors
 Target supports section anchors.
 

[-- Attachment #3: gcc50_default_pie_main.patch --]
[-- Type: text/x-patch, Size: 5352 bytes --]

--- a/gcc/config/gnu-user.h	2013-08-20 10:31:40.000000000 +0200
+++ b/gcc/config/gnu-user.h	2013-10-23 22:01:42.337238981 +0200
@@ -131,3 +131,13 @@ see the files COPYING3 and COPYING.RUNTI
   LD_STATIC_OPTION " --whole-archive -llsan --no-whole-archive " \
   LD_DYNAMIC_OPTION "}}%{!static-liblsan:-llsan}"
 #endif
+
+/* We use this to make the compiler use -fPIE as default and link
+   with -pie.  */
+#ifdef ENABLE_DEFAULT_PIE
+#define PIE_DRIVER_SELF_SPECS \
+"%{pie|fpic|fPIC|fpie|fPIE|fno-pic|fno-PIC|fno-pie|fno-PIE| \
+  shared|static|nostdlib|nodefaultlibs|nostartfiles:;:-fPIE -pie}"
+#else
+#define PIE_DRIVER_SELF_SPECS ""
+#endif
--- a/gcc/config/i386/gnu-user-common.h	2013-01-10 21:38:27.000000000 +0100
+++ b/gcc/config/i386/gnu-user-common.h	2013-10-23 17:37:45.432767049 +0200
@@ -70,3 +70,8 @@ along with GCC; see the file COPYING3.
 #if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE
 #define TARGET_CAN_SPLIT_STACK
 #endif
+
+/* include PIE_DRIVER_SELF_SPECS.  */
+#ifndef DRIVER_SELF_SPECS
+#define DRIVER_SELF_SPECS PIE_DRIVER_SELF_SPECS
+#endif
--- a/gcc/configure.ac	2014-04-28 16:01:40.000000000 +0200
+++ b/gcc/configure.ac	2014-05-08 02:42:30.900883247 +0200
@@ -5754,6 +5754,36 @@ if test x"${LINKER_HASH_STYLE}" != x; th
 #define GCC_DRIVER_NAME "${target_noncanonical}-gcc-${gcc_BASEVER}${exeext}"
 EOF
 
+# Check whether --enable-default-pie was given and target have the support.
+AC_ARG_ENABLE(default-pie,
+[AS_HELP_STRING([--enable-default-pie],
+  [enable Position Independent Executable as default])],
+enable_default_pie=$enableval,
+enable_default_pie=no)
+if test x$enable_default_pie = xyes; then
+  AC_MSG_CHECKING(if $target supports default PIE)
+  enable_default_pie=no
+  case $target in
+    i?86*-*-linux* | x86_64*-*-linux*)
+      saved_LDFLAGS="$LDFLAGS"
+      saved_CFLAGS="$CFLAGS"
+      CFLAGS="$CFLAGS -fPIE"
+      LDFLAGS="$LDFLAGS -fPIE -pie"
+      AC_TRY_LINK(,,[enable_default_pie=yes],)
+      LDFLAGS="$saved_LDFLAGS"
+      CFLAGS="$saved_CFLAGS"
+      ;;
+    *)
+      ;;
+    esac
+  AC_MSG_RESULT($enable_default_pie)
+fi
+if test x$enable_default_pie == xyes ; then
+  AC_DEFINE(ENABLE_DEFAULT_PIE, 1,
+      [Define if your target supports default PIE and it is enabled.])
+fi
+AC_SUBST([enable_default_pie])
+
 # Configure the subdirectories
 # AC_CONFIG_SUBDIRS($subdirs)
 
--- a/gcc/Makefile.in	2013-10-02 21:52:27.000000000 +0200
+++ b/gcc/Makefile.in	2013-10-24 17:46:22.055357122 +0200
@@ -963,14 +963,23 @@ CONTEXT_H = context.h
 # cross compiler which does not use the native headers and libraries.
 INTERNAL_CFLAGS = -DIN_GCC $(PICFLAG) @CROSS@
 
+# We don't want to compile the compiler with -fPIE, it make PCH fail.
+enable_default_pie = @enable_default_pie@
+ifeq ($(enable_default_pie),yes)
+NOPIE_CFLAGS = -fno-PIE
+else
+NOPIE_CFLAGS=
+endif
+
 # This is the variable actually used when we compile. If you change this,
 # you probably want to update BUILD_CFLAGS in configure.ac
-ALL_CFLAGS = $(T_CFLAGS) $(CFLAGS-$@) \
+ALL_CFLAGS = $(NOPIE_CFLAGS) $(T_CFLAGS) $(CFLAGS-$@) \
   $(CFLAGS) $(INTERNAL_CFLAGS) $(COVERAGE_FLAGS) $(WARN_CFLAGS) @DEFS@
 
 # The C++ version.
-ALL_CXXFLAGS = $(T_CFLAGS) $(CFLAGS-$@) $(CXXFLAGS) $(INTERNAL_CFLAGS) \
-  $(COVERAGE_FLAGS) $(NOEXCEPTION_FLAGS) $(WARN_CXXFLAGS) @DEFS@
+ALL_CXXFLAGS = $(NOPIE_CFLAGS) $(T_CFLAGS) $(CFLAGS-$@) $(CXXFLAGS) \
+  $(INTERNAL_CFLAGS) $(COVERAGE_FLAGS) $(NOEXCEPTION_FLAGS) \
+  $(WARN_CXXFLAGS) @DEFS@
 
 # Likewise.  Put INCLUDES at the beginning: this way, if some autoconf macro
 # puts -I options in CPPFLAGS, our include files in the srcdir will always
@@ -1854,6 +1854,7 @@ libgcc.mvars: config.status Makefile spe
 	echo GCC_CFLAGS = '$(GCC_CFLAGS)' >> tmp-libgcc.mvars
 	echo INHIBIT_LIBC_CFLAGS = '$(INHIBIT_LIBC_CFLAGS)' >> tmp-libgcc.mvars
 	echo TARGET_SYSTEM_ROOT = '$(TARGET_SYSTEM_ROOT)' >> tmp-libgcc.mvars
+	echo enable_default_pie = '$(enable_default_pie)' >> tmp-libgcc.mvars
 
 	mv tmp-libgcc.mvars libgcc.mvars
 
@@ -3609,6 +3609,9 @@ site.exp: ./config.status Makefile
 	@if test "@enable_lto@" = "yes" ; then \
 	  echo "set ENABLE_LTO 1" >> ./site.tmp; \
 	fi
+	@if test "@enable_default_pie@" = "yes" ; then \
+	  echo "set ENABLE_DEFAULT_PIE 1" >> ./site.tmp; \
+	fi
 # If newlib has been configured, we need to pass -B to gcc so it can find
 # newlib's crt0.o if it exists.  This will cause a "path prefix not used"
 # message if it doesn't, but the testsuite is supposed to ignore the message -
--- a/libgcc/Makefile.in	2014-10-30 18:28:30.000000000 +0100
+++ b/libgcc/Makefile.in	2014-11-08 20:37:04.462496763 +0100
@@ -282,11 +282,19 @@ override CFLAGS := $(filter-out -fprofil
 INTERNAL_CFLAGS = $(CFLAGS) $(LIBGCC2_CFLAGS) $(HOST_LIBGCC2_CFLAGS) \
 		  $(INCLUDES) @set_have_cc_tls@ @set_use_emutls@
 
+#Don't use -fPIE when compiling crtbegin/end.
+ifeq ($(enable_default_pie),yes)
+NOPIE_CFLAGS = -fno-PIE
+else
+NOPIE_CFLAGS=
+endif
+
 # Options to use when compiling crtbegin/end.
 CRTSTUFF_CFLAGS = -O2 $(GCC_CFLAGS) $(INCLUDES) $(MULTILIB_CFLAGS) -g0 \
   -finhibit-size-directive -fno-inline -fno-exceptions \
   -fno-zero-initialized-in-bss -fno-toplevel-reorder -fno-tree-vectorize \
   -fbuilding-libgcc -fno-stack-protector $(FORCE_EXPLICIT_EH_REGISTRY) \
+  $(NOPIE_CFLAGS) \
   $(INHIBIT_LIBC_CFLAGS)
 
 # Extra flags to use when compiling crt{begin,end}.o.

[-- Attachment #4: gcc50_default_pie_testsuite.patch --]
[-- Type: text/x-patch, Size: 2361 bytes --]

--- a/gcc/testsuite/gcc.dg/default-pie.c	2013-11-09 21:07:16.741479728 +0100
+++ b/gcc/testsuite/gcc.dg/default-pie.c	2013-11-09 21:05:07.801479218 +0100
@@ -0,0 +1,11 @@
+/* { dg-require-effective-target default_pie } */
+/* { dg-options "-O2" } */
+int foo (void);
+
+int
+main (void)
+{
+	return foo ();
+}
+
+/* { dg-final { scan-assembler "foo@PLT" } } */
--- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-store-ccp-3.c	2012-03-14 17:33:37.000000000 +0100
+++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-store-ccp-3.c	2014-07-29 00:55:17.421086416 +0200
@@ -2,6 +2,7 @@
 /* Skipped on MIPS GNU/Linux target because __PIC__ can be
    defined for executables as well as shared libraries.  */
 /* { dg-skip-if "" { *-*-darwin* hppa*64*-*-* mips*-*-linux* *-*-mingw* } { "*" } { "" } } */
+/* { dg-skip-if "" { default_pie } { "*" } { "" } }  */
 /* { dg-options "-O2 -fno-common -fdump-tree-optimized" } */
 
 const int conststaticvariable;
--- a/gcc/testsuite/g++.dg/other/anon5.C	2012-11-10 15:34:42.000000000 +0100
+++ b/gcc/testsuite/g++.dg/other/anon5.C	2013-11-09 14:49:52.281390127 +0100
@@ -1,5 +1,6 @@
 // PR c++/34094
 // { dg-do link { target { ! { *-*-darwin* *-*-hpux* *-*-solaris2.* } } } }
+// { dg-skip-if "" { default_pie } { "*" } { "" } }
 // { dg-options "-g" }
 // Ignore additional message on powerpc-ibm-aix
 // { dg-prune-output "obtain more information" } */
--- a/gcc/testsuite/lib/target-supports.exp	2013-10-01 11:18:30.000000000 +0200
+++ b/gcc/testsuite/lib/target-supports.exp	2013-10-25 22:01:46.743388469 +0200
@@ -475,6 +475,11 @@ proc check_profiling_available { test_wh
 	}
     }
 
+    # Profiling doesn't work with default -fPIE -pie.
+    if { [check_effective_target_default_pie] } {
+      return 0
+    }
+
     # Support for -p on solaris2 relies on mcrt1.o which comes with the
     # vendor compiler.  We cannot reliably predict the directory where the
     # vendor compiler (and thus mcrt1.o) is installed so we can't
@@ -927,6 +927,14 @@ proc check_effective_target_pie { } {
     return 0
 }
 
+# Return 1 if -pie, -fPIE are enable by default, 0 otherwise.
+
+proc check_effective_target_default_pie { } {
+    global ENABLE_DEFAULT_PIE
+    return [info exists ENABLE_DEFAULT_PIE]
+    return 0
+}
+
 # Return true if the target supports -mpaired-single (as used on MIPS).
 
 proc check_effective_target_mpaired_single { } {