From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix REE for vector modes (PR rtl-optimization/64286)
Date: Mon, 12 Jan 2015 21:39:00 -0000 [thread overview]
Message-ID: <54B43CD1.1040100@redhat.com> (raw)
In-Reply-To: <20150112195943.GN1405@tucnak.redhat.com>
On 01/12/15 12:59, Jakub Jelinek wrote:
> Hi!
>
> As mentioned in the PR, giving up for all vector mode extensions
> is unnecessary, but unlike scalar integer extensions, where the low part
> of the extended value is the original value, for vectors this is not true,
> thus the old value is lost. Which means we can perform REE, but only if
> all uses of the definition are the same (code+mode) extension.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2015-01-12 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/64286
> * ree.c (add_removable_extension): Don't add vector mode
> extensions if all uses of the source register aren't the same
> vector extensions.
>
> * gcc.target/i386/avx2-pr64286.c: New test.
Does it make sense to remove your change for 59754 in
combine_reaching_defs? Shouldn't this patch handle that case as well?
jeff
next prev parent reply other threads:[~2015-01-12 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 20:02 Jakub Jelinek
2015-01-12 21:39 ` Jeff Law [this message]
2015-01-13 16:22 ` [PATCH] Fix REE for vector modes (PR rtl-optimization/64286, take 2) Jakub Jelinek
2015-01-13 19:24 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B43CD1.1040100@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).