From: Jeff Law <law@redhat.com>
To: "Zamyatin, Igor" <igor.zamyatin@intel.com>,
"GCC Patches (gcc-patches@gcc.gnu.org)"
<gcc-patches@gcc.gnu.org>
Cc: "ysrumyan@gmail.com" <ysrumyan@gmail.com>
Subject: Re: [PATCH] Fix for PR64081 in RTL loop unroller
Date: Tue, 13 Jan 2015 19:06:00 -0000 [thread overview]
Message-ID: <54B56C44.8090707@redhat.com> (raw)
In-Reply-To: <0EFAB2BDD0F67E4FB6CCC8B9F87D756969D345EB@IRSMSX101.ger.corp.intel.com>
On 01/13/15 11:01, Zamyatin, Igor wrote:
>>
>> Is it really sufficient here to verify that all the defs are on latch predecessors,
>> what about the case where there is a predecessor without a def. How do
>> you guarantee domination in that case?
>>
>> ISTM that given the structure for the code you're writing that you'd want to
>> verify that in the event of multiple definitions that all of them appear on
>> immediate predecessors of the latch *and* that each immediate
>> predecessor has a definition.
>
> Yes, do you think it's better to check exactly immediate predecessors?
I'd use the same structure that you have in iv_get_reaching_def. If
there was a reasonable way to factor that test into a single function
and call it from both places that would be even better.
Jeff
next prev parent reply other threads:[~2015-01-13 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 10:24 Zamyatin, Igor
2015-01-09 6:09 ` Jeff Law
[not found] ` <CAEoMCqTzzMz-qO5x1q=5Htjxe1Von02iB_BpW7umXyQy_nVxtw@mail.gmail.com>
[not found] ` <CAKdSQZnrxfXcUMXwNW=c0PPaFgFe6rUKhkW+2T1U8BKop8K8=A@mail.gmail.com>
2015-01-13 18:38 ` Zamyatin, Igor
2015-01-13 19:06 ` Jeff Law [this message]
2015-01-15 16:55 ` Zamyatin, Igor
2015-01-15 17:11 ` Jeff Law
2015-01-16 15:34 ` Zamyatin, Igor
2015-01-16 16:54 ` Jeff Law
2015-01-19 22:38 David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B56C44.8090707@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=igor.zamyatin@intel.com \
--cc=ysrumyan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).