From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4914 invoked by alias); 13 Jan 2015 19:10:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4905 invoked by uid 89); 13 Jan 2015 19:10:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 13 Jan 2015 19:10:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0DJA4L3006503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 13 Jan 2015 14:10:05 -0500 Received: from [10.3.113.77] (ovpn-113-77.phx2.redhat.com [10.3.113.77]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0DJA3Pv003103; Tue, 13 Jan 2015 14:10:04 -0500 Message-ID: <54B56D8B.3050609@redhat.com> Date: Tue, 13 Jan 2015 19:24:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix REE for vector modes (PR rtl-optimization/64286, take 2) References: <20150112195943.GN1405@tucnak.redhat.com> <54B43CD1.1040100@redhat.com> <20150113161136.GC1405@tucnak.redhat.com> In-Reply-To: <20150113161136.GC1405@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00923.txt.bz2 On 01/13/15 09:11, Jakub Jelinek wrote: > On Mon, Jan 12, 2015 at 02:29:53PM -0700, Jeff Law wrote: >> On 01/12/15 12:59, Jakub Jelinek wrote: >>> Hi! >>> >>> As mentioned in the PR, giving up for all vector mode extensions >>> is unnecessary, but unlike scalar integer extensions, where the low part >>> of the extended value is the original value, for vectors this is not true, >>> thus the old value is lost. Which means we can perform REE, but only if >>> all uses of the definition are the same (code+mode) extension. >>> >>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? >>> >>> 2015-01-12 Jakub Jelinek >>> >>> PR rtl-optimization/64286 >>> * ree.c (add_removable_extension): Don't add vector mode >>> extensions if all uses of the source register aren't the same >>> vector extensions. >>> >>> * gcc.target/i386/avx2-pr64286.c: New test. >> Does it make sense to remove your change for 59754 in combine_reaching_defs? >> Shouldn't this patch handle that case as well? > > You're right, this patch handles that too. > > New patch, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > 2015-01-13 Jakub Jelinek > > PR rtl-optimization/64286 > * ree.c (combine_reaching_defs): Move part of comment earlier, > remove !SCALAR_INT_MODE_P check. > (add_removable_extension): Don't add vector mode > extensions if all uses of the source register aren't the same > vector extensions. > > * gcc.target/i386/avx2-pr64286.c: New test. OK. Thanks for taking care of this. I can't seem to find time for doing any real debugging or bugfixing. jeff