From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5290 invoked by alias); 30 Jan 2015 12:09:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5234 invoked by uid 89); 30 Jan 2015 12:09:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jan 2015 12:09:32 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Fri, 30 Jan 2015 12:09:30 +0000 Received: from [10.1.209.51] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 30 Jan 2015 12:09:29 +0000 Message-ID: <54CB7479.1070304@arm.com> Date: Fri, 30 Jan 2015 13:25:00 -0000 From: Alan Lawrence User-Agent: Thunderbird 2.0.0.24 (X11/20101213) MIME-Version: 1.0 To: Marcus Shawcroft CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH][AArch64 Intrinsics] Replace temporary assembler for vst1_lane References: <54B562F4.9070803@arm.com> In-Reply-To: <54B562F4.9070803@arm.com> X-MC-Unique: 115013012093001301 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg02719.txt.bz2 This was posted towards the end of stage 3, a few days before stage 4 started. Is it now too late to "ping" ? --Alan Alan Lawrence wrote: > Nowadays, just storing the (bigendian-corrected) vector element to the ad= dress,=20 > generates exactly the same assembler for all cases except=20 > {float,int,uint}64x1_t, where > st1 {v0.d}[0], [x0] > becomes > str d0, [x0] >=20 > This is not a problem, and the change will be much better for optimizatio= n=20 > through the midend, as well as making use of previous improvements in err= or=20 > reporting. >=20 > Also move the /* vst1q */ comment, which was a couple intrinsics too late. >=20 > gcc/ChangeLog: >=20 > * config/aarch64/arm_neon.h (vst1_lane_f32, vst1_lane_f64, > vst1_lane_p8, vst1_lane_p16, vst1_lane_s8, vst1_lane_s16, > vst1_lane_s32, vst1_lane_s64, vst1_lane_u8, vst1_lane_u16, > vst1_lane_u32, vst1_lane_u64, vst1q_lane_f32, vst1q_lane_f64, > vst1q_lane_p8, vst1q_lane_p16, vst1q_lane_s8, vst1q_lane_s16, > vst1q_lane_s32, vst1q_lane_s64, vst1q_lane_u8, vst1q_lane_u16, > vst1q_lane_u32, vst1q_lane_u64): Reimplement with pointer dereference > and __aarch64_vget_lane_any. >=20 > Cross-tested check-gcc on aarch64-none-elf and aarch64_be-none-elf. >=20 > Ok for trunk? >=20 > Cheers, Alan