From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Dominique Dhumieres <dominiq@lps.ens.fr>
Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86
Date: Fri, 30 Jan 2015 20:36:00 -0000 [thread overview]
Message-ID: <54CBDEE5.5000204@redhat.com> (raw)
In-Reply-To: <20150130102436.GA1746@tucnak.redhat.com>
On 01/30/15 03:24, Jakub Jelinek wrote:
> On Fri, Jan 30, 2015 at 11:23:38AM +0100, Uros Bizjak wrote:
>> On Fri, Jan 30, 2015 at 11:13 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>
>>>> /* Each function should compile down to a byte move from
>>>> the input register into x, possibly at an offset within x. */
>>>> -/* { dg-final { scan-assembler-times "\tmovb\t%al, x" 4 } } */
>>>> +/* { dg-final { scan-assembler-times "movb\[ \\t\]+%al" 4 } } */
>>>
>>> Shouldn't that better be movb\[^\n\r\]+%al, so that it doesn't
>>> fail with -masm=intel ?
>>
>> Unfortunately, -masm=intel emits "mov ..., al". And since there is
>> already plenty of scan-asms for mov[lq], I just took the easy shortcut
>> ;)
>
> Ok, let's consider --target_board=unix/-masm=intel as unsupportable then.
Yes, definitely.
jeff
next prev parent reply other threads:[~2015-01-30 19:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 15:51 Uros Bizjak
2015-01-29 16:06 ` Jakub Jelinek
2015-01-29 16:08 ` Uros Bizjak
2015-01-29 16:23 ` Jakub Jelinek
2015-01-29 21:42 ` H.J. Lu
2015-01-30 9:21 ` Jeff Law
2015-01-30 11:02 ` Uros Bizjak
2015-01-30 11:21 ` Jakub Jelinek
2015-01-30 11:21 ` Uros Bizjak
2015-01-30 11:46 ` Jakub Jelinek
2015-01-30 20:36 ` Jeff Law [this message]
2015-01-30 20:37 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2015-01-30 11:01 Dominique Dhumieres
2015-01-29 15:21 Jeff Law
2015-01-29 20:50 ` Segher Boessenkool
2015-01-30 8:57 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBDEE5.5000204@redhat.com \
--to=law@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).