From: Jeff Law <law@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Dominique Dhumieres <dominiq@lps.ens.fr>
Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86
Date: Fri, 30 Jan 2015 20:37:00 -0000 [thread overview]
Message-ID: <54CBDFB8.3000703@redhat.com> (raw)
In-Reply-To: <CAFULd4b396rJpKAMU1c_Dk1h+zAmH2XgVvVB6RwgQouz3fKNpA@mail.gmail.com>
On 01/30/15 03:07, Uros Bizjak wrote:
> On Fri, Jan 30, 2015 at 7:12 AM, Jeff Law <law@redhat.com> wrote:
>
>>> Hello!
>>>
>>>> So here's the updated patch which handles all 4 testcases from the PR as
>>>> well as a couple of my own.
>>>
>>>
>>> @@ -0,0 +1,33 @@
>>> +/* PR 15184 first two tests, plus two addition ones. */
>>> +/* { dg-do compile } */
>>> +/* { dg-options "-O2 -m32 -march=pentiumpro" } */
>>>
>>> No, we don't want -m32 in dg-options. Please write this part as:
>>>
>>> /* { dg-do compile { target ia32 } } */
>>> /* { dg-options "-O2 -march=pentiumpro" } */
>>
>> Will update after sniff testing. Sorry for the noise.
>
> I'll commit the attached patch that fixes this and -fpic problem as
> soon as regtest finishes.
>
> 2015-01-30 Uros Bizjak <ubizjak@gmail.com>
>
> * gcc.target/i386/pr15184-1.c: Compile for ia32 target only.
> (dg-options): Remove -m32.
> (dg-final): Scan for "movb %al" only.
> * gcc.target/i386/pr15184-2.c: Ditto.
Again, sorry for making work for you. There's clearly more to the x86
target tests than meets the eye. I'll run further additions through you
until I think I've got my brain wrapped around all things that have to
be considered for x86 specific tests.
jeff
next prev parent reply other threads:[~2015-01-30 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 15:51 Uros Bizjak
2015-01-29 16:06 ` Jakub Jelinek
2015-01-29 16:08 ` Uros Bizjak
2015-01-29 16:23 ` Jakub Jelinek
2015-01-29 21:42 ` H.J. Lu
2015-01-30 9:21 ` Jeff Law
2015-01-30 11:02 ` Uros Bizjak
2015-01-30 11:21 ` Jakub Jelinek
2015-01-30 11:21 ` Uros Bizjak
2015-01-30 11:46 ` Jakub Jelinek
2015-01-30 20:36 ` Jeff Law
2015-01-30 20:37 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-30 11:01 Dominique Dhumieres
2015-01-29 15:21 Jeff Law
2015-01-29 20:50 ` Segher Boessenkool
2015-01-30 8:57 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBDFB8.3000703@redhat.com \
--to=law@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).