From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Marek Polacek <polacek@redhat.com>,
Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Ian Lance Taylor <ian@airs.com>,
Jakub Jelinek <jakub@redhat.com>,
"walt@tilera.com" <walt@tilera.com>, Jeff Law <law@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.
Date: Sat, 31 Jan 2015 19:51:00 -0000 [thread overview]
Message-ID: <54CCCAD3.9020800@sunrus.com.cn> (raw)
In-Reply-To: <20150131114911.GK4074@redhat.com>
On 1/31/15 19:49, Marek Polacek wrote:
> On Sat, Jan 31, 2015 at 05:13:53PM +0530, Prathamesh Kulkarni wrote:
>> On 31 January 2015 at 15:30, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>> On 1/31/15 16:53, Andreas Schwab wrote:
>>>> Chen Gang S <gang.chen@sunrus.com.cn> writes:
>>>>
>>>>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces
>>>>> instead of macro's empty body to avoid xgcc warnings.
>> The ChangeLog entry should be fixed to reflect it's an empty loop now.
>> something like:
>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use empty do-while
>> loop as macro body to avoid xgcc warnings.
>
> And since CL entries should describe what, not why, the "to avoid..."
> part is redundant.
>
OK, thanks. I should send patch v3 within today.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-01-31 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 11:33 Chen Gang S
2015-01-31 12:34 ` Andreas Schwab
2015-01-31 14:50 ` Chen Gang S
2015-01-31 15:45 ` Prathamesh Kulkarni
2015-01-31 15:45 ` Marek Polacek
2015-01-31 19:51 ` Chen Gang S [this message]
2015-04-14 5:30 ` Jeff Law
2015-04-15 15:29 Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CCCAD3.9020800@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=polacek@redhat.com \
--cc=prathamesh.kulkarni@linaro.org \
--cc=schwab@linux-m68k.org \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).