From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12233 invoked by alias); 31 Jan 2015 12:22:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12222 invoked by uid 89); 31 Jan 2015 12:22:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-211.mail.aliyun.com Received: from out1134-211.mail.aliyun.com (HELO out1134-211.mail.aliyun.com) (42.120.134.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 31 Jan 2015 12:22:39 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.09580846|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r46d02013;MF=gang.chen@sunrus.com.cn;PH=DS;RN=8;RT=8;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.40) by smtp.aliyun-inc.com(10.147.34.66); Sat, 31 Jan 2015 20:22:26 +0800 Message-ID: <54CCCAD3.9020800@sunrus.com.cn> Date: Sat, 31 Jan 2015 19:51:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Marek Polacek , Prathamesh Kulkarni CC: Andreas Schwab , Ian Lance Taylor , Jakub Jelinek , "walt@tilera.com" , Jeff Law , gcc-patches List Subject: Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings. References: <54CC7085.1080805@sunrus.com.cn> <54CCA7D8.7010702@sunrus.com.cn> <20150131114911.GK4074@redhat.com> In-Reply-To: <20150131114911.GK4074@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg02805.txt.bz2 On 1/31/15 19:49, Marek Polacek wrote: > On Sat, Jan 31, 2015 at 05:13:53PM +0530, Prathamesh Kulkarni wrote: >> On 31 January 2015 at 15:30, Chen Gang S wrote: >>> On 1/31/15 16:53, Andreas Schwab wrote: >>>> Chen Gang S writes: >>>> >>>>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces >>>>> instead of macro's empty body to avoid xgcc warnings. >> The ChangeLog entry should be fixed to reflect it's an empty loop now. >> something like: >> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use empty do-while >> loop as macro body to avoid xgcc warnings. > > And since CL entries should describe what, not why, the "to avoid..." > part is redundant. > OK, thanks. I should send patch v3 within today. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed