From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2028 invoked by alias); 2 Feb 2015 22:44:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2004 invoked by uid 89); 2 Feb 2015 22:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Feb 2015 22:44:12 +0000 X-Envelope-From: doko@debian.org Received: from [192.168.42.218] (dslb-088-073-093-027.088.073.pools.vodafone-ip.de [88.73.93.27]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id t12Mi6dI022463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 2 Feb 2015 23:44:08 +0100 Message-ID: <54CFFDB6.9000509@debian.org> Date: Mon, 02 Feb 2015 22:44:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jason Merrill , gcc-patches List Subject: Re: C++ PATCH for abi_tag sanity checking References: <54CFB72F.1090907@redhat.com> In-Reply-To: <54CFB72F.1090907@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00098.txt.bz2 On 02/02/2015 06:43 PM, Jason Merrill wrote: > One of the EDG guys pointed out to me that we weren't doing any sanity checking > on the arguments to the abi_tag attribute. This patch adds checks to require > that the arguments be strings containing valid identifiers, so they work > appropriately in mangled names. > > Tested x86_64-pc-linux-gnu, applying to trunk. thanks, however it would be nice to document what this flags does at all. Please see PR 64859. Matthias