From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29391 invoked by alias); 6 Feb 2015 14:02:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29374 invoked by uid 89); 6 Feb 2015 14:02:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Feb 2015 14:02:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t16E29gA001681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Feb 2015 09:02:09 -0500 Received: from [10.10.116.24] ([10.10.116.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t16E286V003464; Fri, 6 Feb 2015 09:02:09 -0500 Message-ID: <54D4C95D.8040000@redhat.com> Date: Fri, 06 Feb 2015 14:02:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Aldy Hernandez CC: Richard Biener , gcc-patches Subject: Re: [debug-early] C++ clones and limbo DIEs References: <54B87E5B.1090502@redhat.com> <54B88149.1040906@redhat.com> <54B94F4D.4040009@redhat.com> <54B97854.7040007@redhat.com> <54C296B5.4050506@redhat.com> <54C7FA41.8010903@redhat.com> <54C92A59.4070401@redhat.com> <54C92A80.80306@redhat.com> <54C92FA8.9040005@redhat.com> <54CBEB69.3000401@redhat.com> <54CBFFE7.1010003@redhat.com> <54CC1885.5010105@redhat.com> <54CDC625.8070902@redhat.com> <54CEEBD5.7090608@redhat.com> <54CEF9FE.6020107@redhat.com> <54D2B907.1040309@redhat.com> <54D3CE5A.1000609@redhat.com> <54D4159F.4090601@redhat.com> In-Reply-To: <54D4159F.4090601@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00403.txt.bz2 On 02/05/2015 08:15 PM, Aldy Hernandez wrote: > Absolutely nothing, basically because #if 0 would have been too obvious. It was actually there to test if you were on your game. You passed Yay? > The attached patch still passes the guality tests with no regressions. My apologies for the lack of ChangeLog entries. I've given up on them, especially on multiple iterations. And it seems I'll have to rewrite them at merge time anyhow. That makes total sense to me. > + && DECL_CONTEXT (snode->decl) > + && TREE_CODE (DECL_CONTEXT (snode->decl)) != FUNCTION_DECL) I think this should be !decl_function_context (snode->decl), in case there's a class or BLOCK between the symbol and its enclosing function. > dwarf2out_type_decl (tree decl, int local) > + /* ?? Technically, we shouldn't need this hook at all, as all > + symbols (and by consequence their types) will be outputed from > + finalize_compilation_unit. Note that we also want to emit debug info about some types that are not referenced by symbols, such as when a type is used in a cast. > +/* Perform any cleanups needed after the early debug generation pass > + has run. */ > + > +static void > +dwarf2out_early_finish (void) Since this is also called from dwarf2out_finish, let's call it something more descriptive, say, flush_limbo_dies? Jason