From: Richard Henderson <rth@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jack Howarth <howarth.at.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>,
Iain Sandoe <iain@codesourcery.com>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] PR rtl-optimization/32219: optimizer causees wrong code in pic/hidden/weak symbol checking
Date: Thu, 12 Feb 2015 19:25:00 -0000 [thread overview]
Message-ID: <54DCFE10.3050906@redhat.com> (raw)
In-Reply-To: <CAMe9rOrFdRqFXxw-ASFasb8M+UaaT4NNKrWUZ+D-CjpFGvOuNA@mail.gmail.com>
On 02/12/2015 10:58 AM, H.J. Lu wrote:
> if (DECL_VISIBILITY_SPECIFIED (exp)
> + && (resolved_locally
> + || !flag_pic
Yes, this essentially goes back to your original patch, which I claim still
conflates issues.
In particular, I believe mentioning flag_pic here is a serious error.
There are two problems that I see so far,
(1) node->definition isn't set for this symbol. This is because you
only fixed varpool_node::finalize_decl, and not
cgraph_node::finalize_function.
(2) The weak test should probably be split into two pieces, like the
visibility test: exclude undefined weak, include specified visibility,
exclude non-dominant weak, exclude external, include implied visibility.
r~
next prev parent reply other threads:[~2015-02-12 19:25 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 16:23 [PATCH] PR rtl-optimization/32219: optimizer causes " H.J. Lu
2015-02-06 21:31 ` Jack Howarth
2015-02-06 21:41 ` H.J. Lu
2015-02-06 21:51 ` Jack Howarth
2015-02-07 1:50 ` H.J. Lu
2015-02-07 1:51 ` Jack Howarth
2015-02-07 1:55 ` H.J. Lu
2015-02-07 2:25 ` Jack Howarth
2015-02-07 8:28 ` Jack Howarth
2015-02-07 12:27 ` H.J. Lu
2015-02-07 15:11 ` Jack Howarth
2015-02-07 15:25 ` Jack Howarth
2015-02-07 15:56 ` H.J. Lu
2015-02-07 16:45 ` H.J. Lu
2015-02-08 18:24 ` Jack Howarth
2015-02-09 17:26 ` Mike Stump
2015-02-10 18:33 ` Jack Howarth
2015-02-10 21:19 ` Richard Henderson
2015-02-10 21:25 ` H.J. Lu
2015-02-11 14:35 ` Jack Howarth
2015-02-12 6:23 ` [PATCH] PR rtl-optimization/32219: optimizer causees " Richard Henderson
2015-02-12 18:16 ` H.J. Lu
2015-02-12 18:58 ` H.J. Lu
2015-02-12 19:25 ` Richard Henderson [this message]
2015-02-12 23:04 ` H.J. Lu
2015-02-12 23:05 ` H.J. Lu
2015-02-13 0:05 ` Richard Henderson
2015-02-13 4:14 ` H.J. Lu
2015-02-13 5:11 ` Richard Henderson
2015-02-18 14:17 ` Alex Velenko
2015-02-19 13:12 ` H.J. Lu
2015-02-19 15:02 ` Richard Henderson
2015-02-19 17:25 ` Alex Velenko
2015-02-19 17:27 ` Richard Henderson
2015-03-03 15:58 ` Alex Velenko
2015-03-05 14:55 ` Alex Velenko
2015-03-05 15:31 ` Ramana Radhakrishnan
2015-03-06 11:14 ` Alex Velenko
2015-02-12 19:16 ` Jack Howarth
2015-02-12 19:18 ` H.J. Lu
2015-02-12 19:39 ` Jack Howarth
2015-02-07 19:37 ` [PATCH] PR rtl-optimization/32219: optimizer causes " Jack Howarth
2015-02-16 13:25 [PATCH] PR rtl-optimization/32219: optimizer causees " Uros Bizjak
2015-02-16 14:01 ` H.J. Lu
2015-02-16 16:30 ` Richard Henderson
2015-02-16 16:38 ` H.J. Lu
2015-02-19 21:07 ` Uros Bizjak
2015-02-19 21:08 ` H.J. Lu
2015-02-19 21:16 ` Richard Henderson
2015-02-19 21:16 ` H.J. Lu
2015-02-19 21:35 ` Richard Henderson
2015-02-19 21:43 ` H.J. Lu
2015-02-19 23:39 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCFE10.3050906@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=howarth.at.gcc@gmail.com \
--cc=hubicka@ucw.cz \
--cc=iain@codesourcery.com \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).