* [PATCH] Tweak tm/pr47573.C testcase (PR c++/64884)
@ 2015-02-12 21:25 Jakub Jelinek
2015-02-12 21:31 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2015-02-12 21:25 UTC (permalink / raw)
To: Richard Henderson; +Cc: gcc-patches
Hi!
This patch tweaks the pr47573.C testcase, so that it is run only on
comdat_group target. It is true that comdat_group is stricter than
comdat, but we don't have an effective-target for the latter and I'm not
sure what exactly to test for.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
2015-02-12 Jakub Jelinek <jakub@redhat.com>
PR c++/64884
* g++.dg/tm/pr47573.C: Only run on comdat_group effective targets.
--- gcc/testsuite/g++.dg/tm/pr47573.C.jj 2011-11-08 23:35:11.000000000 +0100
+++ gcc/testsuite/g++.dg/tm/pr47573.C 2015-02-12 14:26:23.873151135 +0100
@@ -1,4 +1,7 @@
-// { dg-do compile }
+// Without comdat support, we don't see the body of the
+// extern template class constructor, so limit this to
+// known comdat targets.
+// { dg-do compile { target comdat_group } }
// { dg-options "-fgnu-tm" }
template<typename _Tp> class allocator
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Tweak tm/pr47573.C testcase (PR c++/64884)
2015-02-12 21:25 [PATCH] Tweak tm/pr47573.C testcase (PR c++/64884) Jakub Jelinek
@ 2015-02-12 21:31 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2015-02-12 21:31 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On 02/12/2015 01:25 PM, Jakub Jelinek wrote:
> Hi!
>
> This patch tweaks the pr47573.C testcase, so that it is run only on
> comdat_group target. It is true that comdat_group is stricter than
> comdat, but we don't have an effective-target for the latter and I'm not
> sure what exactly to test for.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2015-02-12 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/64884
> * g++.dg/tm/pr47573.C: Only run on comdat_group effective targets.
Yes, thanks. I don't see what else we can test for either,
and it's entirely likely the set of comdat supporters that
don't also support comdat_group is probably empty anyway.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-12 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-12 21:25 [PATCH] Tweak tm/pr47573.C testcase (PR c++/64884) Jakub Jelinek
2015-02-12 21:31 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).