From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32457 invoked by alias); 13 Feb 2015 13:48:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32435 invoked by uid 89); 13 Feb 2015 13:48:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Feb 2015 13:48:41 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Fri, 13 Feb 2015 13:48:38 +0000 Received: from e106327-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 13 Feb 2015 13:48:36 +0000 Message-ID: <54DE00B5.6010003@arm.com> Date: Fri, 13 Feb 2015 13:48:00 -0000 From: Matthew Wahab User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: libstdc++ , Jonathan Wakely , Hans-Peter Nilsson Subject: Re: [PATCH][libstdc++][Testsuite] isctype test fails for newlib. References: <54D0A034.1040306@arm.com> <54D0A291.4010702@oracle.com> <54D0A5B1.2000806@arm.com> <54D8992B.6060707@arm.com> <54D8F2F6.7030406@arm.com> <54D9C694.7050102@arm.com> <54DB3993.7020000@arm.com> <20150211154356.GT3360@redhat.com> In-Reply-To: <20150211154356.GT3360@redhat.com> X-MC-Unique: 115021313483801701 Content-Type: multipart/mixed; boundary="------------060708060407000600070908" X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00849.txt.bz2 This is a multi-part message in MIME format. --------------060708060407000600070908 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-length: 962 On 11/02/15 15:43, Jonathan Wakely wrote: > On 11/02/15 11:14 +0000, Matthew Wahab wrote: >> Attached the fixed patch. >> Tested by running check-target-libstdc++-v3, with the modified tests, >> for arm-none-eabi and aarch64-none-linux-gnu. >> >> Ok to commit? > > OK, thanks. Some DOS line endings were introduced into the char/isctype.cc file when=20 I committed this change These aren't visible in a terminal or with svn=20 diff but do show up in emacs. This is causing the test to fail in local=20 runs. The wchar_t/isctype.cc file isn't affected. I've committed the attached patch as obvious, it just removes the DOS=20 line endings from the file. Tested with check-target-libstdc++-v3/conformance.exp for arm-none-eabi=20 and aarch64-none-linux-gnu; checked the patched file in emacs. Matthew 2015-02-13 Matthew Wahab * testsuite/28_regex/traits/char/isctype.cc (test01): Fix mixed line-endings introduced in last change. --------------060708060407000600070908 Content-Type: text/x-patch; name=changes.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="changes.patch" Content-length: 1997 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjhfcmVnZXgv dHJhaXRzL2NoYXIvaXNjdHlwZS5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3Vp dGUvMjhfcmVnZXgvdHJhaXRzL2NoYXIvaXNjdHlwZS5jYwppbmRleCAwYTEw NzFjLi44ZjcxOTEwIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1 aXRlLzI4X3JlZ2V4L3RyYWl0cy9jaGFyL2lzY3R5cGUuY2MKKysrIGIvbGli c3RkYysrLXYzL3Rlc3RzdWl0ZS8yOF9yZWdleC90cmFpdHMvY2hhci9pc2N0 eXBlLmNjCkBAIC01MSwxNCArNTEsMTQgQEAgdGVzdDAxKCkKICAgVkVSSUZZ KCF0LmlzY3R5cGUoJ2UnLCB0Lmxvb2t1cF9jbGFzc25hbWUocmFuZ2UodXBw ZXIpKSkpOwogICBWRVJJRlkoIHQuaXNjdHlwZSgnZScsIHQubG9va3VwX2Ns YXNzbmFtZShyYW5nZShsb3dlcikpKSk7CiAgIFZFUklGWSghdC5pc2N0eXBl KCdlJywgdC5sb29rdXBfY2xhc3NuYW1lKHJhbmdlKG5vdGhpbmcpKSkpOwot ICBWRVJJRlkoIXQuaXNjdHlwZSgnXycsIHQubG9va3VwX2NsYXNzbmFtZShy YW5nZShkaWdpdCkpKSk7DQotICBWRVJJRlkoIHQuaXNjdHlwZSgnICcsIHQu bG9va3VwX2NsYXNzbmFtZShyYW5nZShibGFuaykpKSk7DQotICBWRVJJRlko IHQuaXNjdHlwZSgnXHQnLCB0Lmxvb2t1cF9jbGFzc25hbWUocmFuZ2UoYmxh bmspKSkpOw0KLSNpZiBkZWZpbmVkIChORVdMSU5FX0lOX0NMQVNTX0JMQU5L KQ0KLSAgLyogT24gc29tZSB0YXJnZXRzLCAnXG4nIGlzIGluIGNsYXNzICdi bGFuaycuDQotICAgICBTZWUgaHR0cHM6Ly9nY2MuZ251Lm9yZy9tbC9nY2Mt cGF0Y2hlcy8yMDE1LTAyL21zZzAwMDU5Lmh0bWwuICAqLw0KLSAgVkVSSUZZ KCB0LmlzY3R5cGUoJ1xuJywgdC5sb29rdXBfY2xhc3NuYW1lKHJhbmdlKGJs YW5rKSkpKTsNCi0jZWxzZQ0KKyAgVkVSSUZZKCF0LmlzY3R5cGUoJ18nLCB0 Lmxvb2t1cF9jbGFzc25hbWUocmFuZ2UoZGlnaXQpKSkpOworICBWRVJJRlko IHQuaXNjdHlwZSgnICcsIHQubG9va3VwX2NsYXNzbmFtZShyYW5nZShibGFu aykpKSk7CisgIFZFUklGWSggdC5pc2N0eXBlKCdcdCcsIHQubG9va3VwX2Ns YXNzbmFtZShyYW5nZShibGFuaykpKSk7CisjaWYgZGVmaW5lZCAoTkVXTElO RV9JTl9DTEFTU19CTEFOSykKKyAgLyogT24gc29tZSB0YXJnZXRzLCAnXG4n IGlzIGluIGNsYXNzICdibGFuaycuCisgICAgIFNlZSBodHRwczovL2djYy5n bnUub3JnL21sL2djYy1wYXRjaGVzLzIwMTUtMDIvbXNnMDAwNTkuaHRtbC4g ICovCisgIFZFUklGWSggdC5pc2N0eXBlKCdcbicsIHQubG9va3VwX2NsYXNz bmFtZShyYW5nZShibGFuaykpKSk7CisjZWxzZQogICBWRVJJRlkoIXQuaXNj dHlwZSgnXG4nLCB0Lmxvb2t1cF9jbGFzc25hbWUocmFuZ2UoYmxhbmspKSkp OwogI2VuZGlmCiAgIFZFUklGWSggdC5pc2N0eXBlKCd0JywgdC5sb29rdXBf Y2xhc3NuYW1lKHJhbmdlKHVwcGVyKSwgdHJ1ZSkpKTsK --------------060708060407000600070908--