From: Jason Merrill <jason@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] PR debug/58123: Set correct location for TRY blocks
Date: Mon, 23 Feb 2015 19:37:00 -0000 [thread overview]
Message-ID: <54EB7366.9030205@redhat.com> (raw)
In-Reply-To: <54E61DE2.5010401@redhat.com>
On 02/19/2015 12:31 PM, Aldy Hernandez wrote:
> As explained in the PR, I would ideally like to get rid of the kludge
> where we set the location of location-less FINALLY statements to be that
> of the TRY statement, but that may be by design, and/or beyond the scope
> of this fix.
This reminds me of the semi-recent change to disassociate variable
cleanups with the location of the declaration. I think Jakub added a
pass specifically for this purpose? I think making the change you
suggest would make sense, but probably as a separate patch.
Jason
next prev parent reply other threads:[~2015-02-23 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54E61BE5.9090209@redhat.com>
2015-02-19 18:33 ` Aldy Hernandez
2015-02-20 19:06 ` Jeff Law
2015-02-23 19:37 ` Jason Merrill [this message]
2015-02-23 21:00 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB7366.9030205@redhat.com \
--to=jason@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).