From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38450 invoked by alias); 5 Mar 2015 14:55:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38441 invoked by uid 89); 5 Mar 2015 14:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Mar 2015 14:55:28 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Thu, 05 Mar 2015 14:55:25 +0000 Received: from [10.2.206.61] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Mar 2015 14:55:25 +0000 Message-ID: <54F86E5C.5080403@arm.com> Date: Thu, 05 Mar 2015 14:55:00 -0000 From: Alex Velenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Richard Henderson CC: "H.J. Lu" , Jack Howarth , GCC Patches , Ramana Radhakrishnan , Jan Hubicka Subject: Re: [PATCH] PR rtl-optimization/32219: optimizer causees wrong code in pic/hidden/weak symbol checking References: <20150206162314.GA12597@intel.com> <20150207122739.GA25185@gmail.com> <20150207155606.GA14159@gmail.com> <20150207164507.GA19402@gmail.com> <54DA75D2.40402@redhat.com> <54DC46BF.5060503@redhat.com> <54DCFE10.3050906@redhat.com> <54DD3FA9.3010609@redhat.com> <54DD877E.7060500@redhat.com> <54E49EF6.3090601@arm.com> <54E5F041.6040701@redhat.com> <54E6188F.507@arm.com> <54E61CAE.30804@redhat.com> <54F5DA29.70004@arm.com> In-Reply-To: <54F5DA29.70004@arm.com> X-MC-Unique: 115030514552504801 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00292.txt.bz2 On 03/03/15 15:58, Alex Velenko wrote: > On 19/02/15 17:26, Richard Henderson wrote: >> On 02/19/2015 09:08 AM, Alex Velenko wrote: >>> Your suggestion seem to fix gcc.target/arm/long-calls-1.c, but has=20 >>> to be >>> thoroughly tested. >> >> Before you do complete testing, please also delete the TREE_STATIC test. >> That bit should never be relevant to functions, as it indicates not that >> it is in the compilation unit, but that it has static (as opposed to >> automatic) storage duration. Thus it is only relevant to variables. >> >> >> r~ >> >> >> >> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c >> index 7bf5b4d..777230e 100644 >> --- a/gcc/config/arm/arm.c >> +++ b/gcc/config/arm/arm.c >> @@ -6392,14 +6392,8 @@ arm_set_default_type_attributes (tree type) >> static bool >> arm_function_in_section_p (tree decl, section *section) >> { >> - /* We can only be certain about functions defined in the same >> - compilation unit. */ >> - if (!TREE_STATIC (decl)) >> - return false; >> - >> - /* Make sure that SYMBOL always binds to the definition in this >> - compilation unit. */ >> - if (!targetm.binds_local_p (decl)) >> + /* We can only be certain about the prevailing symbol definition. */ >> + if (!decl_binds_to_current_def_p (decl)) >> return false; >> >> /* If DECL_SECTION_NAME is set, assume it is trustworthy. */ >> >> > > Hi, > > Did a bootstrap and a full regression run on arm-none-linux-gnueabihf, > No new regressions found. Some previously failing tests in libstdc++=20 > started to fail differently, for example: > > < ERROR: 22_locale/num_get/get/wchar_t/2.cc: can't read=20 > "additional_sources": no such variable for " dg-do 22 run { xfail=20 > lax_strtof\ > p } " > < UNRESOLVED: 22_locale/num_get/get/wchar_t/2.cc: can't read=20 > "additional_sources": no such variable for " dg-do 22 run { xfail lax_s\ > trtofp } " > --- > > ERROR: 22_locale/num_get/get/wchar_t/2.cc: can't read=20 > "et_cache(uclibc,value)": no such element in array for " dg-do 22 run=20 > { xfai\ > l lax_strtofp } " > > UNRESOLVED: 22_locale/num_get/get/wchar_t/2.cc: can't read=20 > "et_cache(uclibc,value)": no such element in array for " dg-do 22 run {\ > xfail lax_strtofp } " > > > But I think it is okay. > > Kind regards, > Alex > > Hi, Ping. Could someone, please approve Richard's patch? This issue needs fixing. Kind regards, Alex