From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50734 invoked by alias); 9 Mar 2015 16:13:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 50721 invoked by uid 89); 9 Mar 2015 16:13:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Mar 2015 16:13:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t29GDNKp001793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Mar 2015 12:13:23 -0400 Received: from [10.10.116.41] ([10.10.116.41]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t29GDMlt030268; Mon, 9 Mar 2015 12:13:22 -0400 Message-ID: <54FDC69F.3000901@redhat.com> Date: Mon, 09 Mar 2015 16:13:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jakub Jelinek CC: "Joseph S. Myers" , gcc-patches@gcc.gnu.org Subject: Re: [C/C++ PATCH] -Wlogical-not-parentheses tweaks (PR c/65120) References: <20150220000326.GT1746@tucnak.redhat.com> <54F0EFDB.5030703@redhat.com> <20150309143456.GR1746@tucnak.redhat.com> In-Reply-To: <20150309143456.GR1746@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00479.txt.bz2 On 03/09/2015 10:34 AM, Jakub Jelinek wrote: > On Fri, Feb 27, 2015 at 05:29:47PM -0500, Jason Merrill wrote: >> On 02/19/2015 07:03 PM, Jakub Jelinek wrote: >>> + /* Avoid warning for !!b == y where b is boolean. */ >>> + && (!DECL_P (current.lhs) >>> + || TREE_TYPE (current.lhs) == NULL_TREE >>> + || TREE_CODE (TREE_TYPE (current.lhs)) != BOOLEAN_TYPE)) >> >> There's something wrong here. If the type is null, trying to check its >> TREE_CODE will SEGV. > > If the type is NULL, then it will just call warn_logical_not_parentheses > and won't check TREE_CODE. Only when it is non-NULL, it will check > TREE_CODE and if it is not BOOLEAN_TYPE, will call > warn_logical_not_parentheses. You're right, of course. I guess I was reading the || as an &&. The patch is OK. Jason