From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 607103858D20 for ; Mon, 22 Jan 2024 11:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 607103858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 607103858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705922730; cv=none; b=TiRcj5b26Dq6BLOhKPpay4A6+PQAB2DbRh/SKVdHYu3QU6uTb+AX2jHip7o1beymy3f3/Ws4njWXIE2nBdy7AcrJ3FPOi17W0F4SwvYOiFOjcwYa6xOpek6XLTG0wO/BwJ5yVhrXfsMbSpSoiBVgWIRpGn6T8AI9EhspCDL/qFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705922730; c=relaxed/simple; bh=aJX5dY1dHWK07XIyVByMxFCrMfpV+ZGepRx0BBVdyXw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MVGWyUxy3HLEQse/1Lb6rsJD40yuUyTvWZbNnvBCIUHB8rLCjSycT/JvvoiMYBB/WvCXmDNNvHIzLa/N8YHB69UIjzxC/+op3/Y4kpBA5SAoXDPNSnSj+2BmEqt6ED1b8qQ4uaky4idrxxzDlUmIWEp7QlV8kXk1aUoAlhGLGCc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a2f0cb62068so304981166b.2 for ; Mon, 22 Jan 2024 03:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705922726; x=1706527526; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qhHxlTe18h/CE2b9O0DdIOe6F+mXwCE2y+QZ9+WuXsY=; b=eOBVWYk3YkAoi9Z78C+MwpcEmyiRIipLXjf1ofkwGzVsCi0CBNldxlXOdlfCPheT29 48quMVBuc48E4/kynMSvAzGVtyVfO6FE0ew8hQ2yumEhzHgjJ05SAjxJRaYg/pU0y7mf +Y0IGit7aFhUVxxpA3kkkVkHkVPxt8xihfYwmeZG94aaINqMNcx5t6APDLIezLTbDjzn 9to0qKnCPzpVSVjTWRBjayFYqwa8uZQD90TOZlC+uhglO7Cibhfe9EB7pUs6OR4Pw5k4 cNUOJx00SJIG4hG244cg57hSq3aiZtUEHLBMIRfDtEyd4WKunNtazP2XmLf0QJ1dRwJN b7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705922726; x=1706527526; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qhHxlTe18h/CE2b9O0DdIOe6F+mXwCE2y+QZ9+WuXsY=; b=V/39p2ubYQ4kFN3nlqNCxVE7wJHfFsE/pJrR5ICbrWhoBNFFeardbR2jjsLO9OqIU4 2lMsPalpz3W/M/Gavb+xWLQ2PB43rUrA5uL2QARi6T9xU//Dqf8DSOCjRzPpfdtzlAam 1nhM8YvtvdtWKTE7d9OZY37mha8N+HhnnkuuS8/0+KpZRsY+Rxr4gHErwzORJ8qRN0Ua LrdyU6wfS3S2lAWnr/Q/vlhGjZqd9nGphprq6avhd8KDanJk4XnFzbSfOx0NNp70Ya2N SQE2dploLsTAMp17f2qTiooNs4rf19diIW7Vv686EQZDd/P0JVjY0sJ7cW+exSb9QVmz HRGA== X-Gm-Message-State: AOJu0YzWMmRdOh2rkRLuNAPe+VUKctOl4iCO5MBkCv35kPncr0qoRKsn ir4jtkhCDcfw5Av1kLIS72BzKTByZ33NhzcWlZWKqynX8fKcMwWb X-Google-Smtp-Source: AGHT+IHxOge6k3KHACp4eUhxpHYum34Xiv20u9gLj1uVNtRNbFOatYAlVHZaBNcuf2CgmpAL004vMA== X-Received: by 2002:a17:907:c207:b0:a30:494:75e6 with SMTP id ti7-20020a170907c20700b00a30049475e6mr745749ejc.182.1705922725656; Mon, 22 Jan 2024 03:25:25 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id a13-20020a170906274d00b00a2b608ad048sm13226889ejd.28.2024.01.22.03.25.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 03:25:25 -0800 (PST) Message-ID: <54b40771-d5e8-42a4-a452-6874dd4b2e6d@gmail.com> Date: Mon, 22 Jan 2024 12:25:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Fix regressions due to 86de9b66480b710202a2898cf513db105d8c432f Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20240122090507.2617720-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20240122090507.2617720-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Juzhe, in principle this seems ok to me but I wonder about: > We shouldn't worry about subreg:...VL_REGNUM since it's impossible > that we can have such situation, I think we allow this in legitimize_move for situations like (subreg:SI (reg:V4QI)). That was not added for correctness but optimization - are we sure we don't undo this optimization with that change? Regards Robin