Re: [Committed] RISC-V: Support VLS unary floating-point patterns

[Patrick O'Neill <patrick@rivosinc.com>]

On 9/21/23 03:20, Palmer Dabbelt wrote:
> On Wed, 20 Sep 2023 10:47:23 PDT (-0700), Patrick O'Neill wrote:
>> ...
>>
>> [1]:
>> Executing on host:
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/xgcc 
>>
>> -B/github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/ 
>>
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/math-ceil-1.c 
>>
>> -march=rv32gcv -mabi=ilp32d -mcmodel=medlow -fdiagnostics-plain-output
>> -O3 -ftree-vectorize -march=rv64gcv -mabi=lp64d -O3 -ftree-vectorize
>> -fno-vect-cost-model -ffast-math -fno-schedule-insns
>> -fno-schedule-insns2 -S   -o math-ceil-1.s (timeout = 600)
>> spawn -ignore SIGHUP
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/xgcc 
>>
>> -B/github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/ 
>>
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/math-ceil-1.c 
>>
>> -march=rv32gcv -mabi=ilp32d -mcmodel=medlow -fdiagnostics-plain-output
>> -O3 -ftree-vectorize -march=rv64gcv -mabi=lp64d -O3 -ftree-vectorize
>> -fno-vect-cost-model -ffast-math -fno-schedule-insns
>> -fno-schedule-insns2 -S -o math-ceil-1.s
>> In file included from
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/sysroot/usr/include/features.h:515, 
>>
>>                   from
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/sysroot/usr/include/bits/libc-header-start.h:33, 
>>
>>                   from
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/sysroot/usr/include/math.h:27, 
>>
>>                   from
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/test-math.h:1, 
>>
>>                   from
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/math-ceil-1.c:5: 
>>
>> /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/sysroot/usr/include/gnu/stubs.h:17:11: 
>>
>> fatal error: gnu/stubs-lp64d.h: No such file or directory
>
> That looks like a toolchain build/configuration issue, not a test 
> issue.  IIRC this comes up from time to time, something's probably 
> broken in riscv-gnu-toolchain but I'm not sure what's wrong.
>
> I get a working setup with just `./configure --enable-linux 
> --disable-multilib` and the latest riscv-gnu-toolchain master. How are 
> you building things?
I've kicked off a few builds to confirm but I use:

git clone https://github.com/riscv-collab/riscv-gnu-toolchain
cd riscv-gnu-toolchain
git submodule update --init gcc
cd gcc && git checkout master && cd ..
mkdir build && cd build
../configure --prefix=$(pwd) --with-arch=rv32gcv --with-abi=ilp32d

Make sure you bump gcc to tip of tree!
The latest riscv-gnu-toolchain master uses gcc 12.2 which doesn't have
the testcases that are failing (rvv folder):
https://github.com/gcc-mirror/gcc/tree/2ee5e4300186a92ad73f1a1a64cb918dc76c8d67/gcc/testsuite/gcc.target/riscv

The failures only show up for tests in:
gcc.target/riscv/rvv/
gcc.dg/vect/costmodel/riscv/rvv/

After bumping gcc and using your command (with --prefix)
../configure --enable-linux --disable-multilib --prefix=$(pwd)
I still get the missing stubs failures.

I've also tried this with the build directory both inside and outside
the repo and that doesn't make a difference.

Patrick

>
>> compilation terminated.
>> compiler exited with status 1
>> FAIL: gcc.target/riscv/rvv/autovec/math-ceil-1.c -O3 -ftree-vectorize
>> (test for excess errors)
>>
>> [2]:
>> https://github.com/ewlu/riscv-gnu-toolchain/issues/170
>>
>> [3]:
>> This also extends beyond math.h. I'm seeing similar failures for
>> testcases like
>> gcc.target/riscv/rvv/autovec/cond/cond_convert_int2float-rv64-1.c that
>> #include <stdint.h>.