From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45]) by sourceware.org (Postfix) with ESMTPS id 3297B3858D3C for ; Mon, 6 Nov 2023 11:10:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3297B3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3297B3858D3C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699269040; cv=pass; b=hT7ZHjdQ227ctkQjTfcndPMcAQcqoS74iEK0z/51g3xfyNyk/riYPwv4C1uMj3FQkfhE102pk8+lGuita+KvOMA0NbR9K5eiJOj1h2iDkCSuJImpz0kbp+gQ/5H1T2Qf0DvVjvDHZsiQfXaFmDKZ5TIcm/7FtEqO3XhxjkBume4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699269040; c=relaxed/simple; bh=6gG8m3T867ETWTnuhwaLBUN8YzbBigams/T+GRLY1Jw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=oQ6Sc0hsrPDDD4lrzC9Wntib2Z/BNqT+P3HcvMfqUkI9YeTfDHS5bs/uQKOK73fZR/iz+0MGksY7NyoXcDG6T3hju51HeE+Jkx1B7PAPNuP2+oYiwsyzqvgcJfUpBrg3g3xaAIToqZdkiB2+SLcR+cBLrr7UjWkcnrUPjnasl7Y= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+358fOzhvK3g6lZUpHbV/P3LDsq7da0YOmR6tXDvlJTHMQm/UppvqSLwJb1f8T5Gr0eCdPzQOmPnmJpCY7r9rvt1D6TGtuUdI46riBDK13fxQppJK2WwCfNmA4LKY/OwhSWgFvaRSpa4avNP51OKX75Vgr+YksH0PNho/9AhgZp8MCCHqKTPsQ3VvWn02Lew4QhXfKtjK6ghfUrDeRmflD6evZ2h1iEWQSe+bIYznjTXOc5Bilm5ubOVZ8O25e3mS8z3W/BBj9H0+EvmZZmlMGppu8nYjclEDOyfdNvCgzoLowZn3kMsmsurrBxrMRNmLEFdbRB8vr8mg4amgnUog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6gG8m3T867ETWTnuhwaLBUN8YzbBigams/T+GRLY1Jw=; b=YR9gFO9e/boieoRMYvcdE/a4m7y3zdVnmuqE9f4/XdsSqNeMHlq+LFH2mnjYsC39hXIppk/BdrblmifzuELGbZEMFoJrWjtb2GIgqDEPNwsJu3Cuqpvpkf9cFP4ozTWzgqT5L1irtEGob/r+3QfrVvr/+LM09Ier/Gz6rCK/o0nrOzZkal40Hv3BciaH9wKcogoqMakGzlOf5IO6egm07pChdHw3gWwZJyNw3hDXhoi5hi2bF6Vqo2qaeXOVg90edgcL8OdUG02Q3wlaZ1K4b4/kR9ifxQkNV6KQJjxacPuzhoLAxE9Q+CYPgoDdfgJIFzWYj4Hr5o2OI0F6MndsLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gG8m3T867ETWTnuhwaLBUN8YzbBigams/T+GRLY1Jw=; b=b+uW4B2WbrM94kTPhtWqDElMDQIAlMbsWmWdQPTskwv5S1jjR7tgtkiSNKxI5QU/t2XzQaN+Np9Ryr09UgSqOcacubjd/wVgLqMf1/VLoxNzIQPtnN7xFaXni7gqphc4xihiLjq8GsUtY7OD29Ds4f3rYNTBkdUyDAMxV8n3aCsZZY+vduMWGue+SLeSuA6oFyfO/D8q77YKdT2XsOlW8fmLTb/tws9PmVacZnufvQDEqBYGidVUhT/QsuSUCFS4G9kKYno9zLxitpJT3RxCV3t4HeAHpMJWsYmss96dXmWf4UD/ZAA/ya4w54ok+0DfTMG4IPiOeJRgvKMWQtHH0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8185.eurprd04.prod.outlook.com (2603:10a6:10:240::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.16; Mon, 6 Nov 2023 11:10:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.6977.016; Mon, 6 Nov 2023 11:10:36 +0000 Message-ID: <54cd054c-003a-fee7-bfbc-3246058ae2b7@suse.com> Date: Mon, 6 Nov 2023 12:10:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 5/5] x86: yet more PR target/100711-like splitting Content-Language: en-US To: Hongtao Liu Cc: "gcc-patches@gcc.gnu.org" , Hongtao Liu , Kirill Yukhin References: <04f99abe-a563-d093-23b7-4abf0f91633d@suse.com> <0075f542-9dc0-33db-4cf9-cdd3ba502122@suse.com> <460e0857-2ee9-d946-4067-9569fa767420@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8185:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fb78c31-8a82-434b-eb46-08dbdeb900a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GL9nvNKFcyVtTVkwI/M8zsMwOQsznUyJMTcRINKIhXkSCVSMNhQc0njnBuU3qSgqfcIeveerVARuu+vWM1GPVYJcPnkD4Dhic/7TggcqLrD5/4Gt75EDnp1JZ6tDRJDSvg6VjwuVptvXd2l8SAjnQiycCMzGrck7suDxdazpPEH+eSWd22Sb+/gh3XlLnbX8dqzqscBIWb/A/jeKNW+jNP09KHPWjpB7Ioa0PEEf779VLaAh5zsYa65I25l2jRhB62IDfIIrcw1VoHOF2gVFBqPqGdRJ8fujOeKEqzQddM66i8Tz1OGbFwhuMVkdooYwaohaoPUMgkwSxmJiVzNrgdIf6r018vap6dS1vjUO1c9oWF+7wvfnN3HzSbtNEZZJ52fA6MbbfP66dXpQAiVEmLAfg6bOgeheDXawLxt3V3CoMT+WSi+7wrpEBdHLcOqRSE74mw7AR0LZ6qb5VwL8q6PhWMGr0GzOI2Uf1oNt1H/79ad6SOVOZbKrAAz/LzGo7qKG4mESZGnoknrHagFoTBbySiI6b+0piYTVwtTNdLMTkseyQIwcDGb2MNSHvMq2s45S4H6wsUniK6pyC75MvW4/hUE/51fpVCOYpEmlF7s1YvNAktgqXgf6W9WHovIZ/qpl0es8y1nQgbe8MQiS+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(366004)(136003)(376002)(39860400002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(8936002)(8676002)(4326008)(6486002)(478600001)(2906002)(31686004)(5660300002)(41300700001)(66946007)(66476007)(66556008)(54906003)(86362001)(2616005)(26005)(6506007)(6512007)(36756003)(53546011)(316002)(83380400001)(6916009)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K09KMjNUbitBL3k1Wk5DWndqMDBuOUtOVExDbncwNzhBMHhtNzZ2cUNJUDBn?= =?utf-8?B?cFdKc1VxQldseFZRczcwWFhDZzZOK2JGSUVtK2I4bThUWldNM2M1blZJS3p0?= =?utf-8?B?WmZXRmVndEQ3TE11WE03bTdWVFdCWEVaM1JwU0N1YjlJY0xHdzBkL084Y2Vy?= =?utf-8?B?Y3hjR2NzUTd3RERyT3BhUXQ3OWo5QVdJTklZNVBIUnEvVmE0dmZ5R0trWWs1?= =?utf-8?B?RnFlc2tWRUd4WlJ5dEwyY2JQK28xVVZLS3kxZDZBL0F4VDd6bXBwbUdiNENx?= =?utf-8?B?R0ZEc2RUNHB2NytKRURHZTFNaGlQbWh6R1ZJVmVqMVN1U25uZHJJY2lOZVJs?= =?utf-8?B?RVlTbG5JWlh3RSt0bEEyVFV6eTJ3VE1EQk9xK2pxWk5paVpSdERNbjJiWWtj?= =?utf-8?B?a2UxbXNCZVFLWVJaUjlVMTEyTEd6aFhJQnhaOElvdHVjQmRKZGNHZVV2L3Rh?= =?utf-8?B?TUhtUVFLNlRkdkd6VElYNjdVdlhsWkpodmlLVVNxWXBqd25SWFEvZS9wNHNK?= =?utf-8?B?Y1dweTcrNnJEYnI4WHpFYnFhcW1Pc2pwSG92Rk1xWkFBWDFDeFFFNnVTZS9r?= =?utf-8?B?VFV0T29vUU5SeDNDSFJ5dlIzOWZzQmJLdzR3ZUNnQWVKQXQ5M2hXVjA5WXNF?= =?utf-8?B?ZDB5dC9hcnYxclVXcW1FWDZ0dUlmUENTWC9ST2FZajZtQlhRWks0OTROOGUr?= =?utf-8?B?QlFHMFM5ekxvV0tYN1UrOCtlSHNUK1VvOUthazlYZDBNakVlV0tkQnNiMkJB?= =?utf-8?B?cXJsRytXQXp3VUZlQjYraGpUOWJHS2xySTMzajlkOHNjY29HdUtLVXRhOER4?= =?utf-8?B?WFdnS1plcngvSktIWUw5bWZydW1PanovSmNibkVZWHRXUS8zZzU2SzhTNXRz?= =?utf-8?B?clNJWVpGT3AzQlE0UXB2b1JJTUJpK1daVFdMZkwxNmtnV0JlYVhETTNEekhS?= =?utf-8?B?dTZlaGpyOTFkemNNNEVUdUNzUnErUk9JWCt5d3VRQmZWR0F0NTRwVnRLeElx?= =?utf-8?B?QWZGN2ZYdHJzQ2ZwMTV3dU40Qm1VRktCQTJTNTZJZFQzOTJtaHdxeld5b0Za?= =?utf-8?B?M1dOVFFYT1dwK3VsZDhONXl1RTVObHVmMUlCUmRieWd5YlhqY3hHcE1VTVVC?= =?utf-8?B?eUpUZGFDRDR3K2xEZUhXSjBESHJ2YkJYOGxlQ2N2by9qNGxlb3lnMzRSN3o5?= =?utf-8?B?a0d6RGRORktjNys2bXVuZGpzZEZ0U3kwemxqVDdXeFR2cml2VGVFd2lnWEtj?= =?utf-8?B?eXoxTDRUbk1TYzJVa1IvV3hHQnVLOUIxbUtqTWRPL3NxS3B2ckxWenlJZkV0?= =?utf-8?B?M2hwZjk2dURSRE5hMlRBTEI3T2tCTFhTNCtrRXBIWkxWTVZoR2FsT05sbkg0?= =?utf-8?B?Z0ZWTEUyY2NiMFNFWkpUUUdlZnU5TzN6citTV09hRk9JUWF6VWpLcVN0VC91?= =?utf-8?B?c0IvclNOck16MFU0dGdEOTFNNklIS2I3TEgvTUlZMnl4bUJGWDloMVZvSFlk?= =?utf-8?B?bnlMaEJLV2Z5ZXgrZHBMeXlTTk8wRDBsVG5XYjZwQWRtRUpLMC92MFZRblRE?= =?utf-8?B?akk3VnVoV3plMGlTdnlxR3JvcXA3TFUvVVFkblY3TUh2UWMxR1NHT3ZUa1gw?= =?utf-8?B?R2ZiSERoNktZaGcrVlhhOXpaRE0vL1JRWWVPbXpON1ZKTldaOHB3SVBxMzRU?= =?utf-8?B?eEJ3QnYzZkk3Uk4vZ0hkRnhPaDRHWWVJcU02aVVBclI3K2Y2YnJJRUpJdktt?= =?utf-8?B?ejhjdUxYb0IzaTlhYnhndTc2end5MnhpOGRrZGtzK1hXRVJzdGE3WXdJSzQ1?= =?utf-8?B?KzlUSFdxZjNIalhhWFA4RDE0bWRMcU8zN0ZpRU56QjRuRXAwSWhOUlB0WHgr?= =?utf-8?B?ZjY4dW5PMFcyNDhreWpIYUtHT0s5ZjRjK3ZyVHREVC9JYXpZNlY3ckIxaUlj?= =?utf-8?B?a0srRmk4dXF5M21uSHkwVUZXNjRERjJkclZxZjdUVFkzSmFZaWcvRjF5RUNC?= =?utf-8?B?R1d6eGRLeHlSRHpjdmVSQVAxQ0xzUVplVHFOdHA5d1BOTHZjMTJjTG1lbUxt?= =?utf-8?B?WFRFTCttdFBXQnhaaGJuRjhTblBRV01jUXg1YXhFUmNVeC9pSUp4ZW5UemtD?= =?utf-8?Q?4fm6yWayiWNYTNsIWY6uoaxUw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb78c31-8a82-434b-eb46-08dbdeb900a4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 11:10:36.6007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eBkW4Rq09u1m18YvQvqqiJWzaCowswF07GcVpmOZPKnyyaawbxs+d4WUTV6+c7EdIeTR8D1KrDEOaPgmYe0ltQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8185 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.06.2023 08:41, Hongtao Liu wrote: > On Sun, Jun 25, 2023 at 2:35 PM Hongtao Liu wrote: >> >> On Sun, Jun 25, 2023 at 2:25 PM Jan Beulich wrote: >>> >>> On 25.06.2023 07:12, Hongtao Liu wrote: >>>> On Wed, Jun 21, 2023 at 2:29 PM Jan Beulich via Gcc-patches >>>> wrote: >>>>> >>>>> --- >>>>> For the purpose here (and elsewhere) bcst_vector_operand() (really: >>>>> bcst_mem_operand()) isn't permissive enough: We'd want it to allow >>>>> 128-bit and 256-bit types as well irrespective of AVX512VL being >>>>> enabled. This would likely require a new predicate >>>>> (bcst_intvec_operand()?) and a new constraint (BR? Bi?). (Yet for name >>>>> selection it will want considering that this is applicable to certain >>>>> non-calculational FP operations as well.) >>>> I think so. >>> >>> Any preference towards predicate and constraint naming? >> something like bcst_mem_operand_$suffiix, $suffix indicates the >> pattern may use zmm instruction for 128/256-bit operand. >> maybe just bcst_mem_operand_zmm? > For constraint, maybe we can reuse Br, relax Br to match bcst_mem_operand_zmm. > For those original patterns with bcst_mem_operand, it should be ok > since it's already guarded by the predicate, the constraint must be > valid. Hmm, I wanted to get back to this, but then I started wondering about this reply of yours vs your request to not go farther with the use of "oversized" insns (i.e. acting in 512-bit registers in lieu of AVX512VL being enabled, when no FP exceptions can be raised on the otherwise unused elements). Since iirc the latter came later, am I right in assuming we then also shouldn't go the route outlined above? Jan