From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 02C7A383D83F for ; Thu, 12 Aug 2021 16:17:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02C7A383D83F Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17CG43Dq149486; Thu, 12 Aug 2021 12:17:35 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 3ad3k3y2uh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Aug 2021 12:17:35 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17CG7WJP013374; Thu, 12 Aug 2021 16:17:34 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma02wdc.us.ibm.com with ESMTP id 3aapjcp5y6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Aug 2021 16:17:34 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17CGHYOS36176166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Aug 2021 16:17:34 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E0E911206B; Thu, 12 Aug 2021 16:17:34 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C174C112067; Thu, 12 Aug 2021 16:17:33 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.134.29]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 12 Aug 2021 16:17:33 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 47/55] rs6000: Builtin expansion, part 4 To: Segher Boessenkool , will schmidt Cc: gcc-patches@gcc.gnu.org References: <1f28ba77c244256484e000eab60d041181612ff4.1623941442.git.wschmidt@linux.ibm.com> <3b98c985191f7d3d0be8ab19e6580887991c4d74.camel@vnet.ibm.com> <20210804003418.GY1583@gate.crashing.org> From: Bill Schmidt Message-ID: <54e06fc2-9436-3595-3562-d9056f511d39@linux.ibm.com> Date: Thu, 12 Aug 2021 11:17:33 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210804003418.GY1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Kg1IRyv9MS0DCkwtA1w9gp-t41mzcPe8 X-Proofpoint-GUID: Kg1IRyv9MS0DCkwtA1w9gp-t41mzcPe8 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-12_05:2021-08-12, 2021-08-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 mlxlogscore=729 spamscore=0 clxscore=1015 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108120104 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 16:17:37 -0000 Hi Segher, On 8/3/21 7:34 PM, Segher Boessenkool wrote: > Whoops, I forgot some stuff: > > On Tue, Jul 27, 2021 at 04:06:49PM -0500, will schmidt wrote: >> On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote: >>> static rtx >>> ldv_expand_builtin (rtx target, insn_code icode, rtx *op, machine_mode tmode) >>> { >>> + rtx pat, addr; >>> + bool blk = (icode == CODE_FOR_altivec_lvlx >>> + || icode == CODE_FOR_altivec_lvlxl >>> + || icode == CODE_FOR_altivec_lvrx >>> + || icode == CODE_FOR_altivec_lvrxl); >>> + >>> + if (target == 0 >>> + || GET_MODE (target) != tmode >>> + || ! (*insn_data[icode].operand[0].predicate) (target, tmode)) >> No space after "!" ? (here and later on 'pat'.). > It can be written as just > || !insn_data[icode].operand[0].predicate (target, tmode)) > even. The * is completely optional, and you don't need the extra parens > without it. Agreed.  This is copied from an idiom that exists throughout the file, so I plan to handle this by adding a style patch to clean it up everywhere. Bill > > > Segher