From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s01.bc.larksuite.com (s01.bc.larksuite.com [209.127.230.11]) by sourceware.org (Postfix) with UTF8SMTPS id 699A43858D32 for ; Tue, 14 Mar 2023 05:47:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 699A43858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=oss-cipunited-com.20200927.dkim.feishu.cn; t=1678772819; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=/7fT+v8stLRqe96jx8yM+gDNwg1YF4f1WMLfq+DRdcA=; b=qYj+vbuTLeeME+b3gNlbLE0cW8ucsBv3fNMbyFyS49G5N9YstQb59cDWudcIIL4VaP62OS T3NYcXn+ijAWkyvVbDELkQOvTAlvJcc8L2MpnUa8S3lw0iy+WwMseSZ+opyWKq5FSxv+92 9Q7xkVOst2xJ8H9gE2BDHHUZsG0uk9csWuop5ORCC9ToHOYSIeyfxY0P2BwY5cMqmncAfk lJMSD08+d42RTINAtT7fM00KXm4ioDm+viE9pzr1pnUXL2FhtEZCjn35Y3x7uJ+cQWa5qT Yp5IQHSv3peCDyX+g0yrodQfKZnQzMEpmGWE3/kAI2wSTMTN/Xk+lfZEaFRuyQ== Content-Type: multipart/alternative; boundary=76519e62615c0e2f103d606db0275032c41bd42ab88b41bcc71610b80990 Subject: Re: [PATCH] Testsuite: Disable micromips for MSA tests Mime-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Date: Tue, 14 Mar 2023 13:46:49 +0800 In-Reply-To: <444a2cf7-c3a9-255e-63eb-12ccd8f06df0@gmail.com> Message-Id: <54e9b34f-06e3-f184-96d5-52b137d1433c@oss.cipunited.com> To: "Jeff Law" , Cc: "Matthew Fortune" From: "Xin Liu" References: <20230221023857.211542-1-xin.liu@oss.cipunited.com> <444a2cf7-c3a9-255e-63eb-12ccd8f06df0@gmail.com> X-Lms-Return-Path: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,HTML_NONELEMENT_30_40,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --76519e62615c0e2f103d606db0275032c41bd42ab88b41bcc71610b80990 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Thanks for your feedback. You're right that MicroMIPS doesn't support=20 MSA, so disabling micromips for MSA tests is a reasonable change. I'll make sure to include a ChangeLog entry with a clear description of=20 future patches. Thanks for the suggestions, and I'll strive to improve=20 my work based on your feedback. On 2023/3/11 23:42, Jeff Law wrote: > > > On 2/20/23 19:39, Xin Liu wrote: >> From: Matthew Fortune >> >> --- >> =C2=A0 gcc/testsuite/gcc.target/mips/mips.exp | 1 + >> =C2=A0 1 file changed, 1 insertion(+) > Unfortunately, you haven't given anyone any background that would=20 > allow them to evaluate/review this patch. > > I'm guessing that MSA does not support micromips, is that correct? > > And for the future, please include a ChangeLog entry with patches.=C2=A0 = A=20 > ChangeLog entry describes what changed, not why something changes.=C2=A0 = A=20 > reasonable ChangeLog for this patch might be: > > gcc/testsuite: > =C2=A0=C2=A0=C2=A0=C2=A0* gcc.target/mips/mips.exp (mips-dg-options): Dis= able micromips > =C2=A0=C2=A0=C2=A0=C2=A0for MSA tests. > > Jeff= --76519e62615c0e2f103d606db0275032c41bd42ab88b41bcc71610b80990--