Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512]

[Jason Merrill <jason@redhat.com>]

On 11/17/23 09:50, Alex Coplan wrote:
> Hi,
> 
> This is a v5 patch to address Marek's feedback here:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html
> 
> I also implemented Jason's suggestion to use constexpr for the tables
> from this review:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634484.html
> 
> I'll attach the incremental change in reply to Marek's review to make
> things easier to compare.
> 
> Bootstrapped/regtested on aarch64-linux-gnu.  Bootstrap/regtest on
> x86_64-apple-darwin in progress (on top of this libsanitizer fix:
> https://github.com/llvm/llvm-project/issues/72639).
> 
> OK for trunk if testing passes?

> --- a/gcc/c-family/c-common.h
> +/* Implemented in c/c-objc-common.cc.  */
> +extern void c_register_features ();

I think this declaration should go in c-objc-common.h, though the C 
maintainers might prefer c-lang.h or c-tree.h.

> +/* Implemented in cp/cp-objcp-common.cc.  */
> +extern void cp_register_features ();

And this one in cp-objc-common.h.

With that change the patch is OK on Friday if Marek doesn't have any 
other notes.

Thanks,
Jason