From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BA6763858D37 for ; Mon, 20 Nov 2023 22:30:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA6763858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA6763858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700519403; cv=none; b=M+2bDiO7xfauaFjgzC1fUs2/3EAqilLeZSkPzWHkGXTDfc0cDYhWX/wTWgQ/39Bdeh1+mYMVXFM4iBraM6BXls1bBggGjm4oKerJv0sMmEcufF035QrTsWbSATSJrMqCpJH0Obu9VvHMHw1xg0Go1JG6c2y8Rolrv+gx8+qhZss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700519403; c=relaxed/simple; bh=iuu4iwNuDPXG643bZPbSmjpa3RqNAKgAMqK15HIAdPA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=C+l/GxnPD17lnIeTrZzaWwIsCGYOjI9Xw26TBIizgSdFe7QbBBjGIAKB/7LPf+aosVnkAF/zLuee24+pOc/2VER3cGgG7LddUHZ6DCUfjWnDjON4+xwpvsdSYSOcSBd+nNaqW6tDK00Zr0zelxSCEXdopGM/EVfBhQO75TgHwtY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700519401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gDDvYjeGeNOGWp+xSWjUAYONHn0lIDRJfBL3bAo0Lws=; b=hTxEtgGEg27IRs1kv2Ab+vog4pJ+IpmXFtSJ6UDpAzPDMwXl4iUvT9f26ajACDJrl1H5IX EgXXGgeuXk4GN6caatMVuQ13C/YFPlCd7qQ/+ONBxsJcLWgL71qrySaF0HK6+llwfin3ni lWELxDGq9xQuMNkmWPPcAmV5Bx88Ohc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-Nbdz94A_N5aRHuEfj1WmpA-1; Mon, 20 Nov 2023 17:29:59 -0500 X-MC-Unique: Nbdz94A_N5aRHuEfj1WmpA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-677fb25cfe5so30183786d6.3 for ; Mon, 20 Nov 2023 14:29:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700519399; x=1701124199; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gDDvYjeGeNOGWp+xSWjUAYONHn0lIDRJfBL3bAo0Lws=; b=P0ASNUEt0CwKmLL+nKZsPt0ZdsoMKLMV//8SyiepY400Tnm4a49oUYXGGV32IJRD8c jRJbtAB6zcXQsMsZUDktAs1oZbwuhAf4UVRaNExkAqMfgNgWfnG71fWzboHtIBpF1wFu fabsOqtF8O6tgz4sfrrOK5TXF0qFIge5EgxTqOVxlbRyHJ4mFIj4EMpW8npljQ+hA11j DwBUFd5MsuO+yDX1g7c3yaqKJjA9teVKbUrFQWFvnUAESQte4iznmKWIwOpznnBbupGb DAb1WJ7Z47ljz9xrs5EJ3DZ4VNUBrOb3nntVCwa2qXYKYhkL/7Lr/ffEJnroh6Dtnv5j pPmw== X-Gm-Message-State: AOJu0Yy3vVhrncGaqUHr2mcLx8dKCsNxzYDv0GiRY/zFLmfoV53ie0Wy 0sQJkOxao6ex2PpBby6eN4KBPaMT2flqCKTVtp6/xTGieh+IgKqPRiFJb5q/34Bt+vh/COod+fN Y6+gKb3m9ONl6j01zMA== X-Received: by 2002:a05:6214:e8e:b0:679:e795:b701 with SMTP id hf14-20020a0562140e8e00b00679e795b701mr2117272qvb.4.1700519399528; Mon, 20 Nov 2023 14:29:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6M82E5+Ur9eb0cHVjXdfrgWFzkiBG2Y5SuDPWA/0hEAmGAdErgOGOq5iuvPTVq3QJ1kBlnQ== X-Received: by 2002:a05:6214:e8e:b0:679:e795:b701 with SMTP id hf14-20020a0562140e8e00b00679e795b701mr2117257qvb.4.1700519399273; Mon, 20 Nov 2023 14:29:59 -0800 (PST) Received: from [192.168.1.145] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id mx1-20020a0562142e0100b0065b17ec4b49sm3303311qvb.46.2023.11.20.14.29.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 14:29:58 -0800 (PST) Message-ID: <54f7dafb-e8cf-4282-a042-a4abcba6494f@redhat.com> Date: Mon, 20 Nov 2023 17:29:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512] To: Alex Coplan , gcc-patches@gcc.gnu.org Cc: Marek Polacek , Nathan Sidwell , Joseph Myers , Iain Sandoe References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/17/23 09:50, Alex Coplan wrote: > Hi, > > This is a v5 patch to address Marek's feedback here: > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html > > I also implemented Jason's suggestion to use constexpr for the tables > from this review: > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634484.html > > I'll attach the incremental change in reply to Marek's review to make > things easier to compare. > > Bootstrapped/regtested on aarch64-linux-gnu. Bootstrap/regtest on > x86_64-apple-darwin in progress (on top of this libsanitizer fix: > https://github.com/llvm/llvm-project/issues/72639). > > OK for trunk if testing passes? > --- a/gcc/c-family/c-common.h > +/* Implemented in c/c-objc-common.cc. */ > +extern void c_register_features (); I think this declaration should go in c-objc-common.h, though the C maintainers might prefer c-lang.h or c-tree.h. > +/* Implemented in cp/cp-objcp-common.cc. */ > +extern void cp_register_features (); And this one in cp-objc-common.h. With that change the patch is OK on Friday if Marek doesn't have any other notes. Thanks, Jason