From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] PR 65323
Date: Wed, 11 Mar 2015 20:26:00 -0000 [thread overview]
Message-ID: <5500A4F4.5030308@redhat.com> (raw)
In-Reply-To: <54F9671B.1040002@oracle.com>
On 03/06/2015 03:36 AM, Paolo Carlini wrote:
> this is a regression about duplicate warnings with
> -Wzero-as-null-pointer-constant. The regression is rather old, affects
> 4_8-branch too, and started when check_default_argument got a
> perform_implicit_conversion_flags call which warns a first time, then
> maybe_warn_zero_as_null_pointer_constant as called by
> check_default_argument itself warns a second time. The latter call is
> even older, dates back to c++/52718, I think we can now safely remove it
> and keep on returning nullptr_node to avoid warning later still at the
> call sites (that was the point of c++/52718). Tested x86_64-linux.
Do we need this special handling at all? When I remove that whole 'if'
block I still only get one warning from the 52718 testcase.
Jason
next prev parent reply other threads:[~2015-03-11 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 8:37 Paolo Carlini
2015-03-06 10:07 ` Paolo Carlini
2015-03-11 20:26 ` Jason Merrill [this message]
2015-03-12 12:18 ` Paolo Carlini
2015-03-12 16:59 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5500A4F4.5030308@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).