From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14721 invoked by alias); 12 Mar 2015 11:44:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14683 invoked by uid 89); 12 Mar 2015 11:44:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Mar 2015 11:44:52 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Thu, 12 Mar 2015 11:44:48 +0000 Received: from [10.2.207.50] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 12 Mar 2015 11:44:47 +0000 Message-ID: <55017C2F.6080302@arm.com> Date: Thu, 12 Mar 2015 11:44:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jiangjiji , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , "Yangfei (Felix)" Subject: Re: [PING^2] [PATCH] [AArch64, NEON] Improve vmulX intrinsics References: In-Reply-To: X-MC-Unique: 115031211444801601 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00666.txt.bz2 Hi Jiangjiji, This is definitely stage 1 material by now... At my glance it all looks like the right approach, I have a question below: On 12/03/15 09:20, Jiangjiji wrote: > + > +(define_insn "aarch64_fmulx_lane" > + [(set (match_operand:VDQF 0 "register_operand" "=3Dw") > + (unspec:VDQF [(match_operand:VDQF 1 "register_operand" "w") > + (match_operand: 2 "register_operand" "w") > + (match_operand:SI 3 "immediate_operand" "i")] > + UNSPEC_FMULX_LANE))] > + "TARGET_SIMD" > + "fmulx\\t%0., %1., %2." > + [(set_attr "type" "neon_mul_s")] > +) Where did operand 3 go? Shouldn't his be the lane-element variant of fmulx? Thanks, Kyrill