From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120308 invoked by alias); 21 Mar 2015 00:11:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120297 invoked by uid 89); 21 Mar 2015 00:11:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 21 Mar 2015 00:11:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2L0Bj4P025158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 20 Mar 2015 20:11:45 -0400 Received: from reynosa.quesejoda.com (vpn-55-118.rdu2.redhat.com [10.10.55.118]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2L0BiCD004149; Fri, 20 Mar 2015 20:11:45 -0400 Message-ID: <550CB740.6040305@redhat.com> Date: Sat, 21 Mar 2015 00:11:00 -0000 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jason Merrill CC: gcc-patches Subject: Re: [debug-early] Handle specification of class scoped static functions References: <550C5F3A.1030802@redhat.com> <550C8F4C.1020003@redhat.com> In-Reply-To: <550C8F4C.1020003@redhat.com> Content-Type: multipart/mixed; boundary="------------010308020307020404020008" X-SW-Source: 2015-03/txt/msg01125.txt.bz2 This is a multi-part message in MIME format. --------------010308020307020404020008 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 633 On 03/20/2015 02:21 PM, Jason Merrill wrote: > I think we want to drop the debug_early check there entirely; the added > conditions seem to be gutting it. If is_cu_die (old_die->die_parent) is > false, then class_or_namespace_scope_p (old_die->die_parent) ought to be > true. > > Jason > Good catch. I am so glad you are keeping track of all this spaghetti, but in my defense, it was pasta already. With the attached I also got rid of one superfluous check for `old_die', as well as your suggestion. We get rid of one more gdb regression. Yay. I'll wait for your high-five (or OK) before committing to branch. Thanks. Aldy --------------010308020307020404020008 Content-Type: text/plain; charset=UTF-8; name="curr" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="curr" Content-length: 2416 Y29tbWl0IGIzZDkxMDcxM2QyN2RjMjk4MDFmM2RkYmU4NjcxYTRhNmUwZGU0 YzEKQXV0aG9yOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4K RGF0ZTogICBGcmkgTWFyIDIwIDA5OjU1OjMxIDIwMTUgLTA3MDAKCiAgICBI YW5kbGUgc3BlY2lmaWNhdGlvbiBvZiBjbGFzcyBzY29wZWQgc3RhdGljIGZ1 bmN0aW9ucy4KICAgIAogICAgUmVtb3ZlIHN1cGVyZmx1b3VzIGNoZWNrIGZv ciBvbGRfZGllLgoKZGlmZiAtLWdpdCBhL2djYy9kd2FyZjJvdXQuYyBiL2dj Yy9kd2FyZjJvdXQuYwppbmRleCA4ODg0YWZkLi43YTUyZGM4IDEwMDY0NAot LS0gYS9nY2MvZHdhcmYyb3V0LmMKKysrIGIvZ2NjL2R3YXJmMm91dC5jCkBA IC0xODczNSw3ICsxODczNSw3IEBAIGdlbl9zdWJwcm9ncmFtX2RpZSAodHJl ZSBkZWNsLCBkd19kaWVfcmVmIGNvbnRleHRfZGllKQogICAgICBtdWNoIGFz IHBvc3NpYmxlLiAgKi8KICAgZWxzZSBpZiAob2xkX2RpZSkKICAgICB7Ci0g ICAgICBkdW1wZWRfZWFybHkgPSBvbGRfZGllICYmIG9sZF9kaWUtPmR1bXBl ZF9lYXJseTsKKyAgICAgIGR1bXBlZF9lYXJseSA9IG9sZF9kaWUtPmR1bXBl ZF9lYXJseTsKIAogICAgICAgLyogQSBkZWNsYXJhdGlvbiB0aGF0IGhhcyBi ZWVuIHByZXZpb3VzbHkgZHVtcGVkIG5lZWRzIG5vCiAJIGFkZGl0aW9uYWwg aW5mb3JtYXRpb24uICAqLwpAQCAtMTg3NjgsMTMgKzE4NzY4LDIzIEBAIGdl bl9zdWJwcm9ncmFtX2RpZSAodHJlZSBkZWNsLCBkd19kaWVfcmVmIGNvbnRl eHRfZGllKQogCSBhcHBseTsgd2UganVzdCB1c2UgdGhlIG9sZCBESUUuICAq LwogICAgICAgZXhwYW5kZWRfbG9jYXRpb24gcyA9IGV4cGFuZF9sb2NhdGlv biAoREVDTF9TT1VSQ0VfTE9DQVRJT04gKGRlY2wpKTsKICAgICAgIHN0cnVj dCBkd2FyZl9maWxlX2RhdGEgKiBmaWxlX2luZGV4ID0gbG9va3VwX2ZpbGVu YW1lIChzLmZpbGUpOwotICAgICAgaWYgKCgoaXNfY3VfZGllIChvbGRfZGll LT5kaWVfcGFyZW50KQotCSAgICB8fCBjb250ZXh0X2RpZSA9PSBOVUxMCi0J ICAgIHx8IGR1bXBlZF9lYXJseSkKKyAgICAgIGlmICgoaXNfY3VfZGllIChv bGRfZGllLT5kaWVfcGFyZW50KQorCSAgIHx8IGNvbnRleHRfZGllID09IE5V TEwKKwkgICAvKiBGb3IgY2xhc3Mgc2NvcGVkIHN0YXRpYyBmdW5jdGlvbnMs IHRoZSBkdW1wZWQgZWFybHkKKwkgICAgICB2ZXJzaW9uIHdhcyB0aGUgZGVj bGFyYXRpb24sIHdoZXJlYXMgdGhlIG5leHQgdGltZQorCSAgICAgIGFyb3Vu ZCB3aXRoIGEgZGlmZmVyZW50IGNvbnRleHQgc2hvdWxkIGJlIHRoZQorCSAg ICAgIHNwZWNpZmljYXRpb24uICBJbiB0aGlzIGNhc2UsIGF2b2lkIHJldXNp bmcgdGhlIERJRSwgYnV0CisJICAgICAgZ2VuZXJhdGUgYSBzcGVjaWZpY2F0 aW9uIGJlbG93LiBFLmcuOgorCisJICAgICAgY2xhc3MgQyB7CisJICAgICAg cHVibGljOgorCSAgICAgICAgc3RhdGljIHZvaWQgbW9vICgpIHt9CisJICAg ICAgfTsgICovCisJICAgfHwgIWlzX2N1X2RpZSAoY29udGV4dF9kaWUpKQog CSAgICYmIChERUNMX0FSVElGSUNJQUwgKGRlY2wpCiAJICAgICAgIHx8IChn ZXRfQVRfZmlsZSAob2xkX2RpZSwgRFdfQVRfZGVjbF9maWxlKSA9PSBmaWxl X2luZGV4CiAJCSAgICYmIChnZXRfQVRfdW5zaWduZWQgKG9sZF9kaWUsIERX X0FUX2RlY2xfbGluZSkKLQkJICAgICAgID09ICh1bnNpZ25lZCkgcy5saW5l KSkpKSkKKwkJICAgICAgID09ICh1bnNpZ25lZCkgcy5saW5lKSkpKQogCXsK IAkgIHN1YnJfZGllID0gb2xkX2RpZTsKIAo= --------------010308020307020404020008--