Re: [PATCH] pr 63354 - gcc -pg -mprofile-kernel creates unused stack frames on leaf functions on ppc64le

[Martin Sebor <msebor@redhat.com>]

On 03/21/2015 01:48 PM, Iain Sandoe wrote:
> Hi Martin,
>
> I've applied your latest patch to top of trunk and looked at the code gen on powerpc-darwin9 (and a cross from x86-64-darwin12 => powerpc64-linux-gnu).

Thanks for the review!

>>>> 2015-03-13  Anton Blanchard  <anton@samba.org>
>>>>
>>>> 	PR target/63354
>>>> 	* gcc/config/rs6000/linux64.h (ARGET_KEEP_LEAF_WHEN_PROFILED): Define.
>>>                                         ^ typo

It's fixed in version 2 of the patch posted here:
https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00793.html

>
> This ^ will cause a bootstrap fail for every rs6000 target that doesn't include linux64.h.
> (because rs6000_keep_leaf_when_profiled will be "defined but unused").
>
> Since ISTM you intend this to apply to all rs6000 sub-targets, you might as well move it to rs6000.h?

The powerpc-darwin9 and powerpc64-darwin9 targets both built
successfully with this patch. I also tried powerpc64-freebsd,
which succeeded as well (though I had to work around pr65535).
What target do you suggest I try to reproduce the failure?
(I don't mind moving the macro definition as you suggest,
but I'd like to understand how to trigger the problem so
that I can reproduce it and verify that I've fixed it.)

>>>> --- /dev/null
>>>> +++ b/gcc/testsuite/gcc.target/powerpc/pr63354.c
>>>> @@ -0,0 +1,10 @@
>>>> +/* { dg-do compile { target { powerpc*-*-* } } } */
...
> a bare register # will, indeed, fail for Darwin's native assembler (which expects r#).

Thanks. I don't have access to Darwin but I changed the target
in version 2 of the patch to powerpc64*-linux* to make the test
unsupported only on Linux but now that I've tried running it on
a non-linux target I see it fails with:

dg-process-target-1: `{target powerpc64*-linux*}'
ERROR: gcc.target/powerpc/pr63354.c: syntax error in target selector 
"target powerpc64*-linux*" for " dg-do 1 compile { target { 
powerpc64*-linux* } } "

Changing the target to powerpc64*-*-linux* eliminates the
error and results in an unsupported test as intended. I'll
post a new patch with the fix for this and with one linux64.h
problem you mentioned above once I reproduce it and verify
that the suggested solution fixes it.

Martin