From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-394021-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 106417 invoked by alias); 24 Mar 2015 17:47:03 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 106399 invoked by uid 89); 24 Mar 2015 17:47:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: service87.mimecast.com
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Mar 2015 17:47:02 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Tue, 24 Mar 2015 17:46:59 +0000
Received: from [10.2.207.65] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Tue, 24 Mar 2015 17:46:57 +0000
Message-ID: <5511A311.2090702@arm.com>
Date: Tue, 24 Mar 2015 17:47:00 -0000
From: Alan Lawrence <alan.lawrence@arm.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101213)
MIME-Version: 1.0
To: Alan Lawrence <alan.lawrence@arm.com>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,  Marcus Shawcroft <Marcus.Shawcroft@arm.com>, Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c
References: <5511862D.3010406@arm.com>
In-Reply-To: <5511862D.3010406@arm.com>
X-MC-Unique: 115032417465908701
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg01261.txt.bz2

Hmmm. This is not the right fix: the tests Richard fixed, were failing beca=
use
of lack of constant propagation and DCE at compile-time, which then didn't
eliminate the call to link_error. The AArch64 test is failing because this =
from
aarch64/constraints.md:

(define_constraint "S"
    "A constraint that matches an absolute symbolic address."
    (and (match_code "const,symbol_ref,label_ref")
         (match_test "aarch64_symbolic_address_p (op)")))

previously was seeing (and being satisfied by):

(const:DI (plus:DI (symbol_ref:DI ("test") [flags 0x3] <function_decl
0x7fb7c60300 test>)
          (const_int 4 [0x4])))

but following Richard's patch the constraint is evaluated only on:

(reg/f:DI 73 [ D.2670 ])


--Alan

Alan Lawrence wrote:
> Following Richard Biener's patch at=20
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01064.html (r221532),=20
> gcc.target/aarch64/c-output-template-3.c fails with:
>=20
> c-output-template-3.c: In function 'test':
> c-output-template-3.c:7:5: error: impossible constraint in 'asm'
>       __asm__ ("@ %c0" : : "S" (&test + 4));
>=20
> This patch fixes the test by changing options to -O in a similar manner t=
o=20
> Richard's fixes to gcc.dg/pr15347.c and c-c++-common/pr19807-1.c.
>=20
> Ok for trunk?
>=20
> Cheers, Alan
>=20
> gcc/testsuite/ChangeLog:
>=20
> 	gcc.target/aarch64/c-output-template.c: Add -O, remove
> 	-Wno-pointer-arith.