From: Alan Lawrence <alan.lawrence@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jonathan Wakely <jwakely@redhat.com>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: [Obvious] Fix libstdc++/33394 testcase when cross-testing linux
Date: Wed, 25 Mar 2015 15:49:00 -0000 [thread overview]
Message-ID: <5512D8F8.2080200@arm.com> (raw)
In-Reply-To: <20150324143900.GE9755@redhat.com>
When cross-testing, the -DITERATIONS=1000 flag replaced the -pthread required
for linux targets, so the test failed to build. I've pushed the following test
fix as r221666:
Index: libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc
===================================================================
--- libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc
(revision 221665)
+++ libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc (working
copy)
@@ -18,7 +18,7 @@
// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux*
*-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* } }
// { dg-options "-pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd*
*-*-linux* *-*-gnu* *-*-solaris* } }
-// { dg-options "-DITERATIONS=1000" { target simulator } }
+// { dg-additional-options "-DITERATIONS=1000" { target simulator } }
#ifndef ITERATIONS
#define ITERATIONS 50000
#endif
Jonathan Wakely wrote:
> Adding a testcase so the bug can be closed.
>
> I believe the segfault was fixed for 3.4.0 by
> https://gcc.gnu.org/r67912
>
> Tested x86_64-linux, committed to trunk.
next prev parent reply other threads:[~2015-03-25 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:39 [patch] libstdc++/33394 add testcase Jonathan Wakely
2015-03-25 15:49 ` Alan Lawrence [this message]
2015-03-25 16:23 ` [Obvious] Fix libstdc++/33394 testcase when cross-testing linux Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512D8F8.2080200@arm.com \
--to=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).