From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-394067-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 43544 invoked by alias); 25 Mar 2015 15:49:24 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 43507 invoked by uid 89); 25 Mar 2015 15:49:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: eu-smtp-delivery-143.mimecast.com
Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Mar 2015 15:49:19 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-23.uk.mimecast.lan; Wed, 25 Mar 2015 15:49:16 +0000
Received: from [10.2.207.65] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Wed, 25 Mar 2015 15:49:12 +0000
Message-ID: <5512D8F8.2080200@arm.com>
Date: Wed, 25 Mar 2015 15:49:00 -0000
From: Alan Lawrence <alan.lawrence@arm.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101213)
MIME-Version: 1.0
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
CC: Jonathan Wakely <jwakely@redhat.com>,  "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: [Obvious] Fix libstdc++/33394 testcase when cross-testing linux
References: <20150324143900.GE9755@redhat.com>
In-Reply-To: <20150324143900.GE9755@redhat.com>
X-MC-Unique: rgknz-PITE-4scoT_LlMWw-1
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg01307.txt.bz2

When cross-testing, the -DITERATIONS=3D1000 flag replaced the -pthread requ=
ired=20
for linux targets, so the test failed to build. I've pushed the following t=
est=20
fix as r221666:

Index: libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc=20
(revision 221665)
+++ libstdc++-v3/testsuite/21_strings/basic_string/pthread33394.cc      (wo=
rking=20
copy)
@@ -18,7 +18,7 @@
  // { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux=
*=20
*-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* } }
  // { dg-options "-pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbs=
d*=20
*-*-linux* *-*-gnu* *-*-solaris* } }

-// { dg-options "-DITERATIONS=3D1000" { target simulator } }
+// { dg-additional-options "-DITERATIONS=3D1000" { target simulator } }
  #ifndef ITERATIONS
  #define ITERATIONS 50000
  #endif

Jonathan Wakely wrote:
> Adding a testcase so the bug can be closed.
>=20
> I believe the segfault was fixed for 3.4.0 by
> https://gcc.gnu.org/r67912
>=20
> Tested x86_64-linux, committed to trunk.