From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: Yvan Roux <yvan.roux@linaro.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH, ARM] Fix arm_subsi3_insn alternatives
Date: Fri, 27 Mar 2015 18:14:00 -0000 [thread overview]
Message-ID: <55159E05.6050005@arm.com> (raw)
In-Reply-To: <CAD57uCe0qJmMo_3vv6bChKOV0nLw2OJUtZE2WTLEeUZzW_nEXQ@mail.gmail.com>
On 24/03/15 19:53, Yvan Roux wrote:
> Hi,
>
> after the issue with duplicated alternatives exhibited by PR64208, I
> checked the arm.md file and found that *arm_subsi3_insn has a
> duplication where alt 4 is (r,rI,r) and alt 6 is (r,r,r), this results
> in emitting an rsb instruction instead of a sub one, but it has also
> an impact on scheduling as the type attribute affected to alt 4 is
> alu_imm when it could only involve registers.
>
> This is fixed by this small patch. Cross builded and regtested for
> arm/armeb targets.
> Ok for trunk (maybe for stage 1 as no PR is attached to that) ?
Hi Yvan,
I've kicked off two bootstraps of this patch on arm-none-linux-gnueabihf:
one with arm mode and one with thumb. Both are well in stage3 so I don't
expect
there to be any problems and the patch looks ok to me code-wise (though
I can't approve).
This is stage 1 material by now though since there's no regression
associated.
Cheers,
Kyrill
>
> Cheers,
> Yvan
>
> 2105-03-24 Yvan Roux <yvan.roux@linaro.org>
>
> * config/arm/arm.md ("*arm_subsi3_insn"): Fixed redundant alternatives.
next prev parent reply other threads:[~2015-03-27 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:53 Yvan Roux
2015-03-27 18:14 ` Kyrill Tkachov [this message]
2015-04-13 10:47 ` Yvan Roux
2015-04-13 10:55 ` Kyrill Tkachov
2015-04-13 10:59 ` Yvan Roux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55159E05.6050005@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).