From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60303 invoked by alias); 27 Mar 2015 18:14:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60288 invoked by uid 89); 27 Mar 2015 18:14:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Mar 2015 18:14:33 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-4.uk.mimecast.lan; Fri, 27 Mar 2015 18:14:30 +0000 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 27 Mar 2015 18:14:29 +0000 Message-ID: <55159E05.6050005@arm.com> Date: Fri, 27 Mar 2015 18:14:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yvan Roux , "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , Richard Earnshaw Subject: Re: [PATCH, ARM] Fix arm_subsi3_insn alternatives References: In-Reply-To: X-MC-Unique: -_4RkQmwSTmw4_jgd8k8hA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01463.txt.bz2 On 24/03/15 19:53, Yvan Roux wrote: > Hi, > > after the issue with duplicated alternatives exhibited by PR64208, I > checked the arm.md file and found that *arm_subsi3_insn has a > duplication where alt 4 is (r,rI,r) and alt 6 is (r,r,r), this results > in emitting an rsb instruction instead of a sub one, but it has also > an impact on scheduling as the type attribute affected to alt 4 is > alu_imm when it could only involve registers. > > This is fixed by this small patch. Cross builded and regtested for > arm/armeb targets. > Ok for trunk (maybe for stage 1 as no PR is attached to that) ? Hi Yvan, I've kicked off two bootstraps of this patch on arm-none-linux-gnueabihf: one with arm mode and one with thumb. Both are well in stage3 so I don't=20 expect there to be any problems and the patch looks ok to me code-wise (though I can't approve). This is stage 1 material by now though since there's no regression=20 associated. Cheers, Kyrill > > Cheers, > Yvan > > 2105-03-24 Yvan Roux > > * config/arm/arm.md ("*arm_subsi3_insn"): Fixed redundant alternativ= es.