From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109803 invoked by alias); 27 Mar 2015 23:50:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 109777 invoked by uid 89); 27 Mar 2015 23:50:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx02.qsc.de Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 Mar 2015 23:50:28 +0000 Received: from tux.net-b.de (port-92-194-43-175.dynamic.qsc.de [92.194.43.175]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx02.qsc.de (Postfix) with ESMTPSA id CB30227644; Sat, 28 Mar 2015 00:50:23 +0100 (CET) Message-ID: <5515ECBE.2030700@net-b.de> Date: Fri, 27 Mar 2015 23:50:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Steve Kargl , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fortran/65429 -- don't dereference a null pointer References: <20150327224743.GA4459@troutmask.apl.washington.edu> In-Reply-To: <20150327224743.GA4459@troutmask.apl.washington.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg01470.txt.bz2 Steve Kargl wrote: > The following patch avoids the dereferencing of > a null pointer, which led to an ICE. The patch > here is a slight variation on the patch submitted > by drikosev at otenet dot gr. The testcase is a > slight variation on the code submitted by FX. > > Built and regression tested on x86_64-*-freebsd. > OK to commit? OK. However, could you additionally add "if (len(s) /= 5) call abort" to the test, just to make sure. (It works, I tried it :-) Thanks for the patch! Tobias > 2015-03-27 Steven G. Kargl > > PR fortran/65429 > * decl.c (add_init_expr_to_sym): Do not dereference a null pointer. > > 2015-03-27 Steven G. Kargl > > PR fortran/65429 > * pr65429.f90: New test.