From: Jason Merrill <jason@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [debug-early] equate new DIE with DW_AT_specificationto a previous declaration
Date: Fri, 03 Apr 2015 14:41:00 -0000 [thread overview]
Message-ID: <551EA684.8090600@redhat.com> (raw)
In-Reply-To: <55099EEB.70402@redhat.com>
On 03/18/2015 11:51 AM, Aldy Hernandez wrote:
> On 03/17/2015 07:12 PM, Jason Merrill wrote:
>> Why are we outlining a DECL_EXTERNAL function?
>
> SRA has no restrictions on whether a function is DECL_EXTERNAL.
Aha.
So it seems that DECL_EXTERNAL is the wrong gate for
equate_decl_number_to_die here. I think the rule we want is that if we
don't already have a non-declaration DIE for a function, we should
equate the new DIE. Let's remove the existing calls and replace them
with a single conditional call before the if (declaration).
Incidentally,
> /* A declaration that has been previously dumped needs no
> additional information. */
> if (dumped_early && declaration)
> return;
Do we need to check dumped_early here? I would think that any
declaration that has an old_die needs no additional information.
Jason
next prev parent reply other threads:[~2015-04-03 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 19:58 Aldy Hernandez
2015-03-18 2:12 ` Jason Merrill
2015-03-18 15:51 ` Aldy Hernandez
2015-04-03 14:41 ` Jason Merrill [this message]
2015-04-10 21:10 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551EA684.8090600@redhat.com \
--to=jason@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).